Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp5051008pxv; Tue, 6 Jul 2021 16:17:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzlNMbMMwoKXuIwBBsdesf7OI1+e7i7uTKaLSmOAQiLRSfjkRs7GAPfJ5sPOkR8hERK4WeI X-Received: by 2002:aa7:c68d:: with SMTP id n13mr26157919edq.33.1625613468144; Tue, 06 Jul 2021 16:17:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625613468; cv=none; d=google.com; s=arc-20160816; b=UCUfpElNowQ6exsQZJdtdjGCZfy+Ly9BC9ipFgJxc4e6o6TFNPpoCnQtouz2MWHCzK dC4+uUE9jV/AE9OO0DbTCKRuP732B2pXmeFHwP/PwmjN/HD5BU2zU7r/xtzlEnvQ3bVo oEpgt4rZN1gOFl2h2JqcMG13gCwjkiqavZNUMTkybqbqzI9qTAH8aBWGADBi/U/H2xXm Z/ZNJ/BxJBzCabS28nW4ItkHXQVQuzWN4tW4Rx+rdlP0YDE10Lb5DqjvbdktNkNhvowp 4MlajynTYWidm+fBe05dHdWmudX6qP2Rg9IAYJcetOgEb0+OSSgFebFcNAM8SptQp5qK WOKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=ynRZQxfaJcxR2TnlucKgHb+e8X4hV6x+hhnzhrLcUR8=; b=dW4TgbP/kFO/VWs+Z9vSCUe55zB98+aK6ZRIOGtdlWuPNiMGxnoOF5Js0+hOeRYz+2 PCm8Ydcs86q5VroUOWl+wm9b45HZ1PS6qFOTYAkin2BGeivccPwoYgUpwXbMe/T614ua 6m6nSEoH3jr/tHFsM+whPVMySdCG8p1vVq0F2pLE9my+JJmy33WbJjM4jFyYx4QQiPxO QiqixTYN/iNkz0cRa5Taw6z1Vat+aPtu74O04JX9n8IoRM31uO+0y9tZknTEt454r60w QV4nda4b9Trx6dRUwrpnk7QmJ1sNBSWpwd7mnRqhtam94vFdTMzoFoox4om3kCg9V18e 3E/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=rYjYsWEK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dp16si17982304ejc.454.2021.07.06.16.17.24; Tue, 06 Jul 2021 16:17:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=rYjYsWEK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229891AbhGFXRN (ORCPT + 99 others); Tue, 6 Jul 2021 19:17:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:55440 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229753AbhGFXRM (ORCPT ); Tue, 6 Jul 2021 19:17:12 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2EAEB61C83; Tue, 6 Jul 2021 23:14:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625613273; bh=T73yaSFXrDNYxqB9hxov58NWOm4NhSguozQkp5Mm6FY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=rYjYsWEKG4YbDT0a7BIv3ZMCc8gClTx2L30QzT8UyjfAe1NZQ2/WR8PwLrZD/mOOD 6tbGvUpm2flRzhJce7wfaQxf4GBrJQm/ggo/uGsJl/iHilvdrZVg49/jOIKKTqnACK tIyGA6pFu7FvnmWfAc4riV0an2V8w4LOqEbfLNEQHkqf9PdSiOMIG6j1wGfEMlOY+p 6ijN4nrnxJAY/RxQgrw/MPDh6DZLPjlaxLBljocdpOJI4UEH3g9gaCOUl2i3YgP3nQ 55zr26riv20uiSmJDX9E1Cp6X0bny1ETnAPggRrOSQxc2WBJbAiMGOOB7X/4bXQ6FM boNqt2C5sDYUQ== Date: Tue, 6 Jul 2021 16:14:32 -0700 From: Jakub Kicinski To: Guangbin Huang Cc: , , , , , Subject: Re: [RFC PATCH net-next 3/8] net: hns3: add support for devlink get info for PF Message-ID: <20210706161432.7196c6b4@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <1625553692-2773-4-git-send-email-huangguangbin2@huawei.com> References: <1625553692-2773-1-git-send-email-huangguangbin2@huawei.com> <1625553692-2773-4-git-send-email-huangguangbin2@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 6 Jul 2021 14:41:27 +0800 Guangbin Huang wrote: > + return devlink_info_version_running_put(req, "fw-version", version_str); Please use one of the existing names instead of "fw-version", e.g. DEVLINK_INFO_VERSION_GENERIC_FW.