Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Ismail, Mohammad Athari" <mohammad.athari.ismail@intel.com>
To:     Andrew Lunn <andrew@lunn.ch>,
        "Ling, Pei Lee" <pei.lee.ling@intel.com>
CC:     Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "Jakub Kicinski" <kuba@kernel.org>,
        Ioana Ciornei <ioana.ciornei@nxp.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Voon, Weifeng" <weifeng.voon@intel.com>,
        "vee.khee.wong@linux.intel.com" <vee.khee.wong@linux.intel.com>,
        "Wong, Vee Khee" <vee.khee.wong@intel.com>
Subject: RE: [PATCH net] net: phy: skip disabling interrupt when WOL is
 enabled in shutdown
Thread-Topic: [PATCH net] net: phy: skip disabling interrupt when WOL is
 enabled in shutdown
Thread-Index: AQHXckWstMlfSA9QTkGVkYpePnnwK6s17SOAgAC7sPA=
Date:   Wed, 7 Jul 2021 00:36:30 +0000
Message-ID: <CO1PR11MB4771EF640CBB88E9D96693FFD51A9@CO1PR11MB4771.namprd11.prod.outlook.com>
References: <20210706090209.1897027-1-pei.lee.ling@intel.com>
 <YORXMSmvqwYg7QA9@lunn.ch>
In-Reply-To: <YORXMSmvqwYg7QA9@lunn.ch>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.5.1.3
dlp-product: dlpe-windows
dlp-reaction: no-action
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+awXbbZBQDO5wp0e1HNxNYBbL+GcNukL2tAO9OND0AGzvbtpABZjuc+VUMOo?=
 =?us-ascii?Q?4ZDqLOgY4LxrcWPjAwMyoKaim0WuvNZeXTf7RlGPiBu9qmANlkHWOkeH1HBd?=
 =?us-ascii?Q?u0gAc4Ej+z16gNirPnR79biOT2roWwa+ixFx7CtnpWrVp/lxaWDgWd+r+Uvs?=
 =?us-ascii?Q?9H4SYjCSEQKJF+C3/K9SbdPhMcM4vUPsD6FKnPrfc3QZST4rW6pnjdv65Q9T?=
 =?us-ascii?Q?eBTWuwRHqhzsyaOd+seQI0JbYyBqXTj5cihszM51jMFpkyHgZEdXkz1PHHUE?=
 =?us-ascii?Q?nDZBPcmgsAE9xnbyF8LXcVu5U1vHSQBN6Z6Q0qQDzEYDL4F4uH2qS0c5rEDN?=
 =?us-ascii?Q?FIbXF6i6OnhhhrOBI4Bjy1wH/+Z5T9JJyO7UK8DD+4GepRhw36IYmjs1nER2?=
 =?us-ascii?Q?jMP/2Tx61lAzWRwYecTRA/yePtgbTmNWdYRw+h6LQCwcgBEA/6Y/+F1tv1O7?=
 =?us-ascii?Q?WeRKyzIzRNgz9GpeHvZcYVLBqOYmEiejaLZDxev7m98aWuOgrzTvDKY/aI7g?=
 =?us-ascii?Q?xVOZFJMnA7OtLYS9CdwW1mpPqiNje1pM2u5ltHpvHtt9CtthYZsWaAhAAKTw?=
 =?us-ascii?Q?ttp43Mz108xtjVVMwKwX0omkkAKR7pVriZgDuYtY9Pv4hSi2hXrP72oYd+TL?=
 =?us-ascii?Q?qHn+M7Ev6J/QLxJN5bNB0ZpQM8HgSrNEu12O85ZG4XdQLdxCOTqOKEo7zhRV?=
 =?us-ascii?Q?fWQgOP2RHpPuWf15jInvmcDIFvHo6d+3Z2empNWSQWnhOiv44O1CZNnDgvd7?=
 =?us-ascii?Q?MbjzOKdk9swl47HJPLylXn1s3aynlYpnUlG7itJR2ZYFiagSNzpPH4HhlqqK?=
 =?us-ascii?Q?TCJpFo04opOx3owTtuWlglT16/8gNkCfu72G0yan1clFDNyJypzVc6/kJKHs?=
 =?us-ascii?Q?jGvg8A0xySREq18LcII+KxPD75tDL5loI30YuHu0HPwP61/aaQZwhDRmfHmR?=
 =?us-ascii?Q?EdKE8BX3bl7RXRPPRLdW9l5noYtnHQJyNB9m/eCB1dRBmeIPYTjiC+f8LYeF?=
 =?us-ascii?Q?JjiNXSsrDcRLCWrqfYlJNt1cQausyQzliV8TkN64feJ7g3s8c5+ra0ku00qN?=
 =?us-ascii?Q?NDBttndPNWqYKOQrF4H/NAGWflt9aC9fDpkxi7FNy2pgRnZw8UGcJdolJUN+?=
 =?us-ascii?Q?m5sFQkBicvgUDpG9yLNsDAI2FhXj2lV6kz+eJPS0CoOLmXgf6hOi6DHMzYj4?=
 =?us-ascii?Q?LfTzC0+61eYPcBsYh0rmKBC+PssMq7TPtw5+/OlydfoPz1rP7JD1Ak+jSUG3?=
 =?us-ascii?Q?frMivI8IY+UaxOf8dt2/91pqOGNJQB5r0lIvKWvVoC1BaUnTettlvlm7dksq?=
 =?us-ascii?Q?Z5u6brG+nMxwqr3/OMWR+iTy?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4771.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 341dbfb9-5f68-4f42-51b5-08d940df439c
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jul 2021 00:36:30.4982
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 57LUs96ODrYJ7FbOaTHjCyl6cywveU/rI6F03qXn5fqTyowase+uBx0bthtHfAuup4byBo3jHW933E/dAlb4T/UgpOAqzckXnd7Lw+clULgpn6OR3IVB5q3ypu4ibN+1
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2143
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Andrew Lunn <andrew@lunn.ch>
> Sent: Tuesday, July 6, 2021 9:14 PM
> To: Ling, Pei Lee <pei.lee.ling@intel.com>
> Cc: Heiner Kallweit <hkallweit1@gmail.com>; Russell King
> <linux@armlinux.org.uk>; davem@davemloft.net; Jakub Kicinski
> <kuba@kernel.org>; Ioana Ciornei <ioana.ciornei@nxp.com>;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Voon, Weifeng
> <weifeng.voon@intel.com>; vee.khee.wong@linux.intel.com; Wong, Vee Khee
> <vee.khee.wong@intel.com>; Ismail, Mohammad Athari
> <mohammad.athari.ismail@intel.com>
> Subject: Re: [PATCH net] net: phy: skip disabling interrupt when WOL is e=
nabled
> in shutdown
>=20
> On Tue, Jul 06, 2021 at 05:02:09PM +0800, Ling Pei Lee wrote:
> > From: Mohammad Athari Bin Ismail <mohammad.athari.ismail@intel.com>
> >
> > PHY WOL requires WOL interrupt event to trigger the WOL signal in
> > order to wake up the system. Hence, the PHY driver should not disable
> > the interrupt during shutdown if PHY WOL is enabled.
>=20
> If the device is being used to wake the system up, why is it being shutdo=
wn?
>=20

Hi Andrew,

When the platform goes to S5 state (ex: shutdown -h now), regardless PHY WO=
L is enabled or not, phy_shutdown() is called. So, for the platform that su=
pport WOL from S5, we need to make sure the PHY still can trigger WOL event=
. Disabling the interrupt through phy_disable_interrupts() in phy_shutdown(=
) will disable WOL interrupt as well and cause the PHY WOL not able to trig=
ger.

-Athari-

> 	Andrew