Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [smartpqi updates PATCH 2/9] smartpqi: rm unsupported controller
 features msgs
To:     Don Brace <don.brace@microchip.com>,
        Kevin Barnett <kevin.barnett@microchip.com>
Cc:     scott.teel@microchip.com, Justin.Lindley@microchip.com,
        scott.benesh@microchip.com, gerry.morong@microchip.com,
        mahesh.rajashekhara@microchip.com, mike.mcgowen@microchip.com,
        murthy.bhat@microchip.com, balsundar.p@microchip.com,
        joseph.szczypek@hpe.com, jeff@canonical.com, POSWALD@suse.com,
        john.p.donnelly@oracle.com, mwilck@suse.com,
        linux-kernel@vger.kernel.org,
        Christoph Hellwig <hch@infradead.org>,
        martin.peterson@oracle.com, jejb@linux.vnet.ibm.com,
        linux-scsi@vger.kernel.org
References: <20210706181618.27960-1-don.brace@microchip.com>
 <20210706181618.27960-3-don.brace@microchip.com>
From:   Paul Menzel <pmenzel@molgen.mpg.de>
Message-ID: <17eeaf22-4625-d733-dcfb-ec2322dd0ca6@molgen.mpg.de>
Date:   Wed, 7 Jul 2021 09:28:46 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <20210706181618.27960-3-don.brace@microchip.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

Dear Kevin, dear Don,


Am 06.07.21 um 20:16 schrieb Don Brace:
> From: Kevin Barnett <kevin.barnett@microchip.com>
> 
> Remove "Feature XYZ not supported by controller" messages.
> 
> During driver initialization, the driver examines the PQI Table Feature bits.
> These bits are used by the controller to advertise features supported by the
> controller. For any features not supported by the controller, the driver would
> display a message in the form:
>          "Feature XYZ not supported by controller"
> Some of these "negative" messages were causing customer confusion.

As it’s info log level and not warning or notice, these message are 
useful in my opinion. You could downgrade them to debug, but I do not 
see why. If customers do not want to see these info messages, they 
should filter them out.

For completeness, is there an alternative to list the unsupported 
features from the firmware for example from sysfs?


Kind regards,

Paul


> Reviewed-by: Mike McGowen <mike.mcgowen@microchip.com>
> Reviewed-by: Scott Benesh <scott.benesh@microchip.com>
> Reviewed-by: Scott Teel <scott.teel@microchip.com>
> Signed-off-by: Kevin Barnett <kevin.barnett@microchip.com>
> Signed-off-by: Don Brace <don.brace@microchip.com>
> ---
>   drivers/scsi/smartpqi/smartpqi_init.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/scsi/smartpqi/smartpqi_init.c b/drivers/scsi/smartpqi/smartpqi_init.c
> index d977c7b30d5c..7958316841a4 100644
> --- a/drivers/scsi/smartpqi/smartpqi_init.c
> +++ b/drivers/scsi/smartpqi/smartpqi_init.c
> @@ -7255,11 +7255,8 @@ struct pqi_firmware_feature {
>   static void pqi_firmware_feature_status(struct pqi_ctrl_info *ctrl_info,
>   	struct pqi_firmware_feature *firmware_feature)
>   {
> -	if (!firmware_feature->supported) {
> -		dev_info(&ctrl_info->pci_dev->dev, "%s not supported by controller\n",
> -			firmware_feature->feature_name);
> +	if (!firmware_feature->supported)
>   		return;
> -	}
>   
>   	if (firmware_feature->enabled) {
>   		dev_info(&ctrl_info->pci_dev->dev,
>