Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <CADxRZqzcrnSMzy50T+kWb_mQVguWDCMu6RoXsCc+-fNDPYXbaw@mail.gmail.com>
 <20210705195638.GA53988@C02TD0UTHF1T.local> <20210706091104.GA69200@C02TD0UTHF1T.local>
 <CADxRZqxNdYBAs1daPJTAPKGeJx30D+v7xz87K2sB_dXYKdTrVg@mail.gmail.com> <20210706120030.GB69200@C02TD0UTHF1T.local>
In-Reply-To: <20210706120030.GB69200@C02TD0UTHF1T.local>
From:   Anatoly Pugachev <matorola@gmail.com>
Date:   Wed, 7 Jul 2021 10:47:06 +0300
Message-ID: <CADxRZqyQq4X-p=BpkpwcKUnLJAeZBLBLZ1u9fOkp74URR4Nb0Q@mail.gmail.com>
Subject: Re: [sparc64] locking/atomic, kernel OOPS on running stress-ng
To:     Mark Rutland <mark.rutland@arm.com>
Cc:     Peter Zijlstra <peterz@lists.infradead.org>,
        Linux Kernel list <linux-kernel@vger.kernel.org>,
        Sparc kernel list <sparclinux@vger.kernel.org>,
        debian-sparc <debian-sparc@lists.debian.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Jul 6, 2021 at 3:00 PM Mark Rutland <mark.rutland@arm.com> wrote:
> On Tue, Jul 06, 2021 at 02:51:06PM +0300, Anatoly Pugachev wrote:
> > On Tue, Jul 6, 2021 at 12:11 PM Mark Rutland <mark.rutland@arm.com> wrote:
> > > Fixes: ff5b4f1ed580c59d ("locking/atomic: sparc: move to ARCH_ATOMIC")
> > > Signed-off-by: Mark Rutland <mark.rutland@arm.com>
> > > Reported-by: Anatoly Pugachev <matorola@gmail.com>
> > > Cc: "David S. Miller" <davem@davemloft.net>
> > > Cc: Peter Zijlstra <peterz@lists.infradead.org>
> > > ---
> > >  arch/sparc/include/asm/cmpxchg_64.h | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/arch/sparc/include/asm/cmpxchg_64.h b/arch/sparc/include/asm/cmpxchg_64.h
> > > index 8c39a9981187..12d00a42c0a3 100644
> > > --- a/arch/sparc/include/asm/cmpxchg_64.h
> > > +++ b/arch/sparc/include/asm/cmpxchg_64.h
> > > @@ -201,7 +201,7 @@ static inline unsigned long __cmpxchg_local(volatile void *ptr,
> > >  #define arch_cmpxchg64_local(ptr, o, n)                                        \
> > >    ({                                                                   \
> > >         BUILD_BUG_ON(sizeof(*(ptr)) != 8);                              \
> > > -       cmpxchg_local((ptr), (o), (n));                                 \
> > > +       arch_cmpxchg_local((ptr), (o), (n));                                    \
> > >    })
> > >  #define arch_cmpxchg64(ptr, o, n)      arch_cmpxchg64_local((ptr), (o), (n))
> >
> >
> > Mark, thanks, fixed...
> > tested on git kernel 5.13.0-11788-g79160a603bdb-dirty (dirty - cause
> > patch has been applied).
>
> Great! Thanks for confirming.
>
> Peter, are you happy to pick that (full commit in last mail), or should
> I send a new copy?

It would be nice if patch could hit the kernel before v5.14-rc1

Thanks.