Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp5350725pxv; Wed, 7 Jul 2021 01:27:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx0XeF1q3lpp/wVY1q+++cu/8fK4ui4K0gyFVHzy/dCBkD4H1qGbjkOUstFEO1rjd/TnmsJ X-Received: by 2002:a05:6638:2245:: with SMTP id m5mr5256363jas.137.1625646465827; Wed, 07 Jul 2021 01:27:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625646465; cv=none; d=google.com; s=arc-20160816; b=gu9uZGpTkbGJUaqU7geCua7y5rCvhwq1rQovPe7uh76+/n4gZ5PSjLNtoy6Z/zTNkf 6rvegf7+I09SK02FOJyB5ytm/kGcCKoYnPCeWqDD1GeOVnBvurxBCh0J5h+raXo0z6OI OlEKenxMGP3cSu5arGDck8cM6/strqInLSPx53Dxxp3WUMdsD9KcNH2UvRjFZIon6200 6kyswbk4urf46wNH+pGeb7YjHB7WuRpNjZmiWDfCnEXsuVQNOXw8UtwhBD0JsFE87WvX +D1u0uk2MI8TtpgV8rRJbAtRGVn2nvy2Y3CGkTNcNoScWjIPlLdoI6gTWV48AcdaOJCN ulPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=vRTIwf9tfcfk0xTXQgsXhNSZGa6W8Al74c2nAHqeehE=; b=Xok/cuygqdHSleogZV8RG/1erkEtHjid7msv/kPPzaSTTKEgL9xCIQnRXieTh8BNc7 LQQ9Dbxyxa5IFtE9aY8ASJn+T3W2GMJnpfMh3Vx00pYu8zR1nRBhYsbzFcxHwZAWlSCh DD05+mlOzYB5tL76IP0Fd/kIeU/gnwLhl0/UC6kAX/Bib4L2cniCp1BawfoIUgnsudZE TJ7VXt2Q9bTeuc7AdSFOQJKznAiB7d8bmTCW1h9ckVn2wWK0uz5mkQ8AttxLM3BBvD/K 5/XUa3XSoCYiCMSuGoMo0Oi0RZZoWgZ+SBbUxrIIcvMQHx6XOndC1pN95HM5hfEcLsc2 dfJw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f16si22680385ilc.93.2021.07.07.01.27.33; Wed, 07 Jul 2021 01:27:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230126AbhGGI3i (ORCPT + 99 others); Wed, 7 Jul 2021 04:29:38 -0400 Received: from foss.arm.com ([217.140.110.172]:59624 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230073AbhGGI3i (ORCPT ); Wed, 7 Jul 2021 04:29:38 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 66B82ED1; Wed, 7 Jul 2021 01:26:58 -0700 (PDT) Received: from C02TD0UTHF1T.local (unknown [10.57.2.215]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EB7C43F694; Wed, 7 Jul 2021 01:26:56 -0700 (PDT) Date: Wed, 7 Jul 2021 09:26:47 +0100 From: Mark Rutland To: Anatoly Pugachev Cc: Peter Zijlstra , Linux Kernel list , Sparc kernel list , debian-sparc Subject: Re: [sparc64] locking/atomic, kernel OOPS on running stress-ng Message-ID: <20210707082636.GA94463@C02TD0UTHF1T.local> References: <20210705195638.GA53988@C02TD0UTHF1T.local> <20210706091104.GA69200@C02TD0UTHF1T.local> <20210706120030.GB69200@C02TD0UTHF1T.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 07, 2021 at 10:47:06AM +0300, Anatoly Pugachev wrote: > On Tue, Jul 6, 2021 at 3:00 PM Mark Rutland wrote: > > On Tue, Jul 06, 2021 at 02:51:06PM +0300, Anatoly Pugachev wrote: > > > On Tue, Jul 6, 2021 at 12:11 PM Mark Rutland wrote: > > > > Fixes: ff5b4f1ed580c59d ("locking/atomic: sparc: move to ARCH_ATOMIC") > > > > Signed-off-by: Mark Rutland > > > > Reported-by: Anatoly Pugachev > > > > Cc: "David S. Miller" > > > > Cc: Peter Zijlstra > > > > --- > > > > arch/sparc/include/asm/cmpxchg_64.h | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/arch/sparc/include/asm/cmpxchg_64.h b/arch/sparc/include/asm/cmpxchg_64.h > > > > index 8c39a9981187..12d00a42c0a3 100644 > > > > --- a/arch/sparc/include/asm/cmpxchg_64.h > > > > +++ b/arch/sparc/include/asm/cmpxchg_64.h > > > > @@ -201,7 +201,7 @@ static inline unsigned long __cmpxchg_local(volatile void *ptr, > > > > #define arch_cmpxchg64_local(ptr, o, n) \ > > > > ({ \ > > > > BUILD_BUG_ON(sizeof(*(ptr)) != 8); \ > > > > - cmpxchg_local((ptr), (o), (n)); \ > > > > + arch_cmpxchg_local((ptr), (o), (n)); \ > > > > }) > > > > #define arch_cmpxchg64(ptr, o, n) arch_cmpxchg64_local((ptr), (o), (n)) > > > > > > > > > Mark, thanks, fixed... > > > tested on git kernel 5.13.0-11788-g79160a603bdb-dirty (dirty - cause > > > patch has been applied). > > > > Great! Thanks for confirming. > > > > Peter, are you happy to pick that (full commit in last mail), or should > > I send a new copy? > > It would be nice if patch could hit the kernel before v5.14-rc1 Absolutely; I'll resend this on it's own so that it's easier for folk to pick, and I'll poke people about picking it. Mark.