From: Eric Dumazet <dada1@cosmosbay.com>
To: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Subject: Re: [PATCH] Fix strange size check in __get_vm_area_node()
Date: Wed, 15 Nov 2006 18:51:09 +0100
User-Agent: KMail/1.9.5
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
References: <87k61wa9to.fsf@duaron.myhome.or.jp>
In-Reply-To: <87k61wa9to.fsf@duaron.myhome.or.jp>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200611151851.09649.dada1@cosmosbay.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 749
Lines: 27

On Wednesday 15 November 2006 18:39, OGAWA Hirofumi wrote:
> Recently, __get_vm_area_node() was changed like following
>
>  	if (unlikely(!area))
>  		return NULL;
>
> -	if (unlikely(!size)) {
> -		kfree (area);
> +	if (unlikely(!size))
>  		return NULL;
> -	}
>
> It is leaking `area', also original code seems strange already.
> Probably, we wanted to do this patch.
>

Indeed. I checked my original patch and it was correct. I dont know what 
happened then...

http://lkml.org/lkml/2006/10/23/86

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/