Received: by 2002:aa6:da0e:0:b029:115:a171:fe4c with SMTP id z14csp1244029lkb; Wed, 7 Jul 2021 02:22:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx7K87vJ0NviZcFG95Mzd5KM/3fkfDui7E7DP3lMJLbIQ2lc02X0E5RUCD+RGjAamhMipjZ X-Received: by 2002:a6b:181:: with SMTP id 123mr3079235iob.114.1625649749590; Wed, 07 Jul 2021 02:22:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625649749; cv=none; d=google.com; s=arc-20160816; b=eTbdWxrETJWmx6nIEB+EZ6NzE723fG8zOV1Hj8prEdOmpAirRDAgfec+nxcA+fC5Dz ZxR43yFzM3SJiSWl1c5VjRCZkcLx1KvogXCn9l1rDkHJ8EyqZjXlqKqWuhP/qkR0vHjD 8tJ9MVKexnGNN1tQC1TPm/N1GJcI6RrOog6OTPirNGxpvCyRcn73Kv/N0ldriryv6RMB A8CXcDfcFFx84A2F6UQvNVlPlNcVcDKbZ8r38GD/6GsSqn++Ol5ybW1vCdA0JgTcTcLf m9XC9jiIGep5rkI3edY8mmVb33aI/q4W0iw7BLdnPb7SymZsw9fiA/4d32qn07O0GhwH zDGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:references:cc:to :subject; bh=3ZhxNtcxWru9y9vLpMlQVaKFe63ZPhVolgcN/HuytCY=; b=hKa2x/mUddIuXgd6kTuNby12r+Rax+ORKNhleap62jEv0h49Htuiks2H3jNcDfPT9o 6WZA2n0idhfx9GX4zq6xTqsRWamNKUbJ26/jVTTDYGsoZs5op/ocsHKyv0fr+MTyqmQI 1RNhPfdbFImaArNCcWW1upfpKSK7eNrBIvrnPhUaN/d/vSkRb1uLaZdWe7dCG69NdcoO +DpSEaPvv3v1DYGBHg/EQYcZnM9EIP7QSBbLoduzxwGm026+bvuZsz7g36qMUt0cQcZz aUIKVjiqNUQz68SQnzN9wG0ukl6ri4vRT4E3Qfx6pN06YOzrC2FuccCF0Wye1hxzgZW4 MM9w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w25si7821220ioc.20.2021.07.07.02.22.17; Wed, 07 Jul 2021 02:22:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231317AbhGGJY0 (ORCPT + 99 others); Wed, 7 Jul 2021 05:24:26 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:14033 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231142AbhGGJYZ (ORCPT ); Wed, 7 Jul 2021 05:24:25 -0400 Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4GKYkc3Lz7zZnf9; Wed, 7 Jul 2021 17:18:32 +0800 (CST) Received: from dggemi759-chm.china.huawei.com (10.1.198.145) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Wed, 7 Jul 2021 17:21:44 +0800 Received: from [10.67.102.67] (10.67.102.67) by dggemi759-chm.china.huawei.com (10.1.198.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Wed, 7 Jul 2021 17:21:29 +0800 Subject: Re: [RFC PATCH net-next 3/8] net: hns3: add support for devlink get info for PF To: Jakub Kicinski CC: , , , , , References: <1625553692-2773-1-git-send-email-huangguangbin2@huawei.com> <1625553692-2773-4-git-send-email-huangguangbin2@huawei.com> <20210706161432.7196c6b4@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> From: "huangguangbin (A)" Message-ID: <7a2b4cec-20b2-82c7-805c-0c849035f2bc@huawei.com> Date: Wed, 7 Jul 2021 17:21:28 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20210706161432.7196c6b4@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.102.67] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggemi759-chm.china.huawei.com (10.1.198.145) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/7/7 7:14, Jakub Kicinski wrote: > On Tue, 6 Jul 2021 14:41:27 +0800 Guangbin Huang wrote: >> + return devlink_info_version_running_put(req, "fw-version", version_str); > > Please use one of the existing names instead of "fw-version", > e.g. DEVLINK_INFO_VERSION_GENERIC_FW. > . > Ok, thanks.