Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Wed, 07 Jul 2021 13:31:49 +0200
From:   Michael Walle <michael@walle.cc>
To:     Steam Lin <lstfazz@gmail.com>
Cc:     tudor.ambarus@microchip.com, p.yadav@ti.com,
        miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com,
        linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd:spi-nor:Update Winbond SPI NOR Flash device ID
In-Reply-To: <20210707101628.GA27472@pn10-Veriton-X4610>
References: <20210707101628.GA27472@pn10-Veriton-X4610>
User-Agent: Roundcube Webmail/1.4.11
Message-ID: <35c2e5faa770e228bd16a2186c8caf78@walle.cc>
Precedence: bulk

Hi,

Am 2021-07-07 12:16, schrieb Steam Lin:
> This patch is to update Winbond SPI NOR device
> ID information.
> Add new 3.3V and 1.8V device in the ID table.
> 
> Signed-off-by: Steam Lin <Stlin2@winbond.com>
> ---
>  drivers/mtd/spi-nor/winbond.c | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/drivers/mtd/spi-nor/winbond.c 
> b/drivers/mtd/spi-nor/winbond.c
> index 9a81c67a60c6..01aa49954793 100644
> --- a/drivers/mtd/spi-nor/winbond.c
> +++ b/drivers/mtd/spi-nor/winbond.c
> @@ -102,6 +102,20 @@ static const struct flash_info winbond_parts[] = {
>  			    SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },
>  	{ "w25q512jvq", INFO(0xef4020, 0, 64 * 1024, 1024,
>  			     SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> +	{ "w25h512jvm", INFO(0xef9020, 0, 64 * 1024, 1024,
> +			     SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> +	{ "w25q01jvq", INFO(0xef4021, 0, 64 * 1024, 2048,
> +			     SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> +	{ "w25q02jvq", INFO(0xef4022, 0, 64 * 1024, 4096,
> +			     SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> +	{ "w25h01jvm", INFO(0xef9021, 0, 64 * 1024, 2048,
> +			     SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> +	{ "w25h02jvm", INFO(0xef9022, 0, 64 * 1024, 4096,
> +			     SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> +	{ "w25q512nwq", INFO(0xef6020, 0, 64 * 1024, 1024,
> +			     SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> +	{ "w25q512nwm", INFO(0xef8020, 0, 64 * 1024, 1024,
> +			     SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
>  };

Nice to see patches from the vendor! Did you test these devices? We
only accept new IDs which are actually tested. And are you aware of any
ID collisions of these chips? Eg. sometimes the JWM reused the ID of the
FW variant. How can we distinguish these?

Also, you will have to supply SFDP data for all these chips, please have
a look at [1] how to do that.

[1] 
https://lore.kernel.org/linux-mtd/7038f037de3e224016d269324517400d@walle.cc/


-michael