Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Cornelia Huck <cohuck@redhat.com>
To:     Janis Schoetterl-Glausch <scgl@linux.vnet.ibm.com>,
        Christian Borntraeger <borntraeger@de.ibm.com>,
        Janis Schoetterl-Glausch <scgl@linux.ibm.com>,
        Janosch Frank <frankja@linux.ibm.com>,
        Heiko Carstens <hca@linux.ibm.com>,
        Vasily Gorbik <gor@linux.ibm.com>
Cc:     David Hildenbrand <david@redhat.com>,
        Claudio Imbrenda <imbrenda@linux.ibm.com>,
        "open list:KERNEL VIRTUAL MACHINE for s390 (KVM/s390)" 
        <kvm@vger.kernel.org>,
        "open list:S390" <linux-s390@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] KVM: s390: Enable specification exception interpretation
In-Reply-To: <243a5476-153f-8d4b-7e0a-bb291010a3bd@linux.vnet.ibm.com>
Organization: Red Hat GmbH
References: <20210706114714.3936825-1-scgl@linux.ibm.com>
 <05430c91-6a84-0fc9-0af4-89f408eb691f@de.ibm.com>
 <87lf6ifqs5.fsf@redhat.com>
 <243a5476-153f-8d4b-7e0a-bb291010a3bd@linux.vnet.ibm.com>
User-Agent: Notmuch/0.32.1 (https://notmuchmail.org)
Date:   Wed, 07 Jul 2021 13:42:23 +0200
Message-ID: <87im1mfizk.fsf@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

On Wed, Jul 07 2021, Janis Schoetterl-Glausch <scgl@linux.vnet.ibm.com> wrote:

> On 7/7/21 10:54 AM, Cornelia Huck wrote:
>
> [...]
>
>> 
>>>> diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
>>>> index b655a7d82bf0..aadd589a3755 100644
>>>> --- a/arch/s390/kvm/kvm-s390.c
>>>> +++ b/arch/s390/kvm/kvm-s390.c
>>>> @@ -3200,6 +3200,8 @@ static int kvm_s390_vcpu_setup(struct kvm_vcpu *vcpu)
>>>>   		vcpu->arch.sie_block->ecb |= ECB_SRSI;
>>>>   	if (test_kvm_facility(vcpu->kvm, 73))
>>>>   		vcpu->arch.sie_block->ecb |= ECB_TE;
>> 
>> Maybe add
>> 
>> /* no facility bit, but safe as the hardware may ignore it */
>> 
>> or something like that, so that we don't stumble over that in the future?
>
> Well, the hardware being allowed to ignore the bit makes its introduction
> without an indication forward compatible because it does not require vSIE to be adapted.
> The reserved bits are implicitly set to 0 which means new features are disabled
> by default and one observes all the interception one expects.
>
> Maybe this:
>
> /* no facility bit, can opt in because we do not need
>    to observe specification exception intercepts */
>
> ?

Works for me as well.

>
>> 
>>>> +	if (!kvm_is_ucontrol(vcpu->kvm))
>>>> +		vcpu->arch.sie_block->ecb |= ECB_SPECI;
>>>>
>>>>   	if (test_kvm_facility(vcpu->kvm, 8) && vcpu->kvm->arch.use_pfmfi)
>>>>   		vcpu->arch.sie_block->ecb2 |= ECB2_PFMFI;
>> 
>> Reviewed-by: Cornelia Huck <cohuck@redhat.com>
>>