Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp5555293pxv; Wed, 7 Jul 2021 06:33:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzYlEFdOV9FlJks9FQrJDi51KJH8fyOIy2+nhpK7IFzKSnbjNPR5L1Nrlcl34xIIuG/z5H+ X-Received: by 2002:a17:906:e256:: with SMTP id gq22mr24151932ejb.248.1625664783241; Wed, 07 Jul 2021 06:33:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625664783; cv=none; d=google.com; s=arc-20160816; b=LLWYoGeARjvYBoga4jeG0FnZi1v305hj51H9A1njWLpHPE5TCIyOok15BBB147feFv M2eLcTPpjHBCnWYpe770BAzLqpn1y1klg0G4SPzSnT/FGlGz7Mt327k/R+G8QqPg0kL4 AyY0Zbfh1sz6hDX3FxvnUUIGmuR3hz3mfzgnL1ghupqbwhtSkLYPUU1ed7C1mf6mHzQG LMBDO2Lo4pocDVT03LoP4Des9wMcg1st3dakXkdIDZ53mCZHI85zlhoCTRwZULCooXBv r2bdnDWIHUayY1WwHcfh+zLxW4vjEvca5HczMgB8M2aFLa/NYP8ga4ccgQhRyVovEJlF E88Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=MOUWURo5NhcoU8dG0lYdIV3UEA0cYYpbDub+4Ohv2No=; b=WYzq7KUIjIH67BJZ3VonbV8Y9qVxYWYi3DatYygfDSbB81fdgNkLge79t/eH7BqLAm EIcGmNP/h1XGF/Mdm401o35l4TfMQlcVPueurvalbauk667JxMgYfcwVtdvdg5xNLU+T owW66Nohk9ADPDbetz8d46g8bb3GovT/Ga/BBpJOMx73hmBUNjyFEe1fkXSfXkvMesLg Do/NqAaOINbdhAnDFXkTyv3+j95QNcU384fhMDROVSqOdfjSelAzAlswHirinyQBKzdO fPV58gVC+JoJuyAUxhYusjMDAAyc0+gs0AF9U6Pmf2o3hTQxsQZo4PkpxtNdYy53UYoN +NJw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Qim8foHG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l33si22718963ede.457.2021.07.07.06.32.39; Wed, 07 Jul 2021 06:33:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Qim8foHG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231704AbhGGNcK (ORCPT + 99 others); Wed, 7 Jul 2021 09:32:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:35498 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231357AbhGGNcJ (ORCPT ); Wed, 7 Jul 2021 09:32:09 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4C59160D07; Wed, 7 Jul 2021 13:29:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625664569; bh=5r0H24J6y+tSw0QazP/TcXzQ2gQzcMt1BZjeoEwGo2Y=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Qim8foHGFlqwraQb2h1SwhnqBL0PrPz55T05poQFYYFfBWDm8Efi/22zvSvzea3WI mh7aCRtegrQ2kX0MAvHRbRmXWif3E6OPX4ju1ugXLfrAembNgxRnsgTPQ+b7TarGsG W++BfjV0kgY2VFOapCrQWfg/FkRCa0HTi7Cki9cB5gNtJMJAipww8FVXsKu3bJVhUG 2siWtnfFxS7a7XZhpvdbbWiySiCac1MWWALto4kNGm3Q7+3UQdSMnFpuSBJatrFHLV w52vBtWrhpdQPokt+sbWSYtNlEpgMKdMpbrw4sUB0hZP6rySvZXX9GpFjjaikLsDp+ 3vzC7Uv/8ChCQ== Date: Wed, 7 Jul 2021 22:29:25 +0900 From: Masami Hiramatsu To: Masami Hiramatsu Cc: Peter Zijlstra , Steven Rostedt , Josh Poimboeuf , Ingo Molnar , X86 ML , Daniel Xu , linux-kernel@vger.kernel.org, bpf@vger.kernel.org, kuba@kernel.org, mingo@redhat.com, ast@kernel.org, Thomas Gleixner , Borislav Petkov , kernel-team@fb.com, yhs@fb.com, linux-ia64@vger.kernel.org, Abhishek Sagar , Andrii Nakryiko , wuqiang.matt@bytedance.com Subject: Re: [PATCH -tip v8 11/13] x86/unwind: Recover kretprobe trampoline entry Message-Id: <20210707222925.87ecc1391d0ab61db3d8398e@kernel.org> In-Reply-To: <20210707194530.766a9c8364f3b2d7714ca590@kernel.org> References: <162399992186.506599.8457763707951687195.stgit@devnote2> <162400002631.506599.2413605639666466945.stgit@devnote2> <20210706004257.9e282b98f447251a380f658f@kernel.org> <20210706111136.7c5e9843@oasis.local.home> <20210707191510.cb48ca4a20f0502ce6c46508@kernel.org> <20210707194530.766a9c8364f3b2d7714ca590@kernel.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 7 Jul 2021 19:45:30 +0900 Masami Hiramatsu wrote: > On Wed, 7 Jul 2021 12:20:57 +0200 > Peter Zijlstra wrote: > > > On Wed, Jul 07, 2021 at 07:15:10PM +0900, Masami Hiramatsu wrote: > > > > > I actually don't want to keep this feature because no one use it. > > > (only systemtap needs it?) > > > > Yeah, you mentioned systemtap, but since that's out-of-tree I don't > > care. Their problem. Yeah, maybe it is not hard to update. > > > > > Anyway, if we keep the idea-level compatibility (not code level), > > > what we need is 'void *data' in the struct kretprobe_instance. > > > User who needs it can allocate their own instance data for their > > > kretprobes when initialising it and sets in their entry handler. > > > > > > Then we can have a simple kretprobe_instance. > > > > When would you do the alloc? When installing the retprobe, but that > > might be inside the allocator, which means you can't call the allocator > > etc.. :-) > > Yes, so the user may need to allocate a pool right before register_kretprobe(). > (whether per-kretprobe or per-task or global pool, that is user's choice.) > > > > > If we look at struct ftrace_ret_stack, it has a few fixed function > > fields. The calltime one is all that is needed for the kretprobe > > example code. > > kretprobe consumes 3 fields, a pointer to 'struct kretprobe' (which > stores callee function address in 'kretprobe::kp.addr'), a return > address and a frame pointer (*). Oops, I forgot to add "void *data" for storing user data. Thank you, -- Masami Hiramatsu