Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Uladzislau Rezki <urezki@gmail.com>
Date:   Wed, 7 Jul 2021 16:49:21 +0200
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     "Uladzislau Rezki (Sony)" <urezki@gmail.com>, linux-mm@kvack.org,
        LKML <linux-kernel@vger.kernel.org>,
        Mel Gorman <mgorman@suse.de>,
        Christoph Hellwig <hch@infradead.org>,
        Matthew Wilcox <willy@infradead.org>,
        Nicholas Piggin <npiggin@gmail.com>,
        Hillf Danton <hdanton@sina.com>,
        Michal Hocko <mhocko@suse.com>,
        Oleksiy Avramchenko <oleksiy.avramchenko@sonymobile.com>,
        Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH v2 1/2] mm/vmalloc: Use batched page requests in
 bulk-allocator
Message-ID: <20210707144921.GC1863@pc638.lan>
References: <20210705170537.43060-1-urezki@gmail.com>
 <20210706132653.8374852963b25989e360d599@linux-foundation.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210706132653.8374852963b25989e360d599@linux-foundation.org>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Tue, Jul 06, 2021 at 01:26:53PM -0700, Andrew Morton wrote:
> On Mon,  5 Jul 2021 19:05:36 +0200 "Uladzislau Rezki (Sony)" <urezki@gmail.com> wrote:
> 
> > In case of simultaneous vmalloc allocations, for example it is 1GB and
> > 12 CPUs my system is able to hit "BUG: soft lockup" for !CONFIG_PREEMPT
> > kernel.
> > 
> > <snip>
> > ...
> >
> > are obtained, i.e. do batched page requests adding cond_resched() meanwhile
> > to reschedule. Batched value is hard-coded and is 100 pages per call.
> > 
> > Signed-off-by: Uladzislau Rezki (Sony) <urezki@gmail.com>
> 
> Can we please have a Fixes: for this?
> 
> Is this fix important enough for 4.14-rcx?  I think so...
> 
> > --- a/mm/vmalloc.c
> > +++ b/mm/vmalloc.c
> > @@ -2785,10 +2785,32 @@ vm_area_alloc_pages(gfp_t gfp, int nid,
> >  	 * to fails, fallback to a single page allocator that is
> >  	 * more permissive.
> >  	 */
> > -	if (!order)
> > -		nr_allocated = alloc_pages_bulk_array_node(
> > -			gfp, nid, nr_pages, pages);
> > -	else
> > +	if (!order) {
> > +		while (nr_allocated < nr_pages) {
> > +			int nr, nr_pages_request;
> > +
> > +			/*
> > +			 * A maximum allowed request is hard-coded and is 100
> > +			 * pages per call. That is done in order to prevent a
> > +			 * long preemption off scenario in the bulk-allocator
> > +			 * so the range is [1:100].
> > +			 */
> > +			nr_pages_request = min(100, (int)(nr_pages - nr_allocated));
> 
> Yes, they types are all over the place.
> 
> nr_pages: unsigned long
> nr_allocated: unsigned int
> nr, nr_pages_request: int
> 
> Can we please choose the most appropriate type and use that
> consistently?
> 
Let me think over it to see what i can do.

--
Vlad Rezki