Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 7 Jul 2021 15:20:43 +0100
From:   Sergei Trofimovich <slyfox@gentoo.org>
To:     Eric Dumazet <edumazet@google.com>
Cc:     netdev <netdev@vger.kernel.org>, Florian Westphal <fw@strlen.de>,
        "David S . Miller" <davem@davemloft.net>,
        LKML <linux-kernel@vger.kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Mat Martineau <mathew.j.martineau@linux.intel.com>,
        Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH] net: core: fix SO_TIMESTAMP_* option setting
Message-ID: <20210707152043.46e78f45@zn3>
In-Reply-To: <CANn89iL=uQto2PSNj9Xjt5NFrqKQgVzvYY1T++-Kw_OTfsPwgA@mail.gmail.com>
References: <20210707092731.2499-1-slyfox@gentoo.org>
        <CANn89iL=uQto2PSNj9Xjt5NFrqKQgVzvYY1T++-Kw_OTfsPwgA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed, 7 Jul 2021 14:32:01 +0200
Eric Dumazet <edumazet@google.com> wrote:

> On Wed, Jul 7, 2021 at 11:27 AM Sergei Trofimovich <slyfox@gentoo.org> wrote:
> >
> > I noticed the problem as a systemd-timesyncd (and ntpsec) sync failures:
> >
> >     systemd-timesyncd[586]: Timed out waiting for reply from ...
> >     systemd-timesyncd[586]: Invalid packet timestamp.
> >
> > Bisected it down to commit 371087aa476
> > ("sock: expose so_timestamp options for mptcp").
> >
> > The commit should be a no-op but it accidentally reordered option type
> > and option value:
> >
> >     +void sock_set_timestamp(struct sock *sk, int optname, bool valbool);
> >     ...
> >     -     __sock_set_timestamps(sk, valbool, true, true);
> >     +     sock_set_timestamp(sk, valbool, optname);
> >
> > Tested the fix on systemd-timesyncd. The sync failures went away.
> >
> > CC: Paolo Abeni <pabeni@redhat.com>
> > CC: Florian Westphal <fw@strlen.de>
> > CC: Mat Martineau <mathew.j.martineau@linux.intel.com>
> > CC: David S. Miller <davem@davemloft.net>
> > CC: Jakub Kicinski <kuba@kernel.org>
> > CC: Eric Dumazet <edumazet@google.com>
> > Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
> > ---  
> 
> I think this has been fixed five days ago in
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=81b4a0cc7565b08cadd0d02bae3434f127d1d72a

Aha, looks good! Thank you!

-- 

  Sergei