Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] ieee802154: hwsim: fix GPF in hwsim_set_edge_lqi
To:     Dongliang Mu <mudongliangabcd@gmail.com>,
        Alexander Aring <alex.aring@gmail.com>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Alexander Aring <aring@mojatatu.com>,
        linux-wpan - ML <linux-wpan@vger.kernel.org>,
        "open list:NETWORKING [GENERAL]" <netdev@vger.kernel.org>,
        kernel list <linux-kernel@vger.kernel.org>
References: <20210705131321.217111-1-mudongliangabcd@gmail.com>
 <CAB_54W5ceXFPaYGs0T4pVq8AzRqUSvaBDWdBjvRurBYyihqfVg@mail.gmail.com>
 <CAD-N9QWykP2CBq1bPvz=HQRdeaR+Mg06hezrgOm4g3N1J_jT1g@mail.gmail.com>
From:   Stefan Schmidt <stefan@datenfreihafen.org>
Message-ID: <b3783b1c-0874-d16e-c51c-55cbec3b29fa@datenfreihafen.org>
Date:   Wed, 7 Jul 2021 16:41:54 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.1
MIME-Version: 1.0
In-Reply-To: <CAD-N9QWykP2CBq1bPvz=HQRdeaR+Mg06hezrgOm4g3N1J_jT1g@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hello.

On 07.07.21 16:40, Dongliang Mu wrote:
> On Wed, Jul 7, 2021 at 9:44 PM Alexander Aring <alex.aring@gmail.com> wrote:
>>
>> Hi,
>>
>> On Mon, 5 Jul 2021 at 09:13, Dongliang Mu <mudongliangabcd@gmail.com> wrote:
>>>
>>> Both MAC802154_HWSIM_ATTR_RADIO_ID and MAC802154_HWSIM_ATTR_RADIO_EDGE,
>>> MAC802154_HWSIM_EDGE_ATTR_ENDPOINT_ID and MAC802154_HWSIM_EDGE_ATTR_LQI
>>> must be present to fix GPF.
>>>
>>> Fixes: f25da51fdc38 ("ieee802154: hwsim: add replacement for fakelb")
>>> Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
>>
>> Acked-by: Alexander Aring <aahringo@redhat.com>
>>
>> Thanks, but there are more places than this one. Can you send patches
>> for them as well? Thanks! :)
> 
> Sure. I will double-check those places and send patches to fix them.

I will take this one in as-is. All new patches should be done with this 
one applied.

regards
Stefan Schmidt