Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030827AbWKOSdA (ORCPT ); Wed, 15 Nov 2006 13:33:00 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030826AbWKOSdA (ORCPT ); Wed, 15 Nov 2006 13:33:00 -0500 Received: from srv5.dvmed.net ([207.36.208.214]:51343 "EHLO mail.dvmed.net") by vger.kernel.org with ESMTP id S1030827AbWKOSc7 (ORCPT ); Wed, 15 Nov 2006 13:32:59 -0500 Message-ID: <455B5D58.6060703@garzik.org> Date: Wed, 15 Nov 2006 13:32:56 -0500 From: Jeff Garzik User-Agent: Thunderbird 1.5.0.8 (X11/20061107) MIME-Version: 1.0 To: Takashi Iwai CC: David Miller , torvalds@osdl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: hda-intel - Disable MSI support by default References: <20061114.190036.30187059.davem@davemloft.net> <20061114.192117.112621278.davem@davemloft.net> <455B5D22.10408@garzik.org> In-Reply-To: <455B5D22.10408@garzik.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.3 (----) X-Spam-Report: SpamAssassin version 3.1.7 on srv5.dvmed.net summary: Content analysis details: (-4.3 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 703 Lines: 22 Jeff Garzik wrote: > Takashi Iwai wrote: >> The snd-hda-intel driver has a test of MSI, but it seems not working >> on every machine. It caused non-cared interrupts and the kernel >> disabled that irq. > > Possibly the test was broken. Did you have IRQF_DISABLED and > IRQF_SHARED flags set? And also call pci_intx() properly in the driver, which I noticed isn't being done. (PCI MSI layer does it automatically for PCI-Express devices, only) Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/