Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030834AbWKOSgj (ORCPT ); Wed, 15 Nov 2006 13:36:39 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030836AbWKOSgj (ORCPT ); Wed, 15 Nov 2006 13:36:39 -0500 Received: from aa012msr.fastwebnet.it ([85.18.95.72]:10934 "EHLO aa012msr.fastwebnet.it") by vger.kernel.org with ESMTP id S1030834AbWKOSgh (ORCPT ); Wed, 15 Nov 2006 13:36:37 -0500 Date: Wed, 15 Nov 2006 19:36:10 +0100 From: Mattia Dongili To: "Pallipadi, Venkatesh" Cc: ego@in.ibm.com, Reuben Farrelly , Andrew Morton , davej@redhat.com, linux-kernel@vger.kernel.org, CPUFreq Mailing List , "Sadykov, Denis M" Subject: Re: 2.6.19-rc5-mm2 Message-ID: <20061115183610.GA4812@inferi.kami.home> Mail-Followup-To: "Pallipadi, Venkatesh" , ego@in.ibm.com, Reuben Farrelly , Andrew Morton , davej@redhat.com, linux-kernel@vger.kernel.org, CPUFreq Mailing List , "Sadykov, Denis M" References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Message-Flag: Cranky? Try Free Software instead! X-Operating-System: Linux 2.6.19-rc5-mm2-1 i686 X-Editor: Vim http://www.vim.org/ X-Disclaimer: Buh! User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1561 Lines: 45 On Wed, Nov 15, 2006 at 10:06:23AM -0800, Pallipadi, Venkatesh wrote: [...] > >Venki, I'm a little worried about the switch/case in question (line > >702): the data->cpu_feature is set either to SYSTEM_IO_CAPABLE or > >SYSTEM_INTEL_MSR_CAPABLE just a few lines above so it seems the switch > >variable is wrong and none of the 2 cases will ever get a chance to > >execute. > > > > The variable is set few lines before. So, it should be OK to switch on > that > variable set and one of the two cases will execute. isn't it? Or am > I missing something? Yes, patch is coming. > >Unfortunately I don't have enough knowledge to tell if it's simply > >necessary to fix the switch variable as > > Get_cur_freq_on_cpu will not work on SYSTEM_IO space as ACPI does not > have an interface to get the current frequency. It only has a interface > to say whether the last transitions tried was successful or not. > So, if indeed a change in switch is required, first option should be > good... Hmmmm... I see, the following path fooled me, but re-reading it seems more obvious what it is doing :) get_cur_freq_on_cpu extract_freq switch (data->cpu_feature) { case SYSTEM_INTEL_MSR_CAPABLE: return extract_msr(val, data); case SYSTEM_IO_CAPABLE: return extract_io(val, data); ... -- mattia :wq! - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/