Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 7 Jul 2021 17:30:18 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Vijendar Mukunda <vijendar.mukunda@amd.com>
Cc:     alsa-devel@alsa-project.org, Alexander.Deucher@amd.com,
        Sunil-kumar.Dommati@amd.com, Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 07/12] ASoC: amd: add ACP5x pcm dma driver ops
Message-ID: <20210707163018.GH4394@sirena.org.uk>
References: <20210707055623.27371-1-vijendar.mukunda@amd.com>
 <20210707055623.27371-8-vijendar.mukunda@amd.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="dCSxeJc5W8HZXZrD"
Content-Disposition: inline
In-Reply-To: <20210707055623.27371-8-vijendar.mukunda@amd.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk


--dCSxeJc5W8HZXZrD
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Jul 07, 2021 at 11:26:18AM +0530, Vijendar Mukunda wrote:

> +	/* Group Enable */
> +	acp_writel(ACP_SRAM_PTE_OFFSET | BIT(31), rtd->acp5x_base +
> +		   ACPAXI2AXI_ATU_BASE_ADDR_GRP_1);
> +	acp_writel(PAGE_SIZE_4K_ENABLE, rtd->acp5x_base +
> +		   ACPAXI2AXI_ATU_PAGE_SIZE_GRP_1);

This isn't connected to the kernel page size is it?  If so we might've
configured to 16K or 64K, or possibly even some other options - I know
those two are out there in the wild.

--dCSxeJc5W8HZXZrD
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmDl1poACgkQJNaLcl1U
h9BiQAf6AtJK2Ffb4vUcYoiF04zy8sKGtW2lCQKie6xHafUl64QvbDcxF977k09V
Bpu700qytonU3CYdFtqWcgiHpOT8XkSubup2Dswx+XkSp4oygFj+tG08oEUyw78I
tNBSG8PYuLBjAQukjrvs59MUieYz2QkGhQLWnJhImCtM8rM0JVWP+Qb1Vd9U3pYH
CDxQz8fKZKJGo88Ng9xJhxzfW+nTyxuxIfJVDgDyAj+8a9vlWz1uV/Q6VS9FdGXj
W+4uFwf96SUfICTOmQxgE5Tcm9cfLZ1ITHSdC4vzFq+6dalxF91u/Rekfh4+xb2v
NGJDu6PyrHM9EzxLM73YYa1f0VSa2w==
=iaY1
-----END PGP SIGNATURE-----

--dCSxeJc5W8HZXZrD--