Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 7 Jul 2021 17:22:06 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Vijendar Mukunda <vijendar.mukunda@amd.com>
Cc:     alsa-devel@alsa-project.org, Alexander.Deucher@amd.com,
        Sunil-kumar.Dommati@amd.com, Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 04/12] ASoC: amd: create acp5x platform devices
Message-ID: <20210707162206.GF4394@sirena.org.uk>
References: <20210707055623.27371-1-vijendar.mukunda@amd.com>
 <20210707055623.27371-5-vijendar.mukunda@amd.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="xs+9IvWevLaxKUtW"
Content-Disposition: inline
In-Reply-To: <20210707055623.27371-5-vijendar.mukunda@amd.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk


--xs+9IvWevLaxKUtW
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Jul 07, 2021 at 11:26:15AM +0530, Vijendar Mukunda wrote:

> +#define I2S_MODE 0x00
> +#define ACP5x_I2S_MODE 0x00

All the other constants are namespaced so why the plain I2S_MODE?

> +	val = acp_readl(adata->acp5x_base + ACP_PIN_CONFIG);
> +	switch (val) {
> +	case I2S_MODE:

...

> +		break;
> +	default:
> +		dev_info(&pci->dev, "ACP audio mode : %d\n", val);
> +	}

Given that anything other than I2S is basically unhandled should we
perhaps print an error rather than just an info message?

--xs+9IvWevLaxKUtW
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmDl1K4ACgkQJNaLcl1U
h9DWMwf+MVbmxxNWKlGb8aozFC2M2Dp6VTwCCLIhTlRCW6L6EFSLxLLsBUyJ0LKN
H+AujbMfenRvP8qX3Vw+CoKzoJBF3mEWty7IOgeIXn/b/52JbMb+JMoz5bO76WNh
bv78UzpEzlKoCd3tssHeEvmD0hhiytjLu3yku90M+H4EtToNr11dtj1aJJI9ZF+e
j4TtxE79SaR9/s5Z7MJ6Y+3cJTCPWckqn6QyrjA5oanKFuvqjaQDIg1Su9/7xpMo
qE3cQsMKhV84R3qMU0yZ+hLOGW8mJmtWSTSDq26UH2zha5HqnzX2Bk+mKIX86Jdu
FgbUlzggVIj2T8TMxclwAx8wpE0KSA==
=nmcF
-----END PGP SIGNATURE-----

--xs+9IvWevLaxKUtW--