Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 7 Jul 2021 17:17:30 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Vijendar Mukunda <vijendar.mukunda@amd.com>
Cc:     alsa-devel@alsa-project.org, Alexander.Deucher@amd.com,
        Sunil-kumar.Dommati@amd.com, Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 02/12] ASoC: amd: add Vangogh ACP PCI driver
Message-ID: <20210707161730.GE4394@sirena.org.uk>
References: <20210707055623.27371-1-vijendar.mukunda@amd.com>
 <20210707055623.27371-3-vijendar.mukunda@amd.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="RE3pQJLXZi4fr8Xo"
Content-Disposition: inline
In-Reply-To: <20210707055623.27371-3-vijendar.mukunda@amd.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk


--RE3pQJLXZi4fr8Xo
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Jul 07, 2021 at 11:26:13AM +0530, Vijendar Mukunda wrote:

> +static inline u32 acp_readl(void __iomem *base_addr)
> +{
> +	return readl(base_addr - ACP5x_PHY_BASE_ADDRESS);
> +}

I see this was the same for Renoir but it's weird that the read and
write functions are substracting rather than adding the base address
here.  A comment might be good.

--RE3pQJLXZi4fr8Xo
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmDl05oACgkQJNaLcl1U
h9BQ/Qf+I44B9D46yvA5DrXifzyD6B4n/K2QaDtHbog1HFtL1zbtiiATxdhLtYIS
yXeKEGxzcSmW+DgUaIMLf8kYbnoVTv1CIuAb6EpYWUVKIWlGHQ3n9QPoYuYIutvl
itaiB/rrOuisxmm1W8IQb0XL3DKywXFFRjnfqiC4d0z88U90gh58Ox3P8NgWMAsY
m84CWKyIJTagN7j0SXN8YizkoD/yBIS6eXa5l/jZ5lw9LlF2EqwBqEB7JegjnyqB
7Pf8CArQHsjn4+4IaPBVga6RmVukipqH4N+CfaXmOV8GbhvGnLEyvk7thJ4MbmvY
5BeHPpwe/hgvPfHZqDSFVOL84r7wsg==
=m2hI
-----END PGP SIGNATURE-----

--RE3pQJLXZi4fr8Xo--