Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp5733794pxv; Wed, 7 Jul 2021 10:30:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx9MRjBuCvXwlEhPSuQMBhmhBDZVvlf2mM0cFhlwNO89OHYpSMqWNMXeAzN4bqQfmayWTYa X-Received: by 2002:a05:6402:33c:: with SMTP id q28mr3972154edw.269.1625679008220; Wed, 07 Jul 2021 10:30:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625679008; cv=none; d=google.com; s=arc-20160816; b=ce1/zbCmhmyIwf4lwvE1iJLliVbZxZ+j6/Im00bpb+u4zZWchxUHv74DzrYmDH4Lq+ KexSVCVKxltvsnqYPS6P4Jj8gyprxu0Uat7kDKdJdBTiKwfJ5lbzRDs/8vDj4BL7Fn+r zGY6dneI/uekXbOvt3zXtR/LfW5vygemzzFx1s/cW/R9vrE4tKTHAeXxv7zfzEbK+HlP UW/0hHHx1SqSGZDGY8snodVMklAv10eAE2HCT9K/GtXQ1WHVQFMfhWfgdv5uoW4Z+N64 KdHslH9zZeFk5B9Q0oR0X1yPxODtMNYAaUBJdqUF4ESkR6EKN0GpBveZw/LaDy1Xxbk6 z7hA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=+fV5Xf5a7+LfJdz9Sb5JAF6o/XYmCPuAlc7D06h8Zk8=; b=Mk9Yu+qTyiMsNJA0g5nlxlQINmQXU4PNYzmokGyWH6REAs1OA4bqxx6U2rjzgcHP6j 69fN3XGcaK8zlA/TVQ3Ai3P6LbbqNDKMw/W42YwfMCJZbZKyIG6VRHKZRQUWgHSnghxh ggdnldPm+tOl3de6IUwSruqZbhecUVWUmT1GR68IZYmpfx0gdhptP903cm/dRuYu8Fga Ys5iDpjoxuUlwUQBsgBNEfiXYDEMh2lItDWDSKgghULJVQK3BKAAmm/3irlSTPuQO9YC 75zJuEtqTGoyZI3afHjZeyM9qOrvZBpkecCgXR5YNNO0Xln0PE42iJPpRChD8/AQHzeQ Av7Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e22si15109983edu.306.2021.07.07.10.29.39; Wed, 07 Jul 2021 10:30:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230249AbhGGQiL (ORCPT + 99 others); Wed, 7 Jul 2021 12:38:11 -0400 Received: from mga17.intel.com ([192.55.52.151]:55247 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230239AbhGGQiK (ORCPT ); Wed, 7 Jul 2021 12:38:10 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10037"; a="189718230" X-IronPort-AV: E=Sophos;i="5.84,220,1620716400"; d="scan'208";a="189718230" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jul 2021 09:35:30 -0700 X-IronPort-AV: E=Sophos;i="5.84,220,1620716400"; d="scan'208";a="645442761" Received: from cmcarran-mobl.amr.corp.intel.com (HELO [10.213.189.140]) ([10.213.189.140]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jul 2021 09:35:29 -0700 Subject: Re: [PATCH 05/12] ASoC: amd: add ACP5x PCM platform driver To: Vijendar Mukunda , broonie@kernel.org, alsa-devel@alsa-project.org Cc: Sunil-kumar.Dommati@amd.com, Liam Girdwood , open list , Takashi Iwai , Alexander.Deucher@amd.com References: <20210707055623.27371-1-vijendar.mukunda@amd.com> <20210707055623.27371-6-vijendar.mukunda@amd.com> From: Pierre-Louis Bossart Message-ID: <2cac4b49-62f1-83a8-84c1-08add69535d3@linux.intel.com> Date: Wed, 7 Jul 2021 11:17:22 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210707055623.27371-6-vijendar.mukunda@amd.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > +static int acp5x_audio_remove(struct platform_device *pdev) > +{ > + return 0; > +} can this be removed here and... > + > +static struct platform_driver acp5x_dma_driver = { > + .probe = acp5x_audio_probe, > + .remove = acp5x_audio_remove, ... here? > + .driver = { > + .name = "acp5x_i2s_dma", > + }, > +};