Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 7 Jul 2021 20:14:04 +0200
From:   Jiri Olsa <jolsa@redhat.com>
To:     Arnaldo Carvalho de Melo <acme@kernel.org>
Cc:     lkml <linux-kernel@vger.kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Ingo Molnar <mingo@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Michael Petlan <mpetlan@redhat.com>,
        Ian Rogers <irogers@google.com>, nakamura.shun@fujitsu.com,
        linux-perf-users@vger.kernel.org
Subject: Re: [PATCH 3/7] libperf: Move leader to perf_evsel::leader
Message-ID: <YOXu7PPoaJ0cpeQI@krava>
References: <20210706151704.73662-1-jolsa@kernel.org>
 <20210706151704.73662-4-jolsa@kernel.org>
 <YOW/5+Ep7JpL4qLL@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YOW/5+Ep7JpL4qLL@kernel.org>
Precedence: bulk

On Wed, Jul 07, 2021 at 11:53:27AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Tue, Jul 06, 2021 at 05:17:00PM +0200, Jiri Olsa escreveu:
> > Moving evsel::leader to perf_evsel::leader, so we can move
> > the group interface to libperf.
> 
> I also had to apply this, because you didn't build with
> BUILD_BPF_SKEL=1, right?

ah right.. I also plan to build in arm/s390/ppc,
so I'll take what you have in tmp.perf/core

thanks,
jirka

> 
> diff --git a/tools/perf/util/bpf_counter.c b/tools/perf/util/bpf_counter.c
> index 1d0b9742f7271966..8150e03367bbafad 100644
> --- a/tools/perf/util/bpf_counter.c
> +++ b/tools/perf/util/bpf_counter.c
> @@ -353,7 +353,7 @@ static int bperf_check_target(struct evsel *evsel,
>  			      enum bperf_filter_type *filter_type,
>  			      __u32 *filter_entry_cnt)
>  {
> -	if (evsel->leader->core.nr_members > 1) {
> +	if (evsel->core.leader->nr_members > 1) {
>  		pr_err("bpf managed perf events do not yet support groups.\n");
>  		return -1;
>  	}
>