Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp5865656pxv; Wed, 7 Jul 2021 13:37:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy4xf782PvNCbbyeIWKa13R+9CMVnlLwPRAZxqV4B4930eJjTx+6eroMpE+j/TiWZ6wOe6j X-Received: by 2002:a05:6602:17ce:: with SMTP id z14mr774593iox.73.1625690275929; Wed, 07 Jul 2021 13:37:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625690275; cv=none; d=google.com; s=arc-20160816; b=h+ps31w1fHNi3zxr21IT85vZRHLFsX212j/2HjqiNswz149VbEgf97wHTgIvJj2Yph 4HezoOjznro3p0tOhpOMN58YU0uOntCLEW+99Mhondg673AlO5DXTjII8Cut1yifrCHI PYVQB2HNLjCEQ+HGlw/bbwtHGxB1e5unuu62tSYKuShNBcGX/E7KwT6CdCNAlYJuWPgo wAkVGpZFLkuOcKsM4rWVKYr00DaKuLA4tqVB6t2xFlbmOwJu5I0cIgbahW6fGiP2Knoy ISfGo+ZHdq4LW/2EvP+hk8HE4bFv4dVLpaSVoq9sSlYYewkXiuyRHK5MmO9x2DCamuRM nPcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=nniVZP6F62ZQl5d6dhnLXievIFiGu6rur6I/C8iAG3E=; b=GqRFK0T/y4xB/pe97z7LCl2kTG4+MtEanETbTLyHNxyF7YMh1S/snMUr2j2xU4mR4T YAI1xWZ3Y2imunRwcGt0eBqbdBS6GQyUyDFy67gvzKv3WyIdOp5GGGBjQwYNU/b/kSeH W6jdZ8pd11tqLG3G5+F83THXjyDskZXvu7WgpQX+0lZaxMcYiv5RVST1nw6ME9H5LW0T xtNGHOfrJ8+njNsqTdTh7sZle8asLXgBjeOukCDGSknW3cYlADA5RiNeHjkjc9vdTe1x AkY7/m+N/xmz/ysbj9JGf1DGxjnvuQpvwQ5sOuR4ebLRptlxWL8QbJVgdxwwu7TWu83D V30Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=pqF8ksrb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w5si133309ill.8.2021.07.07.13.37.28; Wed, 07 Jul 2021 13:37:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=pqF8ksrb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232544AbhGGSkq (ORCPT + 99 others); Wed, 7 Jul 2021 14:40:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:44924 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232241AbhGGSkR (ORCPT ); Wed, 7 Jul 2021 14:40:17 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5CE4660C41; Wed, 7 Jul 2021 18:37:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625683056; bh=cToattK8KRagMqTO0iZ6wFbDJffmktvYxLuVFg8PCUQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pqF8ksrbYuXv3WYpPqW/bDg774MjR8RJjDVUiE9ln3C1zQ6ZP24OTOW2ZFV1dLdLW dwnKdRAyrYaRJHjJtbBMTE48+RMR0GUrYt2ZuxVUuQGzzuNdQ0Lgi5PU+4iWLrspyS 2CIFI+mfbpRlr9fEBGddx7Tss8mTSHUjUAhjW0WtV6jPt8CssuPuH7zwaSbnnMyHo1 w8rKyQnqcMAUOKJ0DFKRehFpUh6UUSjnKedVgT6/g5hQVk+h94OgMZN5itTylUtJUi 28ZiZCsCIWPz3fX9NeADHhii1xjaIPSVRzs5SP7GZeiWgcWx0aNPKqxK1mczA6jPC+ E3iihYXOjloCw== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 27BF740B1A; Wed, 7 Jul 2021 15:37:34 -0300 (-03) Date: Wed, 7 Jul 2021 15:37:34 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: lkml , Peter Zijlstra , Ingo Molnar , Mark Rutland , Namhyung Kim , Alexander Shishkin , Michael Petlan , Ian Rogers , nakamura.shun@fujitsu.com, linux-perf-users@vger.kernel.org Subject: Re: [RFCv2 0/7] libperf: Add leader/group info to perf_evsel Message-ID: References: <20210706151704.73662-1-jolsa@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, Jul 07, 2021 at 08:20:04PM +0200, Jiri Olsa escreveu: > On Wed, Jul 07, 2021 at 11:47:23AM -0300, Arnaldo Carvalho de Melo wrote: > > Em Tue, Jul 06, 2021 at 05:16:57PM +0200, Jiri Olsa escreveu: > > > hi, > > > moving leader/group info to libperf's perf_evsel. > > > > > > This was asked for by Shunsuke [1] and is on my list > > > as a prereq for event parsing move to libperf. > > > > So I'll add a: > > > > Requested-by: Shunsuke Nakamura > > yep, but let's hear from him first if that's the case actualy ;-) > > he did not mention any specific interface.. so I wonder > what we have is ok with him Its all in tmp.perf/core, but from what I saw, yeah, he requested being able to have a group leader. Nakamura-san, isn't that the case? - Arnaldo > thanks, > jirka > > > > > - Arnaldo > > > > > I still need to do more tests, but I'd like to check > > > with you guys if there's any feedback on this first. > > > > > > Also available in: > > > git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git > > > libperf/groups > > > > > > v2 change: > > > - repost due to smtp failures, no changes > > > > > > thanks, > > > jirka > > > > > > > > > [1] https://lore.kernel.org/linux-perf-users/OSBPR01MB46005B38568E90509946ECA9F7319@OSBPR01MB4600.jpnprd01.prod.outlook.com/ > > > > > > > > > --- > > > Jiri Olsa (7): > > > libperf: Change tests to single static and shared binaries > > > libperf: Move idx to perf_evsel::idx > > > libperf: Move leader to perf_evsel::leader > > > libperf: Move nr_groups to evlist::nr_groups > > > libperf: Add perf_evlist__set_leader function > > > libperF: Add group support to perf_evsel__open > > > libperf: Add tests for perf_evlist__set_leader function > > > > > > tools/lib/perf/Build | 2 ++ > > > tools/lib/perf/Makefile | 30 +++++++++++++++++++++++++----- > > > tools/lib/perf/evlist.c | 22 ++++++++++++++++++++++ > > > tools/lib/perf/evsel.c | 33 +++++++++++++++++++++++++++++---- > > > tools/lib/perf/include/internal/evlist.h | 2 ++ > > > tools/lib/perf/include/internal/evsel.h | 5 ++++- > > > tools/lib/perf/include/internal/tests.h | 4 ++-- > > > tools/lib/perf/include/perf/evlist.h | 1 + > > > tools/lib/perf/libperf.map | 1 + > > > tools/lib/perf/tests/Build | 5 +++++ > > > tools/lib/perf/tests/Makefile | 40 ---------------------------------------- > > > tools/lib/perf/tests/main.c | 15 +++++++++++++++ > > > tools/lib/perf/tests/test-cpumap.c | 3 ++- > > > tools/lib/perf/tests/test-evlist.c | 30 +++++++++++++++++++++++------- > > > tools/lib/perf/tests/test-evsel.c | 3 ++- > > > tools/lib/perf/tests/test-threadmap.c | 3 ++- > > > tools/lib/perf/tests/tests.h | 10 ++++++++++ > > > tools/perf/arch/x86/util/iostat.c | 4 ++-- > > > tools/perf/builtin-diff.c | 4 ++-- > > > tools/perf/builtin-record.c | 4 ++-- > > > tools/perf/builtin-report.c | 8 ++++---- > > > tools/perf/builtin-script.c | 9 +++++---- > > > tools/perf/builtin-stat.c | 12 ++++++------ > > > tools/perf/builtin-top.c | 10 +++++----- > > > tools/perf/tests/bpf.c | 2 +- > > > tools/perf/tests/evsel-roundtrip-name.c | 6 +++--- > > > tools/perf/tests/mmap-basic.c | 8 ++++---- > > > tools/perf/tests/parse-events.c | 74 +++++++++++++++++++++++++++++++++++++------------------------------------- > > > tools/perf/tests/pfm.c | 4 ++-- > > > tools/perf/ui/browsers/annotate.c | 2 +- > > > tools/perf/util/annotate.c | 8 ++++---- > > > tools/perf/util/auxtrace.c | 12 ++++++------ > > > tools/perf/util/cgroup.c | 2 +- > > > tools/perf/util/evlist.c | 44 +++++++++++++------------------------------- > > > tools/perf/util/evlist.h | 2 -- > > > tools/perf/util/evsel.c | 32 +++++++++++++++++++++++++------- > > > tools/perf/util/evsel.h | 14 ++++++++------ > > > tools/perf/util/header.c | 18 +++++++++--------- > > > tools/perf/util/metricgroup.c | 22 +++++++++++----------- > > > tools/perf/util/parse-events.c | 8 ++++---- > > > tools/perf/util/pfm.c | 2 +- > > > tools/perf/util/python.c | 2 +- > > > tools/perf/util/record.c | 6 +++--- > > > tools/perf/util/stat-shadow.c | 2 +- > > > tools/perf/util/stat.c | 2 +- > > > tools/perf/util/stream.c | 2 +- > > > 46 files changed, 310 insertions(+), 224 deletions(-) > > > create mode 100644 tools/lib/perf/tests/Build > > > delete mode 100644 tools/lib/perf/tests/Makefile > > > create mode 100644 tools/lib/perf/tests/main.c > > > create mode 100644 tools/lib/perf/tests/tests.h > > > > > > > -- > > > > - Arnaldo > > > -- - Arnaldo