Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210628030409.3459095-1-liwei391@huawei.com>
In-Reply-To: <20210628030409.3459095-1-liwei391@huawei.com>
From:   Andrii Nakryiko <andrii.nakryiko@gmail.com>
Date:   Wed, 7 Jul 2021 14:09:11 -0700
Message-ID: <CAEf4BzYYc2GyvWxKhAe9XY3zTCo2VQRHCo7jN9xU9wKOfoJDLA@mail.gmail.com>
Subject: Re: [PATCH] tools: bpf: Fix error in 'make -C tools/ bpf_install'
To:     Wei Li <liwei391@huawei.com>
Cc:     Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <kafai@fb.com>,
        Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>, bpf <bpf@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        huawei.libin@huawei.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sun, Jun 27, 2021 at 8:05 PM Wei Li <liwei391@huawei.com> wrote:
>
> make[2]: *** No rule to make target 'install'.  Stop.
> make[1]: *** [Makefile:122: runqslower_install] Error 2
> make: *** [Makefile:116: bpf_install] Error 2
>
> There is no rule for target 'install' in tools/bpf/runqslower/Makefile,
> and there is no need to install it, so just remove 'runqslower_install'.
>
> Fixes: 9c01546d26d2 ("tools/bpf: Add runqslower tool to tools/bpf")
> Signed-off-by: Wei Li <liwei391@huawei.com>
> ---

Applied to bpf tree, thanks.

Technically runqslower could be installed, but it's better to leave
that to libbpf-tools ([0]), which distributes runqslower along other
BPF-based tools.

  [0] https://github.com/iovisor/bcc/tree/master/libbpf-tools

>  tools/bpf/Makefile | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/tools/bpf/Makefile b/tools/bpf/Makefile
> index 39bb322707b4..b11cfc86a3d0 100644
> --- a/tools/bpf/Makefile
> +++ b/tools/bpf/Makefile
> @@ -97,7 +97,7 @@ clean: bpftool_clean runqslower_clean resolve_btfids_clean
>         $(Q)$(RM) -- $(OUTPUT)FEATURE-DUMP.bpf
>         $(Q)$(RM) -r -- $(OUTPUT)feature
>
> -install: $(PROGS) bpftool_install runqslower_install
> +install: $(PROGS) bpftool_install
>         $(call QUIET_INSTALL, bpf_jit_disasm)
>         $(Q)$(INSTALL) -m 0755 -d $(DESTDIR)$(prefix)/bin
>         $(Q)$(INSTALL) $(OUTPUT)bpf_jit_disasm $(DESTDIR)$(prefix)/bin/bpf_jit_disasm
> @@ -118,9 +118,6 @@ bpftool_clean:
>  runqslower:
>         $(call descend,runqslower)
>
> -runqslower_install:
> -       $(call descend,runqslower,install)
> -
>  runqslower_clean:
>         $(call descend,runqslower,clean)
>
> @@ -131,5 +128,5 @@ resolve_btfids_clean:
>         $(call descend,resolve_btfids,clean)
>
>  .PHONY: all install clean bpftool bpftool_install bpftool_clean \
> -       runqslower runqslower_install runqslower_clean \
> +       runqslower runqslower_clean \
>         resolve_btfids resolve_btfids_clean
> --
> 2.25.1
>