Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp5984049pxv; Wed, 7 Jul 2021 16:50:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwrMuGxVl6o8y4XD3QrxM7DYNNJSKL3vJLNZZCWqrW5GOwAgdtIO39vkZRUxnB95IawGkt1 X-Received: by 2002:a05:6402:7c4:: with SMTP id u4mr33904491edy.69.1625701840073; Wed, 07 Jul 2021 16:50:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625701840; cv=none; d=google.com; s=arc-20160816; b=jEVBgbkN0USY3CntWyLI70SvHRdOJlzQ0tuD2h7vhy4TMYLfVJRDMG02Sln9O6mHLe YQtGh70S2MSzGkK2zK1vdQN6nUvJybFDK583cgtZbI3AXNdLnfZtsgdC8palpQMoroFz GjvxvXe4yksAJLOUGjxHSvCvZiOEfB03R1xuJ5VKJsAEKNMGefxQjjUPgrF+ENfHLBUE sURupwxaoDQab8GR8+xoe39ITF+OivX93wJzQRXmCrZ3gUqfVBnn6LGIjAzLBEHetaXg r34yeQ0SPpVrY/N3+dIKKIlCB1JTe8MBqCJqXG8/vzPVpmVKll3bQzH7BUE2S/OokLVv CfQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:user-agent:from :references:in-reply-to:mime-version:dkim-signature; bh=TlJ0F5dHSC5zR5+dmIIRirAimmk6emojztfdcHPFyhM=; b=JnXcthPZ+jOQjCta7xc8NV8hjCBJ74vLMaPVVoiq9qZZYVeySTd+BAQC29caUNu8aj jqGL9fOa9Tlv/l3pTq1wG1EITCbzQn7viko4W3sCPG1CUJIumLpEpIqDj5esSJzerd3V EMfywxO9PA56RaQfRaS+ZPMXg30gNcT2SV58zegte7Sw8Cne9P+YIPNEuBy8/LEDIu4M skdctOaKaKkDfOpm26g4av5FKtPdOCoEf5CHQqWcxomtfq1c+NUok+nIB6bGsSCVfgNi ceUsGDgL2ML3Aw1LMqYkStht6xQdfKH+51sa5r/iBZMw4y+qSCeesBInEbacS2SvH2ll AMsg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="iMgiT/t2"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t4si693642edj.16.2021.07.07.16.50.11; Wed, 07 Jul 2021 16:50:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="iMgiT/t2"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230109AbhGGWvE (ORCPT + 99 others); Wed, 7 Jul 2021 18:51:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39278 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230033AbhGGWuy (ORCPT ); Wed, 7 Jul 2021 18:50:54 -0400 Received: from mail-ot1-x32c.google.com (mail-ot1-x32c.google.com [IPv6:2607:f8b0:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B4821C061574 for ; Wed, 7 Jul 2021 15:48:12 -0700 (PDT) Received: by mail-ot1-x32c.google.com with SMTP id h24-20020a9d64180000b029036edcf8f9a6so3917932otl.3 for ; Wed, 07 Jul 2021 15:48:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=TlJ0F5dHSC5zR5+dmIIRirAimmk6emojztfdcHPFyhM=; b=iMgiT/t2DG9+L36g6Z700bppQIeVqoM9zkbhhy9SIfRX4frPRyU+ouQTFXMl2R0sPJ LgFhnvvMRiiZj8S2wa4NJ8Vz/mvohesUF9FmRmrKoQBLP8NAEICnfegtJAZyEZci1MnR YXNnhH4XnQ6qFU9A6Nak7+ldW82JmnVqr9Ne0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=TlJ0F5dHSC5zR5+dmIIRirAimmk6emojztfdcHPFyhM=; b=rL16UCh2g3IylPr13z+nvvtUQLeiJa2c4jt7MpvQmnn/74cYmaKyg4ZM3zwH6LfSV2 xONHyJNflqIuv6lEUfiJ1nybKA8y24K2Di6W2qU8dHFnaoytzwF3WgyBtf2uiGGtZQeC RGU0IMoTWi0j/0pvU40aABbn7MsMwtfjlwNgeKqoXcjrozBpjG4EggUQg/l8j+WQ3+Mf w6OwGZ6GyaDot91Pv26vWl8Yom4xERbXu3kHKIOdoHJfmJa9VYeeRGyAC/erbjXcKMOG EKNxi55Bp46JPPHczSPHK6obmQK/PV/2HQgmHzb3dko3iniPmUSUY5LVB/X78RP71wAR 1Gfg== X-Gm-Message-State: AOAM532q/TDW0YAmbfJlT8DIuF2AOa4nsRDiA8hNjBXWqnIOfmVYgkZx xOehKKMP57m3pKhuJMuupnLCokMONT7xK79sIkLHuRTGleA= X-Received: by 2002:a9d:2781:: with SMTP id c1mr20809050otb.34.1625698092020; Wed, 07 Jul 2021 15:48:12 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 7 Jul 2021 22:48:11 +0000 MIME-Version: 1.0 In-Reply-To: <20210707074517.2775-1-thunder.leizhen@huawei.com> References: <20210707074517.2775-1-thunder.leizhen@huawei.com> From: Stephen Boyd User-Agent: alot/0.9.1 Date: Wed, 7 Jul 2021 22:48:11 +0000 Message-ID: Subject: Re: [PATCH 1/1] media: venus: hfi: fix return value check in sys_get_prop_image_version() To: Andy Gross , Bjorn Andersson , Mauro Carvalho Chehab , Stanimir Varbanov , Zhen Lei , linux-arm-msm , linux-kernel , linux-media Cc: Dikshita Agarwal Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Zhen Lei (2021-07-07 00:45:17) > In case of error, the function qcom_smem_get() returns ERR_PTR() > and never returns NULL. The NULL test in the return value check > should be replaced with IS_ERR(). > > Fixes: d566e78dd6af ("media: venus : hfi: add venus image info into smem") > Reported-by: Hulk Robot > Signed-off-by: Zhen Lei > --- Reviewed-by: Stephen Boyd