Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <3c160d187382677abe40606a6a88ddac0809c328.camel@sipsolutions.net>
Subject: Re: [PATCH v2] net: rtnetlink: Fix rtnl_dereference may be return
 NULL
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Yajun Deng <yajun.deng@linux.dev>, davem@davemloft.net,
        kuba@kernel.org, ryazanov.s.a@gmail.com, avagin@gmail.com,
        vladimir.oltean@nxp.com, cong.wang@bytedance.com,
        roopa@cumulusnetworks.com, zhudi21@huawei.com, edumazet@google.com
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Thu, 08 Jul 2021 11:43:20 +0200
In-Reply-To: <20210708092936.20044-1-yajun.deng@linux.dev>
References: <20210708092936.20044-1-yajun.deng@linux.dev>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 2021-07-08 at 17:29 +0800, Yajun Deng wrote:
> The value 'link' may be NULL in rtnl_unregister(), this leads to
> kfree_rcu(NULL, xxx), so add this case handling.
> 

I don't see how. It would require the caller to unregister something
they never registered. That would be a bug there, but I don't see that
it's very useful to actually be defensive about bugs there.

>  And modify the return
> value to 'void' in rtnl_unregister(). there is no case using it.
> 
> Fixes: addf9b90de22 (net: rtnetlink: use rcu to free rtnl message handlers)
> Fixes: 51e13685bd93 (rtnetlink: RCU-annotate both dimensions of rtnl_msg_handlers)

It certainly fixes nothing in those patches.

johannes