Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Ismail, Mohammad Athari" <mohammad.athari.ismail@intel.com>
To:     Andrew Lunn <andrew@lunn.ch>
CC:     Heiner Kallweit <hkallweit1@gmail.com>,
        "David S . Miller" <davem@davemloft.net>,
        Russell King <linux@armlinux.org.uk>,
        Jakub Kicinski <kuba@kernel.org>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH net] net: phy: reconfigure PHY WOL in resume if WOL option
 still enabled
Thread-Topic: [PATCH net] net: phy: reconfigure PHY WOL in resume if WOL
 option still enabled
Thread-Index: AQHXc5JVSuHoO6yBxk2FsVeJf8muoas4SJuAgACEr2A=
Date:   Thu, 8 Jul 2021 10:02:42 +0000
Message-ID: <CO1PR11MB4771D3BB3D8722BF3454AD4AD5199@CO1PR11MB4771.namprd11.prod.outlook.com>
References: <20210708004253.6863-1-mohammad.athari.ismail@intel.com>
 <YOZTmfvVTj9eo+to@lunn.ch>
In-Reply-To: <YOZTmfvVTj9eo+to@lunn.ch>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.5.1.3
dlp-product: dlpe-windows
dlp-reaction: no-action
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?YEW+Gvwc94VYYcqxjLpzWTWLsuO1MCq1VrYKibQ9d76yr9fgUgOILfdVo9?=
 =?iso-8859-1?Q?aEjqn/9mw8q19k28HhH8OuIkL+0c5NnuezNUJADCEIC4aJbka/ncgJS6Oo?=
 =?iso-8859-1?Q?XuQ8yAw7XiiiLaL6WyPWiSnKUZ2T626ni2F03fUHAWGyKeEALeQy6elxbO?=
 =?iso-8859-1?Q?EuS8l2HSfhbmdOnhLi3T6GgmNFW1hDeVUZeJR9FBnVt50ej0seYkOc32KF?=
 =?iso-8859-1?Q?0PIBM0BIWVhGQd5BDHvV/2OB04WpzW4Ua1aETz/f3vW6BvdF3nOYl1zRhR?=
 =?iso-8859-1?Q?wHHE4UJMECFCgXU4KWpFlagF0BmoZL71sCy/2oFvZlWCVJDa0Pzp6Leh20?=
 =?iso-8859-1?Q?tXTJvNpgBJ22ZZ7NzmwbYUUdcrVSQSiveT/EraKOmXSkm7kNWqlfBMmqm1?=
 =?iso-8859-1?Q?rbnqAcw/Kde75xEXnAJ0z1c1zUNBJgnZQ+UXM7m/kJ0MwGOCbsCSZvRFvC?=
 =?iso-8859-1?Q?UEsIcpxi2g2iJcJwkj/G77XOSnV0on0c3e/MqzZZIu1NkKeGs44AIzo4DJ?=
 =?iso-8859-1?Q?KjMyBRmZem7ACHcYudA11XRDuNKftk6/Z74zjyxATLn4Mg6Mm+azauPx/X?=
 =?iso-8859-1?Q?AcpY7GhPvTv+IY5aPEOWR+/x4VkwhNawRMkuTXRyRifv2YW7BVFkBypEro?=
 =?iso-8859-1?Q?zdZRg+7vYTOjG8ni7LvgmOWgjwvo1rXiC2VCwPVNaIlRSjHhhQ1et4Rzyf?=
 =?iso-8859-1?Q?y7uD+/Fz84bYaVjreymjRn+MPqsZjSO2DrHM+xdreoQPOY05KZjThuyFkc?=
 =?iso-8859-1?Q?FKD22UpZ+zAUpJk9mlrBWHfmP9g0GBWrSB53PJ95dgqkAG0ygli3tHZ9Th?=
 =?iso-8859-1?Q?fqlLQELXI3vjwTAv/STgZiugg5j+6r9NcenheudZ/XpujbHdk0ncclShsa?=
 =?iso-8859-1?Q?Bzimr1yVIKywTPbNIMpE4HcnDGNeyF0vt0qLo3zMrvhe2JEGrT6rgwMaFW?=
 =?iso-8859-1?Q?ywVw4GxEz9SKl9QNBl0avm9YGdYsLSycjvQkNj3lHgZ00AOXARxqYkNood?=
 =?iso-8859-1?Q?yDVkBiW6pSeojSIkmQkjp70geFXsMJWcAHqRd+pY/MOFsswIrm4KHEvSVW?=
 =?iso-8859-1?Q?awoGf7cW2U8kDtUsJ/eATy2DRztIL6cgszh6i8r2DKUGhqb5dzZLT/TOTz?=
 =?iso-8859-1?Q?AHoOW8Y4oYxcVV7c59LtuuisghaZdSOnL14gkoIkpVOOzyfkAXVLEo+paf?=
 =?iso-8859-1?Q?YjElvrA7yyp4lVJjlHavfGNz7iWbi00kxxmjO1pfaKEvkAlDw1W49ZoS4F?=
 =?iso-8859-1?Q?nEkukb1nQKK9xNxTIzP+2a8jusKvmf1cQdpYutjQlYrhCJt7yDDzDwIk/Q?=
 =?iso-8859-1?Q?9c/qOCSzYj6LUbjKTasiVjwBXNkMLbazovH59RlFDbpuYQ6mmNj9esE5yk?=
 =?iso-8859-1?Q?fX/Rai07Jd?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4771.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6f06638a-8259-4f17-288a-08d941f786ee
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jul 2021 10:02:42.4575
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: SHSDJeua4X+YbYumGbgwhoa2grpeBPLrWV9bdQPemQGsByUNpbJ4DGQlObEBHwW/m0Tetmwn1SBFA8BaKkbon/eAJuN/vFFfjwKTDJ4fJthDBfl6WZiT9eonvOt+h9Cn
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1856
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Andrew Lunn <andrew@lunn.ch>
> Sent: Thursday, July 8, 2021 9:24 AM
> To: Ismail, Mohammad Athari <mohammad.athari.ismail@intel.com>
> Cc: Heiner Kallweit <hkallweit1@gmail.com>; David S . Miller
> <davem@davemloft.net>; Russell King <linux@armlinux.org.uk>; Jakub Kicins=
ki
> <kuba@kernel.org>; Florian Fainelli <f.fainelli@gmail.com>;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH net] net: phy: reconfigure PHY WOL in resume if WOL
> option still enabled
>=20
> On Thu, Jul 08, 2021 at 08:42:53AM +0800, mohammad.athari.ismail@intel.co=
m
> wrote:
> > From: Mohammad Athari Bin Ismail <mohammad.athari.ismail@intel.com>
> >
> > When the PHY wakes up from suspend through WOL event, there is a need
> > to reconfigure the WOL if the WOL option still enabled. The main
> > operation is to clear the WOL event status. So that, subsequent WOL
> > event can be triggered properly.
> >
> > This fix is needed especially for the PHY that operates in PHY_POLL
> > mode where there is no handler (such as interrupt handler) available
> > to clear the WOL event status.
>=20
> I still think this architecture is wrong.
>=20
> The interrupt pin is wired to the PMIC. Can the PMIC be modelled as an in=
terrupt
> controller? That would allow the interrupt to be handled as normal, and w=
ould
> mean you don't need polling, and you don't need this hack.

Hi Andrew,

In our platform, the PHY interrupt pin is not connected to Host CPU. So, th=
e CPU couldn`t service the PHY interrupt.=A0 The PHY interrupt pin is conne=
cted to a power management controller (PMC) as a HW wake up signal. The PMC=
 itself couldn't act as interrupt controller to service the PHY interrupt.

During WOL event, the WOL signal is sent to PMC through the PHY interrupt p=
in to wake up the PMC. Then, the PMC will wake up the Host CPU and the whol=
e system.

Therefore, for our platform, PHY_POLL mode is chosen in PHY driver.

-Athari-

>=20
> 	Andrew