Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210706114028.132-1-alistair@alistair23.me> <CAOMZO5CEeBWEaRWXpfgjR+q0QnpPmoyGN+ShjCHNzoSqk_iW0Q@mail.gmail.com>
 <CAKmqyKPLWft8kUR9A2V1fjpaD8dmpbT9=Lc-NY76wkgenLE93Q@mail.gmail.com>
In-Reply-To: <CAKmqyKPLWft8kUR9A2V1fjpaD8dmpbT9=Lc-NY76wkgenLE93Q@mail.gmail.com>
From:   Fabio Estevam <festevam@gmail.com>
Date:   Thu, 8 Jul 2021 09:05:43 -0300
Message-ID: <CAOMZO5C=CcJDg9BQMVd8UU7fryW9TqMvvnJCuC3cq-7rzTi=eQ@mail.gmail.com>
Subject: Re: [PATCH v3] ARM: dts: imx7d-remarkable2: Add WiFi support
To:     Alistair Francis <alistair23@gmail.com>
Cc:     Alistair Francis <alistair@alistair23.me>,
        Rob Herring <robh+dt@kernel.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Sascha Hauer <kernel@pengutronix.de>,
        NXP Linux Team <linux-imx@nxp.com>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@lists.infradead.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Alistair,

On Thu, Jul 8, 2021 at 6:16 AM Alistair Francis <alistair23@gmail.com> wrote:

> I'm not sure I follow, we do the same thing here with:
>
> &clks {
>     assigned-clocks = <&clks IMX7D_CLKO2_ROOT_SRC>,
>               <&clks IMX7D_CLKO2_ROOT_DIV>;
>     assigned-clock-parents = <&clks IMX7D_CKIL>;
>     assigned-clock-rates = <0>, <32768>;
> };

Ah, got it. This was not in the patch context, so that's why I got confused.

Now I see it as part of the original file, so it looks good to me, thanks:

Reviewed-by: Fabio Estevam <festevam@gmail.com>