Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 8 Jul 2021 16:00:04 +0300
From:   Sakari Ailus <sakari.ailus@iki.fi>
To:     Martin Kepplinger <martin.kepplinger@puri.sm>
Cc:     krzysztof.kozlowski@canonical.com,
        laurent.pinchart@ideasonboard.com, devicetree@vger.kernel.org,
        kernel@puri.sm, linux-kernel@vger.kernel.org,
        linux-media@vger.kernel.org, mchehab@kernel.org,
        paul.kocialkowski@bootlin.com, pavel@ucw.cz,
        phone-devel@vger.kernel.org, robh@kernel.org, shawnx.tu@intel.com
Subject: Re: [PATCH v6 5/5] arm64: defconfig: enable VIDEO_HI846
Message-ID: <20210708130003.GA3@valkosipuli.retiisi.eu>
References: <20210628101054.828579-1-martin.kepplinger@puri.sm>
 <20210628101054.828579-6-martin.kepplinger@puri.sm>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210628101054.828579-6-martin.kepplinger@puri.sm>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

Hi Martin,

On Mon, Jun 28, 2021 at 12:10:54PM +0200, Martin Kepplinger wrote:
> Build the driver for the Hi-846 camera by default on arm64 where it's
> going to be used on at least the imx8mq-librem5 board.
> 
> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
> ---
>  arch/arm64/configs/defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index f423d08b9a71..bf27d9cfbdd5 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -666,6 +666,7 @@ CONFIG_VIDEO_RENESAS_VSP1=m
>  CONFIG_VIDEO_QCOM_VENUS=m
>  CONFIG_SDR_PLATFORM_DRIVERS=y
>  CONFIG_VIDEO_RCAR_DRIF=m
> +CONFIG_VIDEO_HI846=m
>  CONFIG_VIDEO_IMX219=m
>  CONFIG_VIDEO_OV5645=m
>  CONFIG_VIDEO_QCOM_CAMSS=m

The same sensor may be or may not used on a given board (and certainly it's
not specific to arm64). Is it desirable all arm64 systems compile this in
by default?

There appear to be a other sensor drivers though.

Is there a defconfig for the librem5 board?

I wonder what others think.

-- 
Kind regards,

Sakari Ailus