Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates
 216.228.112.34 as permitted sender) receiver=protection.outlook.com;
 client-ip=216.228.112.34; helo=mail.nvidia.com;
Subject: Re: [PATCH v5] gpio: tegra186: Add ACPI support
To:     Akhil R <akhilrajeev@nvidia.com>
CC:     <andy.shevchenko@gmail.com>, <bgolaszewski@baylibre.com>,
        <kyarlagadda@nvidia.com>, <ldewangan@nvidia.com>,
        <linus.walleij@linaro.org>, <linux-gpio@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
        <mperttunen@nvidia.com>, <smangipudi@nvidia.com>,
        <thierry.reding@gmail.com>
References: <2a8eb285-3b71-199c-1bf4-39fb47fac77e@nvidia.com>
 <1625130054-22947-1-git-send-email-akhilrajeev@nvidia.com>
From:   Jon Hunter <jonathanh@nvidia.com>
Message-ID: <5010ac2c-bfd0-1a79-d470-a1c601207f28@nvidia.com>
Date:   Thu, 8 Jul 2021 14:08:17 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <1625130054-22947-1-git-send-email-akhilrajeev@nvidia.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jul 2021 13:08:22.9879
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 5c2cba67-b6df-4f3a-5a8c-08d94211773e
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.112.34];Helo=[mail.nvidia.com]
X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT047.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR12MB3027
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 01/07/2021 10:00, Akhil R wrote:
> Add ACPI module ID to probe the driver from the ACPI based bootloader
> firmware.
> 
> Signed-off-by: Akhil R <akhilrajeev@nvidia.com>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> ---
> v5 changes:
> 	* Updated ioremap_resource check as per Jon's comments.
> 
>  drivers/gpio/gpio-tegra186.c | 30 ++++++++++++++++++++++++------
>  1 file changed, 24 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-tegra186.c b/drivers/gpio/gpio-tegra186.c
> index 1bd9e44..8a64dcb 100644
> --- a/drivers/gpio/gpio-tegra186.c
> +++ b/drivers/gpio/gpio-tegra186.c
> @@ -620,15 +620,21 @@ static int tegra186_gpio_probe(struct platform_device *pdev)
>  	if (!gpio)
>  		return -ENOMEM;
>  
> -	gpio->soc = of_device_get_match_data(&pdev->dev);
> +	gpio->soc = device_get_match_data(&pdev->dev);
>  
>  	gpio->secure = devm_platform_ioremap_resource_byname(pdev, "security");
> -	if (IS_ERR(gpio->secure))
> -		return PTR_ERR(gpio->secure);
> +	if (IS_ERR(gpio->secure)) {
> +		gpio->secure = devm_platform_ioremap_resource(pdev, 0);
> +		if (IS_ERR(gpio->secure))
> +			return PTR_ERR(gpio->secure);
> +	}
>  
>  	gpio->base = devm_platform_ioremap_resource_byname(pdev, "gpio");
> -	if (IS_ERR(gpio->base))
> -		return PTR_ERR(gpio->base);
> +	if (IS_ERR(gpio->base)) {
> +		gpio->base = devm_platform_ioremap_resource(pdev, 1);
> +		if (IS_ERR(gpio->base))
> +			return PTR_ERR(gpio->base);
> +	}
>  
>  	err = platform_irq_count(pdev);
>  	if (err < 0)
> @@ -690,11 +696,13 @@ static int tegra186_gpio_probe(struct platform_device *pdev)
>  
>  	gpio->gpio.names = (const char * const *)names;
>  
> +#if defined(CONFIG_OF_GPIO)
>  	gpio->gpio.of_node = pdev->dev.of_node;
>  	gpio->gpio.of_gpio_n_cells = 2;
>  	gpio->gpio.of_xlate = tegra186_gpio_of_xlate;
> +#endif /* CONFIG_OF_GPIO */
>  
> -	gpio->intc.name = pdev->dev.of_node->name;
> +	gpio->intc.name = dev_name(&pdev->dev);
>  	gpio->intc.irq_ack = tegra186_irq_ack;
>  	gpio->intc.irq_mask = tegra186_irq_mask;
>  	gpio->intc.irq_unmask = tegra186_irq_unmask;
> @@ -918,10 +926,20 @@ static const struct of_device_id tegra186_gpio_of_match[] = {
>  };
>  MODULE_DEVICE_TABLE(of, tegra186_gpio_of_match);
>  
> +static const struct acpi_device_id  tegra186_gpio_acpi_match[] = {
> +	{ .id = "NVDA0108", .driver_data = (kernel_ulong_t)&tegra186_main_soc },
> +	{ .id = "NVDA0208", .driver_data = (kernel_ulong_t)&tegra186_aon_soc },
> +	{ .id = "NVDA0308", .driver_data = (kernel_ulong_t)&tegra194_main_soc },
> +	{ .id = "NVDA0408", .driver_data = (kernel_ulong_t)&tegra194_aon_soc },
> +	{}
> +};
> +MODULE_DEVICE_TABLE(acpi, tegra186_gpio_acpi_match);
> +
>  static struct platform_driver tegra186_gpio_driver = {
>  	.driver = {
>  		.name = "tegra186-gpio",
>  		.of_match_table = tegra186_gpio_of_match,
> +		.acpi_match_table = tegra186_gpio_acpi_match,
>  	},
>  	.probe = tegra186_gpio_probe,
>  	.remove = tegra186_gpio_remove,
> 

Looks good to me.

Reviewed-by: Jon Hunter <jonathanh@nvidia.com>

Cheers
Jon

-- 
nvpublic