Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp494738pxv; Thu, 8 Jul 2021 07:15:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxtzffGnG04Zzw0xptR2Mq3CPiXjVXuTBxFSjO0K7VfSgdsKD844wlAoiV3d171jGoSOizp X-Received: by 2002:a05:6402:14c7:: with SMTP id f7mr7611723edx.84.1625753720821; Thu, 08 Jul 2021 07:15:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625753720; cv=none; d=google.com; s=arc-20160816; b=fKFvF8tFlq0+lDUhaYCRzSuOFNZPxqdPQdUQ7bqXY4SCM2zByi6Cbdu2UIrkgyv4hd 9ymYVWqu58i2OeAjgPwnc/LSt+xNXXo3PP9ca6KCLm4c9NIdPT4L282H+ZycLFLNhFnU lcGBBfS3VPRAPitt83Q+k+Tsb4EjrkGz5dHwRtrPjVbU2uMoDDGCk96Wau8JjnfRANqE Iu81mjZ2WPgAPFMzoHUkNZm8vqJ9MOuwh/tnZQOY0o/KGY9AQFz7luJ1pCYG5jDWABGl x/3xqwZU6lYeZ2zPHog07iXmv8QGwz6qnDmwZjQR99yvbmkHL6XbBnVRY8ShnJcjZCCG Y0yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=1KfomhuDu3CpCxt02QtH0UfkbSugvdEeaTVo//4mN/k=; b=gp6Fxu/iJ1k/HVpA74xgdhaIbwa+d6fc4hCu1SB66fuZgCWdKiC3sPHNj74OvNlx1C 7g19xakKsI2D2XKBCoyWtaLo70n3Qift4iYe0TjTcHb/qE43mhTOU8GGfumPYNPDaE/A K6j8cxYtXUwbxtUpCpgSUPA5FCB+hwtq2G3hp493M3CIEH9cfAttZ8wkHLEUsvbYIfBp gspoGatuUGsWHU9xvf2oOD4WIs8RnYUddm9rPizJ7fuEOO6qLDFNvTqHBy0Ru2rb+1F7 U2AgOHomf/HnFdc9XjixJMbtrd3+evD2E3KE/kq7gCHpENtMYZrszyD/f+cbuNnFny5k gA/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=bYnggQxW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w20si3223713edc.462.2021.07.08.07.14.57; Thu, 08 Jul 2021 07:15:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=bYnggQxW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231836AbhGHOOi (ORCPT + 99 others); Thu, 8 Jul 2021 10:14:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:37290 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229592AbhGHOOi (ORCPT ); Thu, 8 Jul 2021 10:14:38 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9B248616E8; Thu, 8 Jul 2021 14:11:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1625753516; bh=1KfomhuDu3CpCxt02QtH0UfkbSugvdEeaTVo//4mN/k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bYnggQxWY7I+EIuC6fk/4x81z3jDILAu5k/te8z2rsrrLBFYAGTP40WTi7t7BbWg2 FzUj7AL0LzIjRd+lro4VjE8K3hvUMnfllVGwIVsWPbYSvyldoAEhilBYiR0y9rZ9di KkFREOBfxsPKwqfoECemNDcjC42ANxqnJXWvlnOxvEZSeIthVPU9RX9ecpxmyNzpLF c8jjohxmVrdmjya8Lfah/m5DlGbj7D9g3mTe4ArWFes1WMdZuDYy+wZtIDoXoUOTVH Cm19kxpxXYAjk952W6LOaEb6VyV4FK5p649DA0MGMCedXJfmpdaA+zMAlMTO02konZ kw8ArFCxLQlUg== Date: Thu, 8 Jul 2021 16:11:51 +0200 From: Jessica Yu To: Reiner Huober Cc: Kees Cook , Sami Tolvanen , Miroslav Benes , Emil Velikov , Sean Christopherson , Masahiro Yamada , linux-kernel@vger.kernel.org Subject: Re: [PATCH] module: combine constructors in module linker script Message-ID: References: <1625576575-1008-1-git-send-email-reiner.huober@nokia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <1625576575-1008-1-git-send-email-reiner.huober@nokia.com> X-OS: Linux p200300cbcf044300404ca642de146c7c.dip0.t-ipconnect.de 5.12.10-1-default x86_64 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org +++ Reiner Huober [06/07/21 15:02 +0200]: >The constructor code for modules must be aware of init code inside >different sections. > >Newer GCC compilers write constructors in more than one section, >e.g. ".ctors.65435". These must be combined into a single >".ctors" section. In the module loader, only the ".ctors" section >is searched and the constructors therein are initialized, when >CONFIG_CONSTRUCTORS=y is set. Other constructors are ignored. > >This change combines all ".ctors.*" and the ".ctors" section, if any, >in .ko into a single ."ctors" section. > >For code coverage in GCC, this is necessary to show the >code coverage for modules, since code coverage uses such >constructors when initializing a module in newer version of GCC. > >Signed-off-by: Reiner Huober Thanks, I'll queue this up after the merge window is over. Jessica