Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <39a7b7c455c6c23f0bfe7403b4957d2c92196d46.camel@perches.com>
Subject: Re: [PATCH] drivers: parisc: Follow the indentation coding standard
 on printks
From:   Joe Perches <joe@perches.com>
To:     Carlos Bilbao <bilbao@vt.edu>,
        James.Bottomley@hansenpartnership.com
Cc:     deller@gmx.de, linux-parisc@vger.kernel.org,
        linux-kernel@vger.kernel.org, andrew@lunn.ch
Date:   Thu, 08 Jul 2021 09:46:54 -0700
In-Reply-To: <1793924.CQOukoFCf9@iron-maiden>
References: <1793924.CQOukoFCf9@iron-maiden>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.40.0-1 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Thu, 2021-07-08 at 11:25 -0400, Carlos Bilbao wrote:
> Fix indentation of printks that start at the beginning of the line. Change this 
> for the right number of space characters, or tabs if the file uses them. 

These are ancient codes, but:

> diff --git a/drivers/parisc/iosapic.c b/drivers/parisc/iosapic.c
[]
> @@ -633,7 +633,7 @@ static void iosapic_unmask_irq(struct irq_data *d)
> ?	printk("\n");
> ?}
> ?
> 
> -printk("iosapic_enable_irq(): sel ");
> +	printk("iosapic_enable_irq(): sel ");
> ?{
> ?	struct iosapic_info *isp = vi->iosapic;
> ?
> 
> @@ -642,7 +642,7 @@ printk("iosapic_enable_irq(): sel ");
> ?		printk(" %x", d1);
> ?	}
> ?}
> -printk("\n");
> +	printk("\n");
> ?#endif

This is in an undefined #ifdef block and the block could be deleted.

> diff --git a/drivers/parisc/sba_iommu.c b/drivers/parisc/sba_iommu.c
[]
> @@ -1550,7 +1550,7 @@ static void sba_hw_init(struct sba_device *sba_dev)
> ?
> 
> ?
> 
> ?#if 0

#if 0 blocks can be removed.

> -printk("sba_hw_init(): mem_boot 0x%x 0x%x 0x%x 0x%x\n", PAGE0->mem_boot.hpa,
> +	printk("sba_hw_init(): mem_boot 0x%x 0x%x 0x%x 0x%x\n", PAGE0->mem_boot.hpa,
> ?	PAGE0->mem_boot.spa, PAGE0->mem_boot.pad, PAGE0->mem_boot.cl_class);
> ?
> 
> ?	/*