Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v3] ASoC: atmel: ATMEL drivers don't need HAS_DMA
To:     Codrin.Ciubotariu@microchip.com, linux-kernel@vger.kernel.org
Cc:     alsa-devel@alsa-project.org, lgirdwood@gmail.com,
        broonie@kernel.org, mirq-linux@rere.qmqm.pl,
        alexandre.belloni@free-electrons.com
References: <20210707214752.3831-1-rdunlap@infradead.org>
 <fca8f952-2be0-5c57-d60d-5c4f025abc4d@microchip.com>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <49495ab9-5039-f332-2895-1a79c034f58d@infradead.org>
Date:   Thu, 8 Jul 2021 09:50:50 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <fca8f952-2be0-5c57-d60d-5c4f025abc4d@microchip.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 7/8/21 1:19 AM, Codrin.Ciubotariu@microchip.com wrote:
> On 08.07.2021 00:47, Randy Dunlap wrote:
>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>
>> On a config (such as arch/sh/) which does not set HAS_DMA when MMU
>> is not set, several ATMEL ASoC drivers select symbols that cause
>> kconfig warnings. There is one "depends on HAS_DMA" which is no longer
>> needed. Dropping it eliminates the kconfig warnings and still builds
>> with no problems reported.
>>
>> Fix the following kconfig warnings:
>>
>> WARNING: unmet direct dependencies detected for SND_ATMEL_SOC_PDC
>>    Depends on [n]: SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_ATMEL_SOC [=m] && HAS_DMA [=n]
>>    Selected by [m]:
>>    - SND_ATMEL_SOC_SSC [=m] && SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_ATMEL_SOC [=m]
>>    - SND_ATMEL_SOC_SSC_PDC [=m] && SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_ATMEL_SOC [=m] && ATMEL_SSC [=m]
>>
>> WARNING: unmet direct dependencies detected for SND_ATMEL_SOC_SSC_PDC
>>    Depends on [n]: SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_ATMEL_SOC [=m] && ATMEL_SSC [=m] && HAS_DMA [=n]
>>    Selected by [m]:
>>    - SND_AT91_SOC_SAM9G20_WM8731 [=m] && SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_ATMEL_SOC [=m] && (ARCH_AT91 || COMPILE_TEST [=y]) && ATMEL_SSC [=m] && SND_SOC_I2C_AND_SPI [=m]
>>
>> WARNING: unmet direct dependencies detected for SND_ATMEL_SOC_SSC
>>    Depends on [n]: SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_ATMEL_SOC [=m] && HAS_DMA [=n]
>>    Selected by [m]:
>>    - SND_ATMEL_SOC_SSC_DMA [=m] && SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_ATMEL_SOC [=m] && ATMEL_SSC [=m]
>>
>> WARNING: unmet direct dependencies detected for SND_ATMEL_SOC_SSC_DMA
>>    Depends on [n]: SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_ATMEL_SOC [=m] && ATMEL_SSC [=m] && HAS_DMA [=n]
>>    Selected by [m]:
>>    - SND_ATMEL_SOC_WM8904 [=m] && SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_ATMEL_SOC [=m] && (ARCH_AT91 || COMPILE_TEST [=y]) && ATMEL_SSC [=m] && I2C [=m]
>>    - SND_AT91_SOC_SAM9X5_WM8731 [=m] && SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_ATMEL_SOC [=m] && (ARCH_AT91 || COMPILE_TEST [=y]) && ATMEL_SSC [=m] && SND_SOC_I2C_AND_SPI [=m]
>>
>> Fixes: 3951e4aae2ce ("ASoC: atmel-pcm: dma support based on pcm dmaengine")
>> Fixes: 18291410557f ("ASoC: atmel: enable SOC_SSC_PDC and SOC_SSC_DMA in Kconfig")
>> Fixes: 061981ff8cc8 ("ASoC: atmel: properly select dma driver state")
> 
> I am not sure about these fixes tags. As Alexandre mentioned, it looks 
> like the reason for HAS_DMA in the first place was the COMPILE_TEST with 
> m32r arch. I dig a bit, and, if any, I think we should use:
> Fixes: eb17726b00b3 ("m32r: add simple dma")
> since this commit adds dummy DMA support for m32r and seems to fix the 
> HAS_DMA dependency.

Ah, I forgot to update the Fixes: tag(s).

I won't disagree with your Fixes: suggestion (good digging) but
I would probably have used 8d7d11005e930:
  ASoC: atmel: fix build failure
which is the commit that added "depends on HAS_DMA".

>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
>> Cc: alsa-devel@alsa-project.org
>> Cc: Liam Girdwood <lgirdwood@gmail.com>
>> Cc: Mark Brown <broonie@kernel.org>
>> Cc: Michał Mirosław <mirq-linux@rere.qmqm.pl>
> 
> Other than that:
> Reviewed-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>

Thanks.  I'll send a v4 with your Fixes: suggestion.