Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp619095pxv; Thu, 8 Jul 2021 10:02:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyRHt+MEKCYWIfWjeC4q6zgn3T9JKwUaUNj8FYAo/QyXZ5Acp8oatOhrtXWwImuAHIJUn0n X-Received: by 2002:a17:906:3ed4:: with SMTP id d20mr32779139ejj.515.1625763751486; Thu, 08 Jul 2021 10:02:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625763751; cv=none; d=google.com; s=arc-20160816; b=CI+Jls+xC0cuF0WcvXiSlOD/1MidDOYoPJgx1iOJTjdQ65MceS0IYv9VOa+LBK1X7j 73IyMfhlnfBO1wvMcdwA1lxJjNtKuo0e7adWIG0lbyffk2d/FP5TDcrsgIGyeGcui7AB FJecYAfPB4/H+hqAApkvr2nGQp0lRCJO0QlXj40F0ngdjroqsN5c3im8k7S6SJKXD2yx GvvdrB5Ml/MGCvLhaiwtLOM3SrrnVM3pFtoA61ZcUKFpCpaB7Cf2+epPmnRpcG6xbc4J ofi/u94KMSI9ookzrH9EYGqM9Qnt+elwrIG0S7menp9eLEozC+cnp1I3lGkqRJi5xRxK Rwsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=1+MxxEIgHppIPoGs9NgPZPuRjgmYFQ760KzTDD/t7B8=; b=nObRdB8Dt2f4S7Eb5yjOw9Zfk7jCNSORemiKg6NFM1ByNWfFo2WMhCTttRkz2YqxVK Ts6lwilm9m/oe2IqOuV10pEF69uvoQQ3l7XADGhADaplF6tbbRvCQt6jQixHXFpzco4K wuvJ6Nbt+fftF0/yfb5pC9RXTnbDkxl926TNFnzW4+J0l20/xFz61s3axAgHui809XI8 tk3iYL7RB3xGC9ODC3TlcJPjQbRvAtJ4GZot0LPbwCWlK8q7bf+JiOKU3azkhZST8xyn RdVZ3luQqJi2rVZDIpL3za5CcgRStCet4EncxppP4QsnAf6Nso3AWUy7eIPZYCZDyuAI GhkQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=H9c330k3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u15si3807928ejb.376.2021.07.08.10.02.07; Thu, 08 Jul 2021 10:02:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=H9c330k3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230099AbhGHRBn (ORCPT + 99 others); Thu, 8 Jul 2021 13:01:43 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:34079 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230103AbhGHRBm (ORCPT ); Thu, 8 Jul 2021 13:01:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625763539; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1+MxxEIgHppIPoGs9NgPZPuRjgmYFQ760KzTDD/t7B8=; b=H9c330k3s25Z7kvkq/Fy7Ts6v66/MPCme0rzdGFTJuaaCiXPoT5zp7PbEv85rQQuHJNfVB ME6HGZDnwWBnfg+NvULf/aWxw8tBus41rv40cQQj1Lu6zyBaw+kxNInIhs50ex4kxSBCye H4u9gwBmh93MFGxPtWcBNT+0yDewOdQ= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-540-D6PqexPUMXCerUu7D8hshw-1; Thu, 08 Jul 2021 12:58:56 -0400 X-MC-Unique: D6PqexPUMXCerUu7D8hshw-1 Received: by mail-ej1-f71.google.com with SMTP id jx16-20020a1709077610b02904e0a2912b46so2116956ejc.7 for ; Thu, 08 Jul 2021 09:58:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=1+MxxEIgHppIPoGs9NgPZPuRjgmYFQ760KzTDD/t7B8=; b=KGRqRPcOJUTbfq0vSwzFzr3nFtLXNfaZABue8Ijc7MLUXqIJlnGSWGhWfoUU8150rx SiCtmFbVMlQqyf69CiPGGFEb2ML+uybkCooN/xtUejTJU59FJkqWZinOf9sT6coHT9iI gqSmn8pk4Vb2C8l0+1Fx1oM46z2DL7FLbFWkKwIqp8qKB8A2eKkplVrHo+Wp9DIpzpbY fnJKH7zDjgHf93xTnhhoLd3iSliA2cPcn4AQUpU4x907WX3OcDzyM1ZfwS1w8ZTv2G+s aQ4dXWMVxTh4nVDt8DTpm/RL6SCBvoNMcHPXSTmsi/5KcIrBT0lWv19AaH4oGZXviT67 eXZw== X-Gm-Message-State: AOAM5305ebKqrdJc0smZhOREh8qgPBKpIkqMS0PURx03bmxYJ7O2Jq9w rrOU0OK6gKNvomtIOzO4b9TU+WrYuL1hWGuLnF1zVxhO/f636n2/0GJSFKy0IqlDECgNz0bkNm+ xSQvSFsSBKAQGeAcrCPT1q8isgMF7h2TPIx7rbj8bUtRGKRYzjsjVL5Gfugg2DqSeTSDsmG5zAZ jp X-Received: by 2002:a05:6402:1057:: with SMTP id e23mr40673382edu.352.1625763535404; Thu, 08 Jul 2021 09:58:55 -0700 (PDT) X-Received: by 2002:a05:6402:1057:: with SMTP id e23mr40673368edu.352.1625763535253; Thu, 08 Jul 2021 09:58:55 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id u26sm1170302ejx.8.2021.07.08.09.58.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Jul 2021 09:58:54 -0700 (PDT) Subject: Re: [PATCH next] kvm: debugfs: fix memory leak in kvm_create_vm_debugfs To: Jing Zhang , Pavel Skripkin Cc: KVM , linux-kernel@vger.kernel.org References: <20210701195500.27097-1-paskripkin@gmail.com> From: Paolo Bonzini Message-ID: <0b028e3d-d363-05cd-3dc3-8ccc5704ae1c@redhat.com> Date: Thu, 8 Jul 2021 18:58:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/07/21 23:24, Jing Zhang wrote: > In commit bc9e9e672df9 ("KVM: debugfs: Reuse binary stats descriptors") > loop for filling debugfs_stat_data was copy-pasted 2 times, but > in the second loop pointers are saved over pointers allocated > in the first loop. It causes memory leak. Fix it. > > Fixes: bc9e9e672df9 ("KVM: debugfs: Reuse binary stats descriptors") > Signed-off-by: Pavel Skripkin > --- Queued, thanks. Paolo