Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <ccf9f07a72c911652d24ceb6c6e925f834f1d338.camel@perches.com>
Subject: Re: [PATCH net-next v2] drivers: net: Follow the indentation coding
 standard on printks
From:   Joe Perches <joe@perches.com>
To:     Carlos Bilbao <bilbao@vt.edu>, davem@davemloft.net
Cc:     kuba@kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, andrew@lunn.ch,
        gregkh@linuxfoundation.org
Date:   Thu, 08 Jul 2021 10:38:26 -0700
In-Reply-To: <5183009.Sb9uPGUboI@iron-maiden>
References: <1884900.usQuhbGJ8B@iron-maiden>
         <03ad1f2319a608bbfe3fc09e901742455bf733a0.camel@perches.com>
         <5183009.Sb9uPGUboI@iron-maiden>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.40.0-1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 2021-07-08 at 13:33 -0400, Carlos Bilbao wrote:
> Fix indentation of printks that start at the beginning of the line. Change this 
> for the right number of space characters, or tabs if the file uses them. 

You are touching 2 different drivers and this should really be
2 separate patches.

> diff --git a/drivers/net/ethernet/dec/tulip/de4x5.c.rej b/drivers/net/ethernet/dec/tulip/de4x5.c.rej
[]
> +++ b/drivers/net/ethernet/dec/tulip/de4x5.c.rej
> @@ -0,0 +1,11 @@
> +--- drivers/net/ethernet/dec/tulip/de4x5.c
> ++++ drivers/net/ethernet/dec/tulip/de4x5.c
> +@@ -3169,7 +3169,7 @@ dc2114x_autoconf(struct net_device *dev)
> + 
> +     default:
> +        lp->tcount++;
> +-printk("Huh?: media:%02x\n", lp->media);
> ++       printk("Huh?: media:%02x\n", lp->media);
> +        lp->media = INIT;
> +        break;
> +     }

This is an interdiff that should not be part of this change.