Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp693761pxv; Thu, 8 Jul 2021 11:46:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxkV5Y0Ria5rJcWY31L130VLdlWv4klz75m1IXxTMZDCqDi/0kjFqUy8r+9WP6aYNcQyr+E X-Received: by 2002:a92:de45:: with SMTP id e5mr23632612ilr.157.1625770019273; Thu, 08 Jul 2021 11:46:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625770019; cv=none; d=google.com; s=arc-20160816; b=hjH3+g5fomuoAkKO+Q4oKwE8nGbiA+UCIMMxiIMhow0gbSaeu/FFWMMFTJnmLxZq9I OnwvmBUXvXaalkM/CcLVYGtdwFaPqqXndzFtrXB5UKb4cPTbhgCC/QGJydX7sB7Uw2o/ BctGfujQQet/0Yhh+XvC+E8Pgpp7IsMwfyE1QH/Ysc1GAzQlGUV6N9eflZKnTqDbQLcA xAP6gis0D/zOpN5vIvtdPs/S9aX6QBZaZOjQZYy4SO0d8Vt0a+bPA5XVb5/cqYBzMeav /N+ny7v1PfXuBissKgHHq/QUhCBsgTSAOUNxVJpf2D/MBPOvY7PQncbFlBImwGheU/dy GruA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=H90Copkue5w9iSGNVPGNAw4Flq6Q55TWkIAdrELCwBM=; b=KHe5SicTMnA+prmnDN/Ii/dIX2Do1uxAkjDcdBm/SJyx7cWO6YwtPTbfRvMD2xpSEf sPaUj5dpZ8RiGak+rTAhJcwD8AFlHvlEGC1W2xosAzmshhTlzBlDCQNWVwNGC0PlEs1j l75No1XgXkrd/j1fcT7QoQWcXtn9Uza+vQHkKFD/xc5F3CCv6yaflhbuQHl8vOvBdEoD Q+EkXWBBjx2NWc1ikENmnrcL8w9bRMgJVw2NIY49IHvKE2/xVTRRbM7L9UAn125GjiKm BmSq1qyJO6qbypX1ravdO4LGXA2N+PAtoK43UxQWPKbiDlE22EdbIAjXUWDK0wwrzD76 jttg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=HE5O8LXK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d21si2276191jak.25.2021.07.08.11.46.44; Thu, 08 Jul 2021 11:46:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=HE5O8LXK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229631AbhGHSrH (ORCPT + 99 others); Thu, 8 Jul 2021 14:47:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50162 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229469AbhGHSrG (ORCPT ); Thu, 8 Jul 2021 14:47:06 -0400 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 741DEC061574 for ; Thu, 8 Jul 2021 11:44:24 -0700 (PDT) Received: by mail-lf1-x12f.google.com with SMTP id c28so17634300lfp.11 for ; Thu, 08 Jul 2021 11:44:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=H90Copkue5w9iSGNVPGNAw4Flq6Q55TWkIAdrELCwBM=; b=HE5O8LXKCYXmH5RUxvGLH0utBqVBpLQX5Kf2DIhBzYmckquTD2CtnsEicVLDaWZLpc 5YmOIWhkCu4PgVgf074nK1bz76AdI+h1P29IgsltIWF3Y5QNolavzbcwt7gmupgQM07Q i03U7ZtUn1Qe0zcSQgt+se4ZC7u48LjoEYOww= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=H90Copkue5w9iSGNVPGNAw4Flq6Q55TWkIAdrELCwBM=; b=aE3PZVq0XoEsJ5oJW7uEq1NDyoG8X5CE39xX5HByNau/YCeTv/387VUmm69L+etJnH K+tzg3PsHbd2bVLRTY5neehyYH25UGPAp8k/1537Xj7Q81gQaKerSfZyRDVFfegovf20 BCUjGjzRelxXA909+wi2KLiZDp4C4YQIuhR5r7/lXpL33J2l1WILNnE+DbK0MKPq27ep IWinBPcaYkIP/2QIaNtq32qcIOoFAY+LY8GePCAig2f4you2+FCLkmHMI4j5vNLR7g3x M2BtTaoDoRr1Y0ZwGZXwFJZr1eKzcwN80xTmibFDob2jcZe4RhI7cDrs2y94Nb4G7DGw aqcw== X-Gm-Message-State: AOAM530tkh+UKGHnL2Jw8R6FIaOa2EbwWa90z0eyfTjWRgMdFGSIkJyZ JP0/DTovdg9rfeNWm50DfGoNEVJRhKJ9fHRA+9M= X-Received: by 2002:a05:6512:3ca8:: with SMTP id h40mr25544692lfv.302.1625769862549; Thu, 08 Jul 2021 11:44:22 -0700 (PDT) Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com. [209.85.167.51]) by smtp.gmail.com with ESMTPSA id f23sm318826ljn.98.2021.07.08.11.44.22 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Jul 2021 11:44:22 -0700 (PDT) Received: by mail-lf1-f51.google.com with SMTP id 8so6466156lfp.9 for ; Thu, 08 Jul 2021 11:44:22 -0700 (PDT) X-Received: by 2002:a05:6512:3585:: with SMTP id m5mr24770812lfr.253.1625769861582; Thu, 08 Jul 2021 11:44:21 -0700 (PDT) MIME-Version: 1.0 References: <20210708103301.2109330-1-legion@kernel.org> In-Reply-To: <20210708103301.2109330-1-legion@kernel.org> From: Linus Torvalds Date: Thu, 8 Jul 2021 11:44:05 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2] Fix UCOUNT_RLIMIT_SIGPENDING counter leak To: Alexey Gladkov Cc: Linux Kernel Mailing List , Linux Containers , "Eric W . Biederman" , Oleg Nesterov Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 8, 2021 at 3:34 AM Alexey Gladkov wrote: > > We must properly handle an errors when we increase the rlimit counter > and the ucounts reference counter. We have to this with RCU protection > to prevent possible use-after-free that could occur due to concurrent > put_cred_rcu(). Thanks, LGTM. Applied, Linus