Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 8 Jul 2021 16:11:58 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Tom Zanussi <zanussi@kernel.org>
Cc:     linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Daniel Bristot de Oliveira <bristot@redhat.com>
Subject: Re: [PATCH 2/2 v3] tracing/histogram: Update the documentation for
 the buckets modifier
Message-ID: <20210708161158.7eaa6b13@gandalf.local.home>
In-Reply-To: <b0c64284cbba5613daaa5284a8dda1dcac60aead.camel@kernel.org>
References: <20210707213623.250212325@goodmis.org>
        <20210707213922.167218794@goodmis.org>
        <b0c64284cbba5613daaa5284a8dda1dcac60aead.camel@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 08 Jul 2021 15:05:16 -0500
Tom Zanussi <zanussi@kernel.org> wrote:

> > -    # echo 'hist:key=call_site:val=bytes_req' > \
> > +    # echo 'hist:key=call_site:val=bytes_req.buckets=32' > \
> >              /sys/kernel/debug/tracing/events/kmem/kmalloc/trigger  
> 
> This just seems random, not sure why you changed it, and it doesn't
> make sense on a val anyway..

Good catch! I originally wrote this to explain the buckets in this
location, and then realized it did not match the flow, and moved my text
down. It appears that I missed putting back the original trigger. Will fix
and send a v4.

> 
> The rest looks good, though, thanks for doing this!
> 
> Reviewed-by: Tom Zanussi <zanussi@kernel.org>

Thanks!

-- Steve