Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: linux-next: Fixes tag needs some work in the net tree
To:     Florian Fainelli <f.fainelli@gmail.com>,
        Stephen Rothwell <sfr@canb.auug.org.au>,
        David Miller <davem@davemloft.net>,
        Networking <netdev@vger.kernel.org>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Next Mailing List <linux-next@vger.kernel.org>
References: <20210709073104.7cd2da52@canb.auug.org.au>
 <30e28b44-b618-bdf5-cf4a-dc676185372d@gmail.com>
From:   Eric Dumazet <eric.dumazet@gmail.com>
Message-ID: <6e95b490-47d0-a5d0-b729-db2581e73e3c@gmail.com>
Date:   Thu, 8 Jul 2021 23:44:55 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <30e28b44-b618-bdf5-cf4a-dc676185372d@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 7/8/21 11:38 PM, Florian Fainelli wrote:
> On 7/8/21 2:31 PM, Stephen Rothwell wrote:
>> Hi all,
>>
>> In commit
>>
>>   9615fe36b31d ("skbuff: Fix build with SKB extensions disabled")
>>
>> Fixes tag
>>
>>   Fixes: Fixes: 8550ff8d8c75 ("skbuff: Release nfct refcount on napi stolen or re-used skbs")
>>
>> has these problem(s):
>>
>>   - No SHA1 recognised
>>
>> Not worth rebasing for, just more care next time.
> 
> It is there though:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=8550ff8d8c75416e984d9c4b082845e57e560984
> 
> and has the proper format AFAICT, what am I missing?
> 

This commit was the first commit, adding the bug.

Your commit changelog had :

    Fixes: Fixes: 8550ff8d8c75 ("skbuff: Release nfct refcount on napi stolen or re-used skbs")
    Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
    Reviewed-by: Roi Dayan <roid@nvidia.com>
    Reviewed-by: Eric Dumazet <edumazet@google.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>

See the extra Fixes: word ?