Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp188859pxv; Thu, 8 Jul 2021 18:32:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyuOAjsnNjo2FBhRz6+DoIjI4r1y9lqJC2hKYMMVcu813YKMDAnmT5Rn5qcpUj6luI56Gmq X-Received: by 2002:a05:6e02:b47:: with SMTP id f7mr24171071ilu.135.1625794344495; Thu, 08 Jul 2021 18:32:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625794344; cv=none; d=google.com; s=arc-20160816; b=kCJ/JOE4HfzUGMsYtr1gGV464KdvHmaRaUBcY/ntH31CjaiVmOg9W0D49A2MTvZYJg vQ22HMk/WVnko7A1mjPQu5hItTC8zV8CXtLVcdjfac7dRYfdHRy4zdiSWI8AC0hQb45l 9v6Q0IJDHON+OkgQKpM1cwVJ46E27hiFDGvkxM2EFHR2XDbErcKK20Hh9E1gqhP6/UYf qL3aeyQ3n5EigI1Phy7CfuV6Qo0QNZR7X8cnnPA/rsP1b34xwONGSU8ET6Yhx6CLwz+2 AqoF3lqZXNZjUKhVP9u4a2SRAmu41csUtNbo9qFwxHrl5iIEBRcZKChep+ji8taMcUYM 7RpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=iR/91e9r/pV24uz7F/ZCZMYq8GdTcOgKPN8iEDrQRb8=; b=Gv8sg+4obWrnAXfEnKjkDXgM6QL7SK4GoLnhYTzvhqFH85wGZ5FsyLK1u49KLmQoQV AsXO+oimmVt48bDYtDqWg9DZaUMPMGV9/4PgnNxPHrTY9Wbhl2dIfEiOMzXN/+Uwcxex Jbcxb0pBO0EjK1DRD5Hdh4zDDRSu5mcr8ok2Z3p2UMGkJxhDA4D12noMxsGmSXqcxmxc cw7A++sTFZP2Mv41y+7BlS25AKsvC/G6xP6Sdfmz+zCoILCV/K8eNJhOY0I5ghPKMg9s TAewTdrd838pCBYJSEUuuPCVy1kGHfyxi6KlEcuaPRXU3OoDUS/Ne7TaS5EdfQ1nRxMo 1ENQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=ljJbRil4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w25si416792iot.26.2021.07.08.18.31.57; Thu, 08 Jul 2021 18:32:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=ljJbRil4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230117AbhGIBdX (ORCPT + 99 others); Thu, 8 Jul 2021 21:33:23 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:47014 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229953AbhGIBdX (ORCPT ); Thu, 8 Jul 2021 21:33:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=iR/91e9r/pV24uz7F/ZCZMYq8GdTcOgKPN8iEDrQRb8=; b=ljJbRil4n+6JOT76mK3vtCkveF C2LNsuSXdXSMa33p02M3bMCMeg7pG/fthTEeE0tLgoSIPmnM+KjC9vIP5nGaP4+UxR0hsAGWhZzK/ tcxWx0uksOw18Anq1E0EHrtFWfzMUKLu8F8p7+vd39w3GejF5pVaIuxOzD/A6sXzSaiE=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1m1fLS-00ChH2-OR; Fri, 09 Jul 2021 03:30:22 +0200 Date: Fri, 9 Jul 2021 03:30:22 +0200 From: Andrew Lunn To: Florian Fainelli Cc: "Ismail, Mohammad Athari" , Heiner Kallweit , "David S . Miller" , Russell King , Jakub Kicinski , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH net] net: phy: reconfigure PHY WOL in resume if WOL option still enabled Message-ID: References: <20210708004253.6863-1-mohammad.athari.ismail@intel.com> <4e159b98-ec02-33b7-862a-0e35832c3a5f@gmail.com> <9871a015-bcfb-0bdb-c481-5e8f2356e5ba@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Ah yes you are right, we just skip resume in that case. OK let me think > about it some more. The point here is, it is an interrupt, from the perspective of the PHY hardware and its driver. But the interrupt handler is never being called because the interrupt output from the chip is not causing an actual interrupt. Fix that, and your problem goes away. Or you need to add a whole new mechanism that you are using the interrupt hardware in the PHY some something else than an actual interrupt. Andrew