Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <67e2e6b4fcbc2ec0bdda1e1af1cfe61d3c1fde6f.camel@redhat.com>
Subject: Re: [PATCH 1/6] KVM: nSVM: Check the value written to
 MSR_VM_HSAVE_PA
From:   Maxim Levitsky <mlevitsk@redhat.com>
To:     Paolo Bonzini <pbonzini@redhat.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>, kvm@vger.kernel.org
Cc:     Sean Christopherson <seanjc@google.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Cathy Avery <cavery@redhat.com>,
        Emanuele Giuseppe Esposito <eesposit@redhat.com>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        Michael Roth <mdroth@linux.vnet.ibm.com>,
        linux-kernel@vger.kernel.org
Date:   Fri, 09 Jul 2021 09:08:43 +0300
In-Reply-To: <4318c980-6eff-7b74-ae99-b3210021789d@redhat.com>
References: <20210628104425.391276-1-vkuznets@redhat.com>
         <20210628104425.391276-2-vkuznets@redhat.com>
         <595c45e8fb753556b2c01b25ac7052369c8357ac.camel@redhat.com>
         <4318c980-6eff-7b74-ae99-b3210021789d@redhat.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.5 (3.36.5-2.fc32) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 2021-07-08 at 19:27 +0200, Paolo Bonzini wrote:
> On 07/07/21 12:28, Maxim Levitsky wrote:
> > Minor nitpick: I would have checked the host provided value as well,
> > just in case since there is no reason why it won't pass the same check,
> > and fail if the value is not aligned.
> 
> The reason not to do so is that it would allow a guest running an old 
> kernel to defeat live migration.
I understand now, and I will keep this in mind next time.

Best regards,
	Maxim Levitsky

> 
> Paolo
> 
> > Other than that:
> > Reviewed-by: Maxim Levitsky<mlevitsk@redhat.com>