Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp357228pxv; Thu, 8 Jul 2021 23:24:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz85dkI9xTgwDIq4MOXJaqvJ/Zh8WEG3vRGAr7nv4vL3kN7/NqiAo2luxIxTOgRpT74XSO4 X-Received: by 2002:a05:6602:2bdc:: with SMTP id s28mr12687039iov.70.1625811871913; Thu, 08 Jul 2021 23:24:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625811871; cv=none; d=google.com; s=arc-20160816; b=GvXjnc/bbkoP7BSEsfcVmeJJf+lXDn46tA0LC0zQxyqkjhwZeOB8WkFdA7fBSyGEaJ qLus9dhrnViCCJpu5HoGWQsW42hwukuMm3IQFkT4GZsKOyoLrAlNgfGN3txXmcUtuYJm /Q+yk2hCFwaD6u1x/K5glkzBprEx4sqWvt2NWkRFzxcjJv0a8Zn5jumV05oyeWP1QYON na8sT33bDnGSPLPS6+dapPyIi9Rg+3NJ7bd7ngwjEHa+xZc2Rlzg7OcVefySrWNCJfFd 6h4WqO+9TO+Qq3H7TmRyuXbnnqXTv9j2fnh9ANg3J1nhAKm/N5zslA0wqQgNgt0iCrxY 0s2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=qAkS4ma6ehZVj7hlgoQzRiUO0M0ZEIWgqlnqCWow+Cs=; b=VNVQdoDT5/OCyjwUgiTt1PqySZQpeT/ROmRYkQgzGkUn0HLKRjiF0oZhpMrdkyDp9C dROd8eOqS7yga0PbQLtnh2EjpboI/RS3UVOFWlIYiMl6ZWZIPwd0bOi9D/llCMM7By8d qjBuQT2/EqCbwypncE/xSOv5q/DEcbcbmdo/x3tcxbtZOt60HB4q8GqZy8RaLXpMZqwF 4O/CGIBEBHL40iswH9xzCQiOn3WhxdiBN7x+66qSkIJisrcAcbFX4pb6pfsNOpR4QA29 JR0djkMCAbevNLHhE8Jte9p8PxcJjPwCyeeE2GgVR+2kTNeUpErKBt51pD2xGiUlZsui pdwQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=NvbfrMHm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s13si4568452ioj.45.2021.07.08.23.23.53; Thu, 08 Jul 2021 23:24:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=NvbfrMHm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230126AbhGIGXv (ORCPT + 99 others); Fri, 9 Jul 2021 02:23:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33940 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229494AbhGIGXv (ORCPT ); Fri, 9 Jul 2021 02:23:51 -0400 Received: from mail-qt1-x834.google.com (mail-qt1-x834.google.com [IPv6:2607:f8b0:4864:20::834]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6BFEDC0613DD for ; Thu, 8 Jul 2021 23:21:08 -0700 (PDT) Received: by mail-qt1-x834.google.com with SMTP id w13so6907050qtc.0 for ; Thu, 08 Jul 2021 23:21:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=qAkS4ma6ehZVj7hlgoQzRiUO0M0ZEIWgqlnqCWow+Cs=; b=NvbfrMHmiWncf/2/WfmW+ymtGZkMI7x7J/bWVleXbGBsTnR9yw+Nr1eDRxwKiEWS3Y gZfomcB+aNZvDl/CGNfUvVq/m0Xn8W3GhRkoueX6VcThQzEwX97atKgjCMA5z2xwnbpk VP7FejY2z+blSJsL9QBgCBmWrtgGfCdc+/TFf2XN/0MTVz9KSpDBIvYgfRMYxArgM1hg c5SF/HcicpNOK9CqINx4I+WdU355JaOwJ0rIVnpqC1tDz/S5wxSUTE5r5dF6CYWNycKY oAh3M7ZBHtwW+jvB2xyrj/U74LrgW774WPKxu1k2xrObubfqqy6gYyUZHELSTYDPuu1K NItA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=qAkS4ma6ehZVj7hlgoQzRiUO0M0ZEIWgqlnqCWow+Cs=; b=h00ZcPJfTL8xSLWOu4Nr5KdiT9Mka4WJHSOA8NwCdcmXgoN43Z2Mc378RC3n5m90x3 YjzV7UaXXkbAxyKX5PGWg9f3sB+ivNporvC+GOLXu5sw1ios7q1VWNj4HLugPxhOwZOr ErKiG3lfyVDo8Nls9zRUiBF4KWFtC9P3Z0dIzSVL0paD8JO4SlLoCV/iiWA1wKm2Tg+r A8BqYmXGeLsL8dTxrlQfApmBy5XJ3FUW+nNcMfcyxTCmBvXLw0lFnMwoQKTyR9HDgWSl CckACA6sd1FnFZtKf01pwoWajixIHt2mGfkrMLgVZMuEwfoSqDt2amK0C6RAQtCBECON pjGQ== X-Gm-Message-State: AOAM531RwI/onf1kHeXyDb3GXA1HjDBJo7LTxmYmt4NsfTRnfhTZjN78 Pl2rvxG7To2RfN/KK0yf/QUWZfWmHA4= X-Received: by 2002:aed:2065:: with SMTP id 92mr30905472qta.283.1625811667358; Thu, 08 Jul 2021 23:21:07 -0700 (PDT) Received: from localhost ([207.98.216.60]) by smtp.gmail.com with ESMTPSA id t30sm2056644qkm.11.2021.07.08.23.21.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jul 2021 23:21:06 -0700 (PDT) Date: Thu, 8 Jul 2021 23:21:05 -0700 From: Yury Norov To: linux-kernel@vger.kernel.org Cc: Andy Shevchenko , Rasmus Villemoes , Petr Mladek , Steven Rostedt , Sergey Senozhatsky , Tejun Heo Subject: Re: [PATCH 2/2] bitmap: introduce for_each_set_bitrange Message-ID: References: <20210709034519.2859777-1-yury.norov@gmail.com> <20210709034519.2859777-3-yury.norov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210709034519.2859777-3-yury.norov@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 08, 2021 at 08:45:19PM -0700, Yury Norov wrote: > bitmap_list_string() is very ineffective when printing bitmaps with long > ranges of set bits because it calls find_next_bit for each bit. We can do > better by detecting ranges of set bits. > > This patch introduces a macro for_each_set_bitrange and uses it in > bitmap_list_string(). In my environment, before/after is 943008/31008 ns. Ah, it seems we already have bitmap_for_each_{set,clear}_region() with the same functionality. I'll check everything again and submit v2 soon.