Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp371889pxv; Thu, 8 Jul 2021 23:44:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy2iJ9EXPtDG9hseV9ZtyzvoGtq3KmxfAR1rjbuVQimvvds2tJNmBvtkN75jr28E5boGeBN X-Received: by 2002:a05:6e02:219a:: with SMTP id j26mr25387578ila.272.1625813065536; Thu, 08 Jul 2021 23:44:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625813065; cv=none; d=google.com; s=arc-20160816; b=dLAaUsfATeaSz3TAtXW8xDZWYpZLA4ZgTQN798B5KOSIJbFvy5Il0YasJjDEQZ+eq8 u0Ywfw/+Jucx8iKDnLEy5jeiebnqde4cX8shDOcIj1fr3WJiZ0L1mPxbvuQBLsOFWXyq Lipd1PPCjpLDPKnpSRbqry6ECn+F+4g2fttfpWhW+WpbMS6mY6vo3mgtRvhVBHm7zxuy H3pirTImkNHZ7Z5/FM/0WNUngV8cKdVsp8Cjh9TZv+RG6FugqS2pt9KJXNNBiyQWxUel g5eFDT4+llBSXp4OMbNlv0dZsaCCB6MIGJWPg8tbTsaabyKd3xFbg58I9XjagIE0T4j1 Hh0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:message-id:date:subject:cc:to:from; bh=NeyPtgOd7oL5k4j+k6Ge867HPWu+l4VoHD49pUOouKs=; b=twFcxAcWK4rErHyn5TA7GM8fRMF/Tq2d/SlMw8eTBwoedUDSX3UwTYhmcF71ocoY4b d3TcU33mUvdeq3AiRSy/85jytipgTqM/F41PiOWHvjI4HPYL2eRVLZYgyJw63XrNbwi3 YoPWv01ePhWXEAno3XkQBVu0YfC9H16yKWC41s3TN75DXO9eDuxyVGgcP3QmvxUNweBA xuMlzOoIdFTDk2hhL2sUX0aNtPFGo/8UTUJzd9Sjtw5riJgPrVSbNB+xyO6TUsPEZJVt wO6d/soWH4ebny1LvcSRQA5VDdQxjbQwAk/LhyBPCKmkUxUv+F2Csz37FMWRaWm6xWfG +Ycw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r4si4947844ilt.108.2021.07.08.23.44.13; Thu, 08 Jul 2021 23:44:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230497AbhGIGqP (ORCPT + 99 others); Fri, 9 Jul 2021 02:46:15 -0400 Received: from mga05.intel.com ([192.55.52.43]:41600 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230178AbhGIGqO (ORCPT ); Fri, 9 Jul 2021 02:46:14 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10039"; a="295293985" X-IronPort-AV: E=Sophos;i="5.84,226,1620716400"; d="scan'208";a="295293985" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jul 2021 23:43:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,226,1620716400"; d="scan'208";a="648869584" Received: from ahunter-desktop.fi.intel.com ([10.237.72.79]) by fmsmga005.fm.intel.com with ESMTP; 08 Jul 2021 23:43:27 -0700 From: Adrian Hunter To: "Rafael J . Wysocki" Cc: Greg Kroah-Hartman , Saravana Kannan , "Martin K . Petersen" , "James E . J . Bottomley" , linux-scsi@vger.kernel.org, Avri Altman , Bean Huo , Can Guo , Asutosh Das , Bart Van Assche , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH V2 0/2] driver core: Add ability to delete device links of unregistered devices Date: Fri, 9 Jul 2021 09:43:39 +0300 Message-Id: <20210709064341.6206-1-adrian.hunter@intel.com> X-Mailer: git-send-email 2.17.1 Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi There is an issue with the SCSI UFS driver when the optional BOOT well-known LUN fails to probe, which is not a fatal error. The issue is that the device and its "managed" device link do not then get deleted. The device because the device link has a reference to it. The device link because it can only be deleted by device_del(), but device_add() was never called, so device_del() never will be either. These V2 patches fix the issue by amending device link removal to accept removal of a link with an unregistered consumer device, as suggested by Rafael. Changes in V2: Take approach suggested by Rafael Adrian Hunter (2): driver core: Add ability to delete device links of unregistered devices scsi: ufshcd: Fix device links when BOOT WLUN fails to probe drivers/base/core.c | 11 ++++++++--- drivers/scsi/ufs/ufshcd.c | 23 +++++++++++++++++++++-- 2 files changed, 29 insertions(+), 5 deletions(-) Regards Adrian