Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Sa, Nuno" <Nuno.Sa@analog.com>
To:     Liam Beguin <liambeguin@gmail.com>,
        "lars@metafoo.de" <lars@metafoo.de>,
        "Hennerich, Michael" <Michael.Hennerich@analog.com>,
        "jic23@kernel.org" <jic23@kernel.org>,
        "charles-antoine.couret@essensium.com" 
        <charles-antoine.couret@essensium.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>
Subject: RE: [PATCH v1 0/4] AD7949 Fixes
Thread-Topic: [PATCH v1 0/4] AD7949 Fixes
Thread-Index: AQHXdFTlcRfBdRSKwUuzfOuE6CaMR6s6S3Sg
Date:   Fri, 9 Jul 2021 08:12:28 +0000
Message-ID: <PH0PR03MB6366DF122EE2B4499BF3088099189@PH0PR03MB6366.namprd03.prod.outlook.com>
References: <20210708235618.1541335-1-liambeguin@gmail.com>
In-Reply-To: <20210708235618.1541335-1-liambeguin@gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?uDyDVH/NQrt8UUsmf7RqcfMloPbltknW2D2M4um91o5ns7r9+OfJMrk0U7?=
 =?iso-8859-1?Q?m+/6L7/2gpwcEvi6KSBnTEf+OeIcVaUDfWbx5VB59nd2yIxt7ykHy2go48?=
 =?iso-8859-1?Q?2c2sVbLoizg6GxwrDJVMW6A5JMj1KOT/GH/fLYoguZKJJvE74hMo0SjIGB?=
 =?iso-8859-1?Q?QaXS9+R4lPiyHM0RK1vmgOpZl3lqL/yYKw6L872fJP2vVSajPDyWXOaD/M?=
 =?iso-8859-1?Q?e/w3aKYIDccVwFYQrAiB+id5aMqyw5wUehADqaV4q3GU17BqtQpt/9WpTM?=
 =?iso-8859-1?Q?BvllaW7hhL4T2w3BjhWapkh3S0zfnhN3M+DoSMkyTOSfCFrrqOVA6hzcyT?=
 =?iso-8859-1?Q?d5mAUuoBH2aoTbaM48lJXvF4RyV5BzayYvrsIsd2fblbiTzBq7PQdQAcDh?=
 =?iso-8859-1?Q?ilpXHSoCs3rdtaaJim8VeWBKzbeE/uzOA8te59+7fwXQG4xKhtBTvx8eKT?=
 =?iso-8859-1?Q?RVRXQBex/7GuS8z44W2Q8zPnY5Kq4jwMDNMwdsiZmUMLL0mmnJtaI60UJq?=
 =?iso-8859-1?Q?e0zgr0fMNYmTrFZkvgF9VIjbSZom04TBoQzV7+T9tZNfUdCCgknzw2MXoH?=
 =?iso-8859-1?Q?TMV7K2Ff0vPH+K1cC+8zQe1+KfTdQTU39L3DP6XpWWJoIhN+QlAWJdG6ze?=
 =?iso-8859-1?Q?9aInIxChLq5+AoDD5TYsTRrRhbdwqhvsQEMyW6BVVckUDIRU8037puzI26?=
 =?iso-8859-1?Q?GVabx1yu/b8flkfNrv6Nd+tIV2iwevrUPdagC8sZI9ZP6B0aWJeNVE8i+I?=
 =?iso-8859-1?Q?m1DjA+U7XFqmkgpqz9qR8VGDz4cCCBk7CZJevEZn+6y+GMVBGCUwsp91r1?=
 =?iso-8859-1?Q?f19cPfgwLxEr8fvnEwWS/yfAY3GsLNFd1PxEZlEhQBvf3y15kJdLZaEsNj?=
 =?iso-8859-1?Q?8VCngViHS2jDDQoTGg8WVfk0BeXz1wW1+isWpDI1tqUaPJ//raHbMtYU2U?=
 =?iso-8859-1?Q?i2DHBRwF6F3iGFQZuOWR2kGATedxkm44Kc7tBG+svlKEZNkRFrbuTqN5mY?=
 =?iso-8859-1?Q?WxQU8TfOL1nnnBFIVbUYyR4io0+edw6ivDnncuFToIMAL5nvyg4bHydZrH?=
 =?iso-8859-1?Q?veEvgfupo0dtH8Skbdxj5ezdRVYaTEj7SneIWdIroPuwncZoYgewlIQVXx?=
 =?iso-8859-1?Q?FL17JBJtChoh5CAH6Mlom5dwJX5LQCTu8LcuTARg8eomx/6z0z+xeFBOf2?=
 =?iso-8859-1?Q?BspWFaoCKwv13KKAo3XaDesVJCKFuXWvhO2ugmHLbfoFjCU0RQ8XfUu92F?=
 =?iso-8859-1?Q?MC9G7tdMaqkYNu8lntHSyGXg6q/SyQoicE5R+WGY/DPTJqQmmB5oPyf+Tc?=
 =?iso-8859-1?Q?9CKIagHt3iDZbsGXXh5QWcPNFHQOVM2vjUH9QaKR1vG+YfCIwrJLzBrSx0?=
 =?iso-8859-1?Q?2NHnNBd+hyJMDnfBgJlGA0qyxzhdib1sJtSHxFj6+/xgn4e7hC0mScmdkT?=
 =?iso-8859-1?Q?+rRp0CskiVCL0srA?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: analog.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB6366.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 038af0fc-ebf3-450d-d39f-08d942b14b25
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jul 2021 08:12:28.5965
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: eaa689b4-8f87-40e0-9c6f-7228de4d754a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Y40Ehd5IKTmrALBexRUsJl6JZtSM3P2oObqeNf6NJLFpZkvMgfVwS6W/vaSqMqw/n3QeyjzOiQ01rCvsdVNg4Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB5798
X-Proofpoint-ORIG-GUID: gryva2ymgy8IhkorXnHcyuBwiTqFfoLs
X-Proofpoint-GUID: gryva2ymgy8IhkorXnHcyuBwiTqFfoLs
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.790
 definitions=2021-07-09_04:2021-07-09,2021-07-09 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0
 bulkscore=0 mlxlogscore=999 priorityscore=1501 lowpriorityscore=0
 suspectscore=0 clxscore=1011 mlxscore=0 spamscore=0 impostorscore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2104190000 definitions=main-2107090041
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Liam,

The series looks good. Just some minor comments from my side...

Thanks!
- Nuno S=E1

> From: Liam Beguin <liambeguin@gmail.com>
> Sent: Friday, July 9, 2021 1:56 AM
> To: liambeguin@gmail.com; lars@metafoo.de; Hennerich, Michael
> <Michael.Hennerich@analog.com>; jic23@kernel.org; charles-
> antoine.couret@essensium.com
> Cc: linux-kernel@vger.kernel.org; linux-iio@vger.kernel.org;
> devicetree@vger.kernel.org; robh+dt@kernel.org
> Subject: [PATCH v1 0/4] AD7949 Fixes
>=20
> [External]
>=20
> While working on another series[1] I ran into issues where my SPI
> controller would fail to handle 14-bit and 16-bit SPI messages. This
> addresses that issue and adds support for selecting a different voltage
> reference source from the devicetree.
>=20
> This is base on a series[2] that seems to not have made it all the way,
> and was tested on an ad7689.
>=20
> [1]
> https://urldefense.com/v3/__https://patchwork.kernel.org/project/li
> nux-iio/list/?series=3D511545__;!!A3Ni8CS0y2Y!rF7O-WxC7HZM4hv_o-
> zYPtVCmZlDoASzPvamwwQkH9llVS8J-GpfQltvDBz7gQ$
> [2]
> https://urldefense.com/v3/__https://patchwork.kernel.org/project/li
> nux-
> iio/list/?series=3D116971&state=3D*2A&archive=3Dboth__;JQ!!A3Ni8CS0y2Y!
> rF7O-WxC7HZM4hv_o-zYPtVCmZlDoASzPvamwwQkH9llVS8J-GpfQluZ-
> w3LYA$
>=20
> Thanks for your time,
> Liam
>=20
> Liam Beguin (4):
>   iio: adc: ad7949: define and use bitfield names
>   iio: adc: ad7949: fix spi messages on non 14-bit controllers
>   iio: adc: ad7949: add support for internal vref
>   dt-bindings: iio: adc: ad7949: add adi,reference-source
>=20
>  .../bindings/iio/adc/adi,ad7949.yaml          |  22 ++
>  drivers/iio/adc/ad7949.c                      | 191 +++++++++++++++---
>  2 files changed, 181 insertions(+), 32 deletions(-)
>=20
>=20
> base-commit: 6cbb3aa0f9d5d23221df787cf36f74d3866fdb78
> --
> 2.30.1.489.g328c10930387