Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Sa, Nuno" <Nuno.Sa@analog.com>
To:     Liam Beguin <liambeguin@gmail.com>,
        "lars@metafoo.de" <lars@metafoo.de>,
        "Hennerich, Michael" <Michael.Hennerich@analog.com>,
        "jic23@kernel.org" <jic23@kernel.org>,
        "charles-antoine.couret@essensium.com" 
        <charles-antoine.couret@essensium.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>
Subject: RE: [PATCH v1 4/4] dt-bindings: iio: adc: ad7949: add
 adi,reference-source
Thread-Topic: [PATCH v1 4/4] dt-bindings: iio: adc: ad7949: add
 adi,reference-source
Thread-Index: AQHXdFTvOSLYpfdoO0egPAoeDBe7A6s6S7CA
Date:   Fri, 9 Jul 2021 08:15:30 +0000
Message-ID: <PH0PR03MB6366E7E1CBDC15B6B43F8BC699189@PH0PR03MB6366.namprd03.prod.outlook.com>
References: <20210708235618.1541335-1-liambeguin@gmail.com>
 <20210708235618.1541335-5-liambeguin@gmail.com>
In-Reply-To: <20210708235618.1541335-5-liambeguin@gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?8tiR8WLvv+tlX/BtgLQmpSmHHMnwZOceOy1cyY14gSBbwLYM5hI+2Q/mpf?=
 =?iso-8859-1?Q?HG5GWf00Kzivbd81q54wg0Pafhkf4rK8NQBhIhSTtbTcDl6vF9Yc/IFbLb?=
 =?iso-8859-1?Q?dwhNyy/u+NL7cImTUuIHM9nKIYPpYwPUg1J6OAHq6mwJqXRSfJqLfoGIGk?=
 =?iso-8859-1?Q?3PoiSzVppScicUZKtDGcjHkWSgsT1Tcz8q5E4cYFgmERgJDds63joPch0e?=
 =?iso-8859-1?Q?DWEHUbFEMBxk2LoFuD3dCQsQtO5kswxFEpfLVu0PSpwJRznB0x8sSop8uG?=
 =?iso-8859-1?Q?9y0HGaX9TBTeaVlIXQCXpmiDJiMP4wpfMjlntuzKs/OqB5rO1OFUdxGbjz?=
 =?iso-8859-1?Q?es3hG9R2gvU9yWThu89wtNTIZOe0jmHBJTW3+ArJp5NHHbcSyYCv9plD5j?=
 =?iso-8859-1?Q?YvX4u3yIBXFkLMh5pL7aiJe9zyZq5ww89MVF9grrUyQvFzFRphnkIRVRbx?=
 =?iso-8859-1?Q?3Lh+6RIGgYisXeU30oTCw6NnO2+pvSL81kfvYN/DtVtBxwva8ygySehGjI?=
 =?iso-8859-1?Q?snVXYsLKUKgc5Encl8Nq+hCGVElihu8W3mZlT3b0nv5dwTjD85qyNfDeWd?=
 =?iso-8859-1?Q?ZkClrM2q5u6B3FRap5uRUH9iN5zu1Sa8O5I+7n7Vxj42/N4CSELui2lScK?=
 =?iso-8859-1?Q?rz8iPu4+t+AfVKSAcyH2vWP13lEewmE00TcunAlGbvVMAML+aDRQhjBGcG?=
 =?iso-8859-1?Q?v+XVkMUZNNCShAhR2n8EUqnD6UcgXRUld/JWx1r2kUHdXYZFLjxMFnqphM?=
 =?iso-8859-1?Q?0lGr2iz2RjcpN8bDg55TZzG80UiRs95AdYZVcyIE1IxkWIS7VYZLQ/TJjB?=
 =?iso-8859-1?Q?f8SZfiYkqCd0C0frpFF+ZoEVL0F8HuLjJwoXZqki2GIzDHkAW3BHL/p2dH?=
 =?iso-8859-1?Q?emLGltj9VyeybTn6vl0ZmCmpcRDQTjIQEb1QYKwnZqJmBcsSXx20fKMQmf?=
 =?iso-8859-1?Q?OqUF62r8ukFR2erskg5Dtzt9AB5+SBsvbqa6q+jK5ajc5NRMrSyOyaJXi4?=
 =?iso-8859-1?Q?xl+nYbAL+pyxeqYJgCIsrNSf8MwRJn3CX2drlrq0OnVSTGk7sJBNN+JJ6n?=
 =?iso-8859-1?Q?3aLvf6FWC80IE5y0yE1mGzzVqOYVEFwYtevNIVToEVUKEJAU4hU0baUg/4?=
 =?iso-8859-1?Q?8NXr2XNz9ETMlU0DF65mnEND1vCV7mIOgVoD69cu6jTs2sRvJhZlibFALh?=
 =?iso-8859-1?Q?YznFZI9bGjaTa0VM4c1ugkoNwtQZL4cuuB/PCSNZ2+lgRoEhNESpV3kSR0?=
 =?iso-8859-1?Q?3I5C9hi1sKzODpuZddy46JKU2oNXoB2QvD+hQu5BKTTn984IDu/KG7lG+/?=
 =?iso-8859-1?Q?u4SS2rGhvzoshSK1/jDUSjLUuaX4Tu3xbFoyrnns4A5IcV9UcTdTTOPAX3?=
 =?iso-8859-1?Q?Za1NuTLkvg9F1AjIjupOZQPalwaC97nr8ucHxSE7Ln3RS01aEE4UgXdQfq?=
 =?iso-8859-1?Q?EJhE0u1XP2NSihVi?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: analog.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB6366.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bac8b0e2-0d25-4790-09e5-08d942b1b78e
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jul 2021 08:15:30.4435
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: eaa689b4-8f87-40e0-9c6f-7228de4d754a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: LWACNG2S3AEKC+BZBer4c4AXIk7IsghDxjap20OIioGISwZTL9zMVLHc4vPJnDLCJnWR+VxRa82JlmsJfoYcSg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB5943
X-Proofpoint-GUID: yNTCOnadpCrhLAER8U_adBX7sb547v7t
X-Proofpoint-ORIG-GUID: yNTCOnadpCrhLAER8U_adBX7sb547v7t
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.790
 definitions=2021-07-09_04:2021-07-09,2021-07-09 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 bulkscore=0
 priorityscore=1501 suspectscore=0 spamscore=0 mlxlogscore=999 adultscore=0
 impostorscore=0 clxscore=1015 malwarescore=0 phishscore=0
 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2104190000 definitions=main-2107090041
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Liam Beguin <liambeguin@gmail.com>
> Sent: Friday, July 9, 2021 1:56 AM
> To: liambeguin@gmail.com; lars@metafoo.de; Hennerich, Michael
> <Michael.Hennerich@analog.com>; jic23@kernel.org; charles-
> antoine.couret@essensium.com
> Cc: linux-kernel@vger.kernel.org; linux-iio@vger.kernel.org;
> devicetree@vger.kernel.org; robh+dt@kernel.org
> Subject: [PATCH v1 4/4] dt-bindings: iio: adc: ad7949: add
> adi,reference-source
>=20
> [External]
>=20
> From: Liam Beguin <lvb@xiphos.com>
>=20
> Add bindings documentation for the adi,reference-source property.
> This property is required to properly configure the ADC sample request
> based on which reference source should be used for the calculation.
>=20
> Signed-off-by: Liam Beguin <lvb@xiphos.com>
> ---
>  .../bindings/iio/adc/adi,ad7949.yaml          | 22 +++++++++++++++++++
>  1 file changed, 22 insertions(+)
>=20
> diff --git
> a/Documentation/devicetree/bindings/iio/adc/adi,ad7949.yaml
> b/Documentation/devicetree/bindings/iio/adc/adi,ad7949.yaml
> index 9b56bd4d5510..3f4629281cc8 100644
> --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7949.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7949.yaml
> @@ -35,6 +35,28 @@ properties:
>    "#io-channel-cells":
>      const: 1
>=20
> +  adi,reference-select:
> +    allOf:
> +      - $ref: /schemas/types.yaml#/definitions/uint32
> +      - enum: [0, 1, 2, 3, 6, 7]
> +
> +    default: 7
> +    description: |
> +      Select the reference voltage source to use when converting
> samples.
> +      Acceptable values are:
> +      - 0: Internal reference and temperature sensor enabled.
> +           Vref=3D2.5V, buffered output
> +      - 1: Internal reference and temperature sensor enabled.
> +           Vref=3D4.096V, buffered output
> +      - 2: Use external reference, temperature sensor enabled.
> +           Internal buffer disabled
> +      - 3: Use external reference, internal buffer and temperature
> sensor
> +           enabled.
> +      - 6: Use external reference, internal buffer and temperature
> sensor
> +           disabled.
> +      - 7: Use external reference, internal buffer enabled.
> +           Internal reference and temperature sensor disabled.

I think typically the description comes first. I also don't think you
need the 'allOf'(not even sure if it will pass the binding check)...
Just have '$ref' and 'enum' on the same level.

- Nuno S=E1

>  required:
>    - compatible
>    - reg
> --
> 2.30.1.489.g328c10930387