Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Nava kishore Manne <navam@xilinx.com>
To:     Greg KH <gregkh@linuxfoundation.org>
CC:     "robh+dt@kernel.org" <robh+dt@kernel.org>,
        Michal Simek <michals@xilinx.com>,
        "mdf@kernel.org" <mdf@kernel.org>,
        "trix@redhat.com" <trix@redhat.com>,
        "arnd@arndb.de" <arnd@arndb.de>, Rajan Vaja <RAJANV@xilinx.com>,
        Amit Sunil Dhamne <amitsuni@xlnx.xilinx.com>,
        Tejas Patel <tejasp@xlnx.xilinx.com>,
        "zou_wei@huawei.com" <zou_wei@huawei.com>,
        Sai Krishna Potthuri <lakshmis@xilinx.com>,
        Ravi Patel <ravipate@xlnx.xilinx.com>,
        "iwamatsu@nigauri.org" <iwamatsu@nigauri.org>,
        Jiaying Liang <jliang@xilinx.com>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-fpga@vger.kernel.org" <linux-fpga@vger.kernel.org>,
        git <git@xilinx.com>,
        "chinnikishore369@gmail.com" <chinnikishore369@gmail.com>
Subject: RE: [RFC v2 1/4] drivers: firmware: Add user encrypted key load API
 support
Thread-Topic: [RFC v2 1/4] drivers: firmware: Add user encrypted key load API
 support
Thread-Index: AQHXXPOwkA5yuq5AZUmrKpOBPVz+/KsLcSuAgC8PpRA=
Date:   Fri, 9 Jul 2021 08:41:35 +0000
Message-ID: <PH0PR02MB7336410E513B4D026BB4983EC2189@PH0PR02MB7336.namprd02.prod.outlook.com>
References: <20210609055232.4501-1-nava.manne@xilinx.com>
 <20210609055232.4501-2-nava.manne@xilinx.com> <YMCP/+uYMun478Z9@kroah.com>
In-Reply-To: <YMCP/+uYMun478Z9@kroah.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?nu1DpCMn4OediWoZx65QsSoL4K8GN4NHVn3GL2TaJweG4qPF8ElJ4O9W8luS?=
 =?us-ascii?Q?F1XhpyiEWLzL2QWYjzS5H1qA+Hq+wgMhCDGXuoiGUTTsU10eWpxkypq1oQ5h?=
 =?us-ascii?Q?4GFjcuCVNfktNjUF/vbAsgpCx/TuJ09ae5ozyspAqIYYcuVwgUxFb5yFrMSV?=
 =?us-ascii?Q?6fiVF5jjRl+W3wUufGcNscxXG+mXSqH5XWB6NeLJSF4pm3iBHMV6DjXdKexk?=
 =?us-ascii?Q?66Dl7y7VSDSAoISd/DdkiZQ5FkYcXwFiQwK49yRyGQd0BNmIfvzWBKqLIQ6R?=
 =?us-ascii?Q?hSNdmk6EW1qdBqRx2xebI/QPvPlctzm5C7Z7li0P86IWTe3KuQuCQRzkr0AX?=
 =?us-ascii?Q?CUtQjVBxZq6CDdq5YPGIM/rHovM1ydTEeaAmfrV8qZAkNxJSkCzDhBPI4i2K?=
 =?us-ascii?Q?QXSHV96t2mc48hrMTK3m1ksoVJC22JYmHi6DrVfvC7zK3qBSYCQs6weV2TpN?=
 =?us-ascii?Q?tqYbx4HZyz5qBN70ejlkyoxyhl7Ew79w9xGlEJ1lLUQogk9pS9HDlL8uYGSZ?=
 =?us-ascii?Q?Y/Q1GDsyyGOdadeNA2N8WRu4gyBOafCsAqYwPnLfRJ7tRSycnwgzV61B3Te8?=
 =?us-ascii?Q?V5AKKhZFP+ZPioKtrC6mA0s0wZ1NHuaALuH/AuO7rxUKVsvZ2EhXZRdNUrg9?=
 =?us-ascii?Q?ny2NTFQ1PobiGPHsCMSOpp1R+w6wLbMPastRZljwuH9/xj+C2hjmwvrw4uD6?=
 =?us-ascii?Q?v7ZZ2Q0o4/fxw0J4tZTjtcgHMj/413/LHmKYol45a1O3Ww3unXaAvcIlInnA?=
 =?us-ascii?Q?QIQG+fnRYznhdRNorSdM+8a00hKSetEnVlOVrq3AfKx9eZzuN/FNaaW6n5K2?=
 =?us-ascii?Q?XuUy4YyCx+LayHG4r557qxYSAlnTmcjqa7cxA3oRK2mEP4z1W9TaGoJH/7U9?=
 =?us-ascii?Q?cAcsiJ6mzWkSTMdLebwvrjyL8QOF+26oXkEq3dfClS4LZ8wjRZg0uBcXN9gs?=
 =?us-ascii?Q?3Sz46Je8tywmAoiN6wruqwxL7Nr4F/uZwwctsJq6xKIljlFE+KzMftZHNh8E?=
 =?us-ascii?Q?6P5ZgJDewgOcDnaepvAdVrs5d3VuLkaW6l2be2+QUfdFIl+g7NTTxta6syls?=
 =?us-ascii?Q?ROTBT2jjvoei+VM7vwdsCc+2kUbXg1IPOx8Fb//ur6BKG7BQNSZ2N1uP//Xi?=
 =?us-ascii?Q?DAOCJRprKj/wIsSdnrkvOG7gRxmu5RV9EimvaK20X98H3H7QNcvcM/sXI57R?=
 =?us-ascii?Q?ddnwoOU2eAvCQbH0cKUhHr+sOUUkt6JI7SHSqQt2IBtxmGKumMcqA5dEhRHR?=
 =?us-ascii?Q?lPpn+VStvAOD7TnLlxYlRHPNkZPbcDLbULWQhc+MTVFLdFEy+PXqwpKw4NTd?=
 =?us-ascii?Q?acu3GpwRJ0RIQ6eb+y3YjOmL?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: xilinx.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7336.namprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a398dbb9-879c-4bb7-49a5-08d942b55c9f
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jul 2021 08:41:35.8887
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: FjBquLAAEuInkPDfD3QHLKYKSN4g2h3b8RJmZdOhaUlRPVo3+JA86wJzRiyT2Dr4G6klnd5uIDN2zdlkP1bvhQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR02MB8583
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Greg,

	Thanks for providing the review comments.
Please find my response inline.

> -----Original Message-----
> From: Greg KH <gregkh@linuxfoundation.org>
> Sent: Wednesday, June 9, 2021 3:25 PM
> To: Nava kishore Manne <navam@xilinx.com>
> Cc: robh+dt@kernel.org; Michal Simek <michals@xilinx.com>;
> mdf@kernel.org; trix@redhat.com; arnd@arndb.de; Rajan Vaja
> <RAJANV@xilinx.com>; Amit Sunil Dhamne <amitsuni@xlnx.xilinx.com>;
> Tejas Patel <tejasp@xlnx.xilinx.com>; zou_wei@huawei.com; Sai Krishna
> Potthuri <lakshmis@xilinx.com>; Ravi Patel <RAVIPATE@xilinx.com>;
> iwamatsu@nigauri.org; Jiaying Liang <jliang@xilinx.com>;
> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
> kernel@vger.kernel.org; linux-fpga@vger.kernel.org; git <git@xilinx.com>;
> chinnikishore369@gmail.com
> Subject: Re: [RFC v2 1/4] drivers: firmware: Add user encrypted key load =
API
> support
>=20
> On Wed, Jun 09, 2021 at 11:22:29AM +0530, Nava kishore Manne wrote:
> > This patch adds user encrypted key load API to support User key
> > encrypted images loading use cases from Linux.
>=20
> What is "user key encrypted images"?  Do we need more documentation
> here for what this is and how to use it?
>=20

Xilinx bitstream writer, using AES, encrypts the bitstream. This feature al=
lows user to encrypt bitstream using 256-bit AES encryption in cipher block=
 chaining (CBC) mode.
User can supply a 128-bit Initial Vector and 256-bit key(user key).
For more info please refer here:=20
https://www.xilinx.com/support/documentation/application_notes/xapp1239-fpg=
a-bitstream-encryption.pdf=20

> And why is "User" capitalized?
>=20

Will fix.

Regards,
Navakishore.