Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp471062pxv; Fri, 9 Jul 2021 02:08:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx0xjhmzUJhYUZkNuWtmhbwS/hrC6Kx3pS1Em4cvVJC4DFG3CJkMrPgksYN9Qylc4JzI6ni X-Received: by 2002:a05:6e02:1e03:: with SMTP id g3mr25572901ila.248.1625821712554; Fri, 09 Jul 2021 02:08:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625821712; cv=none; d=google.com; s=arc-20160816; b=o+LXR05Enxa0qzU4z1T8Pb+hEHE6RQ1xobJTs4QP7e0h5cplpIqNTJ+0Uqc9XW1eUv YGFANaovjojVsdbCYwmtXum2AMZV8czWSVQ/yV2PKVRJE+1Kt2bts4KVUqgz+i0fz52x bAn8bO9P5OCyBG0KVePBJo5IkdPFtAK8axmk3V5KdUWz5TITuIDg/FEoEsBCllnGNYgc fGgEk2GQ4bnogRGhu1NTwOFzJxIIdaWTdsTrWfAAiAQghlZ9lf1/zrjAEWB5ltzTbwNN 26DWCgvyZ7cGdujUh/n0DaqDt+6tGL/qYXgRR4k+79kFV3SJDEFHqXDjd3a9f8qhj1Kz h/hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=/uc9H5zfGGjDARI0YzyvKzeEpD2wOClc3tIHfeaLQnc=; b=vjWqzvSRM/+2OHKxC33O8W12ZK95I/nmJH6+PBItgP6NyTMKf1T5Umqfh34j8OCRBD 1Y11WapG03wxcxn1f00AGoZ/lSbkcvdBvIW1nrsWr2e0f3iESiak6PzWoof5eB4kAj7t DnmcHemPDbBqNUYCMKhAhZJzSNfM456y8AOJQhHUnok6vGPXJ3GCfgbwtzvNWdDslaTV PMGy7HNkH2RjiBEoxBQgt1n/AuYpr0FT07e8f29+8GXNuFyxR+8hzYk0efg3ODYAcRWw h5W1NujcILXv7LH7AFywOD1tLkAM1C6GYIkvAJ/T76atPbDnoPZE82o978uKitDoSykX TpHA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=M+M0yYUE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e6si5726556ilm.61.2021.07.09.02.08.20; Fri, 09 Jul 2021 02:08:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=M+M0yYUE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231743AbhGIJKB (ORCPT + 99 others); Fri, 9 Jul 2021 05:10:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43088 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231573AbhGIJKA (ORCPT ); Fri, 9 Jul 2021 05:10:00 -0400 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E5A8C0613DD for ; Fri, 9 Jul 2021 02:07:17 -0700 (PDT) Received: by mail-pj1-x102d.google.com with SMTP id g6-20020a17090adac6b029015d1a9a6f1aso6825966pjx.1 for ; Fri, 09 Jul 2021 02:07:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=/uc9H5zfGGjDARI0YzyvKzeEpD2wOClc3tIHfeaLQnc=; b=M+M0yYUEtZSkXRq1SttoHZPElhf5y1HWt6Uqd2WPOVvykCW2uMKJo+dWqB/b7T/uAQ fjosM8Kqi5f4SzbPGwYgm4oKpWD1wzaolrW0tjV2nOJFb+dnjxqqmOLl52TBqBzgacFW P0+adWQQUibpuf3s3sD9DAyLwdemH1TUc3jSA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=/uc9H5zfGGjDARI0YzyvKzeEpD2wOClc3tIHfeaLQnc=; b=j2M0gL/bauQsFaiscDmCfIsawVw0I8G0R3eZRSmpPtppqza2DIo5pNhVXUdwrG5J9p gOa5hETaaotBBTGzf0Gen/KYDFshvyNTeGjVsfSYqz2kC8SrqTMLfoptxwVXntG/OZAo 5f2s0yYXWYD+tWcmrwREylSWI823kkdJ8+wS5xO7RwuIiGMvXeRm9YLCsg0/UhYvpkkR dmsPbubw+WBygzwjDvvXVKuWXMCCqB8pQl/HLDnhFIUBbGXsegaBTZdYi7MjgMfYSIqm ZYHFp4Xh02SKOMLevsXjgFMo48GVwU7cVwnfNpBjuTiWoaWydSJT/E/7nEXqWu5W4H2u Mu2g== X-Gm-Message-State: AOAM532YEarVgmE7hk+fJhq6AgJcfzxFjBbThsbqxeZ56PxAl261w5Td Wy8mWi3yds2PeGTwhTeTBJJ7jQ== X-Received: by 2002:a17:90a:4595:: with SMTP id v21mr9612932pjg.202.1625821636697; Fri, 09 Jul 2021 02:07:16 -0700 (PDT) Received: from chromium.org ([2401:fa00:8f:203:735b:c3cc:6957:ae6d]) by smtp.gmail.com with ESMTPSA id 21sm4831945pfh.103.2021.07.09.02.07.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Jul 2021 02:07:16 -0700 (PDT) Date: Fri, 9 Jul 2021 18:07:11 +0900 From: Tomasz Figa To: Tzung-Bi Shih Cc: "kyrie.wu" , Hans Verkuil , Mauro Carvalho Chehab , Rob Herring , Bin Liu , Matthias Brugger , Tzung-Bi Shih , Project_Global_Chrome_Upstream_Group@mediatek.com, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, xia.jiang@mediatek.com, maoguang.meng@mediatek.com, srv_heupstream@mediatek.com Subject: Re: [PATCH v2,3/9] media: mtk-jpegenc: remove redundant code of irq Message-ID: References: <1625038079-25815-1-git-send-email-kyrie.wu@mediatek.com> <1625038079-25815-4-git-send-email-kyrie.wu@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 06, 2021 at 07:00:33PM +0800, Tzung-Bi Shih wrote: > On Wed, Jun 30, 2021 at 3:28 PM kyrie.wu wrote: > > the func of jpgenc irq handler would not compatible, remove those > > code. > Need more explanation about why as I believe it is non-backward compatible. Right. And it breaks bisection, which is not acceptable. Kyrie, please structure your series in a way that none of the patches break any existing functionality. Best regards, Tomasz