Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210709064341.6206-1-adrian.hunter@intel.com>
 <20210709064341.6206-2-adrian.hunter@intel.com> <YOgdBGBEYNndLLwa@kroah.com>
In-Reply-To: <YOgdBGBEYNndLLwa@kroah.com>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Fri, 9 Jul 2021 13:19:37 +0200
Message-ID: <CAJZ5v0g8fbV6ansDQOM7WchbE3tzvd5iFmnvu2wTOu-F4enM0g@mail.gmail.com>
Subject: Re: [PATCH V2 1/2] driver core: Add ability to delete device links of
 unregistered devices
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Adrian Hunter <adrian.hunter@intel.com>,
        "Rafael J . Wysocki" <rafael@kernel.org>,
        Saravana Kannan <saravanak@google.com>,
        "Martin K . Petersen" <martin.petersen@oracle.com>,
        "James E . J . Bottomley" <jejb@linux.ibm.com>,
        "open list:TARGET SUBSYSTEM" <linux-scsi@vger.kernel.org>,
        Avri Altman <avri.altman@wdc.com>,
        Bean Huo <huobean@gmail.com>, Can Guo <cang@codeaurora.org>,
        Asutosh Das <asutoshd@codeaurora.org>,
        Bart Van Assche <bvanassche@acm.org>,
        Linux PM <linux-pm@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Jul 9, 2021 at 11:55 AM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Fri, Jul 09, 2021 at 09:43:40AM +0300, Adrian Hunter wrote:
> > Managed device links are deleted by device_del(). However it is possible to
> > add a device link to a consumer before device_add(), and then discover an
> > error prevents the device from being used. In that case normally references
> > to the device would be dropped and the device would be deleted. However the
> > device link holds a reference to the device, so the device link and device
> > remain indefinitely.
>
> Why are you not just manually removing the link you just created?  You
> manually added it, you know something failed so you need to clean up, so
> why not clean this up too?

His changes are needed to do just that.