Subject: Re: [PATCH] ALSA: hda-intel - Disable MSI support by default
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: David Miller <davem@davemloft.net>
Cc: jeff@garzik.org, torvalds@osdl.org, linux-kernel@vger.kernel.org,
       tiwai@suse.de
In-Reply-To: <1163643937.5940.342.camel@localhost.localdomain>
References: <455A938A.4060002@garzik.org>
	 <20061114.201549.69019823.davem@davemloft.net> <455A9664.50404@garzik.org>
	 <20061114.202814.70218466.davem@davemloft.net>
	 <1163643937.5940.342.camel@localhost.localdomain>
Content-Type: text/plain
Date: Thu, 16 Nov 2006 13:28:35 +1100
Message-Id: <1163644115.5940.346.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 671
Lines: 19


> Is this disable_intx() thingy something x86 specific ? I mean, you can't
> just call disable_irq() for LSIs since you can be sharing it. If you
> aren't sharing, free_irq() will mask for you.

Oops .. my bad, forgot about that new command register bit. When was it
added ? pci 2.3 ?

Also, it should probably be done by pci_disable_device() ... in fact, to
be safe, the driver should disable that before free_irq().

Ben.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/