Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp690798pxv; Fri, 9 Jul 2021 06:58:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwnOYd4wd4yPTl4F4kYempogmjq8nt4iQiywB5FbrWCUu4ejxRSZ2J1Dzio39jyCyLoUtzC X-Received: by 2002:a92:6605:: with SMTP id a5mr28451503ilc.15.1625839105610; Fri, 09 Jul 2021 06:58:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625839105; cv=none; d=google.com; s=arc-20160816; b=qGUBYPr2J52t6Ige1mTLkIVEoX+bAmrFnXqsZm1sK2/Rh+p4hPgxWNiFziy3XAcUyc IfPCYiUxeCWiLeD6rUhHbfYm85QYhxMMCKLU10WnQrK+JqCjssMH2OiXcF/AFw4wGN5R pOlcn/j3Q4Zu2yNoCAzkI/FvRf5pli8xo26EGYW2Ik0EmLvGUMwqo8eAtiLqcvKu/bOj 97bI98wSe6v4iouvYSRuETGpnf6k3ypiK76KcyKCAaNuvS/k+UhhLmvaTqgvX7/KVFNn 7o4FFAwAbpT8M/ADX1S0jT0n2CQIWEtbGrP5jS9bfoRvRf5CREpDpq13HI38vZNGpuCF yiRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=rQ6e5V2VDsAV0jIfYfyLFHJJm9TckWl0wsLsAjLc320=; b=lqLCvU1M4UApF+DNyYBW/hOvB64TwwfcMdAjP/mF57kccNIsKqs2z9PoZmvrVyXrlL AMTxm2Ksy/rVDka+XgamLMuvW2FS2a5o1hzwu6ecVxadpNMon2GBCcGR4UKKiEwvcP/6 mADvJsUaXNSUyDmyWwD9Hbp3KVqpN0nuTv5XYa0udeP2f9A/UswoTIXTb74qvEflz7xD tUcG0UR1hTaSJ+AfSBN8a2GLW+BErKCQC3OwgiwppyL/wTO1MP8liiUt5Bv182Q9jCru oAkKaOcTYM2hXKWXxc7LOHFPo/Vmw+K0PMeWU0BpYzm2pmgHpU189yd7gR71Ebr7QlQ6 5k5Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t3si6541984ile.109.2021.07.09.06.58.12; Fri, 09 Jul 2021 06:58:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231950AbhGIN7n (ORCPT + 99 others); Fri, 9 Jul 2021 09:59:43 -0400 Received: from foss.arm.com ([217.140.110.172]:53552 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231454AbhGIN7m (ORCPT ); Fri, 9 Jul 2021 09:59:42 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7BF5FED1; Fri, 9 Jul 2021 06:56:58 -0700 (PDT) Received: from [10.57.35.192] (unknown [10.57.35.192]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 000A63F694; Fri, 9 Jul 2021 06:56:52 -0700 (PDT) Subject: Re: [PATCH v2 0/3] iommu: Enable non-strict DMA on QCom SD/MMC To: Joerg Roedel , Doug Anderson Cc: Ulf Hansson , Linux Doc Mailing List , Peter Zijlstra , linux-pci@vger.kernel.org, Konrad Dybcio , Thierry Reding , Joel Fernandes , Rajat Jain , Will Deacon , Rob Clark , Saravana Kannan , Jonathan Corbet , quic_c_gdjako@quicinc.com, Linux ARM , Viresh Kumar , Veerabhadrarao Badiganti , "Paul E. McKenney" , linux-arm-msm , Bjorn Helgaas , Sonny Rao , Vlastimil Babka , Randy Dunlap , Linux MMC List , Adrian Hunter , LKML , "list@263.net:IOMMU DRIVERS" , Joerg Roedel , iommu@lists.linux-foundation.org, Andrew Morton , "Maciej W. Rozycki" References: <20210624171759.4125094-1-dianders@chromium.org> From: Robin Murphy Message-ID: Date: Fri, 9 Jul 2021 14:56:47 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-07-08 09:08, Joerg Roedel wrote: > On Wed, Jul 07, 2021 at 01:00:13PM -0700, Doug Anderson wrote: >> a) Nothing is inherently broken with my current approach. >> >> b) My current approach doesn't make anybody terribly upset even if >> nobody is totally in love with it. > > Well, no, sorry :) > > I don't think it is a good idea to allow drivers to opt-out of the > strict-setting. This is a platform or user decision, and the driver > should accept whatever it gets. > > So the real question is still why strict is the default setting and how > to change that. Or document for the users that want performance how to > change the setting, so that they can decide. As I mentioned before, conceptually I think this very much belongs in sysfs as a user decision. We essentially have 4 levels of "strictness": 1: DMA domain with bounce pages 2: DMA domain 3: DMA domain with flush queue 4: Identity domain The "make this device go faster because I trust it" use-case is why we have the sysfs interface to switch between 2 and 4, so it's entirely logical to have the intermediate option as well for when 3 is "faster" enough while still giving a bit more peace of mind than full-on bypass. Making it a platform-specific decision that's hidden in a driver - arm-smmu-qcom can be considered a dumping ground of detailed platform knowledge ;) - happens to work as a reasonable compromise for this specific case, but I concur that it could be viewed as setting a precedent for other cases which we definitely aren't as reasonable. I've been thinking about the sysfs thing some more, and since it's Friday afternoon and I can't concentrate on what I'm supposed to be doing anyway, let's see how far I can get by Monday... Robin.