Received: by 2002:a05:6a10:f3d0:0:0:0:0 with SMTP id a16csp694088pxv; Fri, 9 Jul 2021 07:02:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyTUoP2zcLpAPYSjae3SPym9wZllzWJ9zwFdXB3GiOpTmzOBBzi2vE/nDTpHu1VBarQGpR2 X-Received: by 2002:a05:6e02:106d:: with SMTP id q13mr4958804ilj.164.1625839338206; Fri, 09 Jul 2021 07:02:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1625839338; cv=none; d=google.com; s=arc-20160816; b=p+2jSMSC7rX+1gp3hbnQ8AjQ4I27k1xmav5rph2qcMEBUYAlGqbBvI5s0xx1Vv302K zOkq3lrpA6Rqqyqks9KR1hjmhwbMUKvkZF8CzitG6KaN0/YxrYP7Np36pSuhrmI6WNCr IP7nNMC6ajjWwi7ddanBf67dIceSsCEmJcoxLYcuvL3vGdTHE66RS7Uy/soH7YzZrjmw iAYZ8jttNyOjrBhbl/KgAVVFe8jKiRCHXNpeFRvDj9YWQZayijrElaoXHTUVW5C63uYF 6i2V3QpXC7IOoTIiUymUiT7TA46BjXhmjku67ALoBBFWsTrZL6KY56WFT4uUt9nsDxk2 qTpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=qiOUB7HLvLlvZOpZ/gkN2JlQJ5E4mMeYNLinigOA+9s=; b=OylqtGYerwyyrUuMdBM/fNxmuvXHNWe3o5lTrUNXHnJHc5DfFuvkUwlIxIJdcGR72y Zb5K0NgoDBbjCjeYApIx1AxMLXYu3O4wf/PqUR/DDYtFekFVFAFAIDOkOwJja8mCETMk 6VGjSzTfuSqrT+z5r9tEe0SJ6PJ0I3NHOoLquGiLNbkwGqcFg93bQLJR63ai6PmSHUiB 9vQSe004cUjH54Z/f8HnMp0lWn/XIkknOfM72s5oQ6wT0wFLc0Jbvqk2eO5RJfqPexXH Dp0MX/xiKIwLmJLTlTL4GuQo04vjuM3c9NiLvn0hsXcPqw+Klj5bKzio6pZ3X0cZMx7e kOvw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=T3wAp9Do; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o11si6972911ils.18.2021.07.09.07.01.57; Fri, 09 Jul 2021 07:02:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=T3wAp9Do; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232079AbhGIODy (ORCPT + 99 others); Fri, 9 Jul 2021 10:03:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53870 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229499AbhGIODx (ORCPT ); Fri, 9 Jul 2021 10:03:53 -0400 Received: from mail-ot1-x32a.google.com (mail-ot1-x32a.google.com [IPv6:2607:f8b0:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80053C0613DD for ; Fri, 9 Jul 2021 07:01:10 -0700 (PDT) Received: by mail-ot1-x32a.google.com with SMTP id f93-20020a9d03e60000b02904b1f1d7c5f4so8706111otf.9 for ; Fri, 09 Jul 2021 07:01:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qiOUB7HLvLlvZOpZ/gkN2JlQJ5E4mMeYNLinigOA+9s=; b=T3wAp9DoNvgWy0Ro/pS13nqAvPokAxi8LgstNsyBbwHLqLqINLmtfgoFs/Q+BlwsIj 8gvKq/S9P92Ny6t7qSxlsWjHtwZcDtNlGlFjVqIfX3ba00kPul2dqbIUTDiz2sOPMEWj EP/uYiL2UszRtbPSpERLnzSKOQQ6pm2kpZxkI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qiOUB7HLvLlvZOpZ/gkN2JlQJ5E4mMeYNLinigOA+9s=; b=jiLoviXs20TQQU8yUpU/+NRNhuwF//0q/p1EvUDWetbuFtdkoVpioRs8NeQjSvoY9f M2+4cu124E0Qmvms5JX/J/CybvFxNsyYSxt9NnwdmXSTzxJhw+jxKw+sUMfrMrRI7QrG 7HQhtfNbknfN4Wj/hyp8DbT3ZtsdEXyGWhoWgpbbZMRuXtUbgdAdRVhLlg69pSU+E8UN b3JP8nj7NUI32R0Ja6vKRLNWcI3aLXp/cmtx51YiSry3qroYH+i7Rz7EmlzVesGjvtML RSz0Js0YVBF8y3NnuAyId0YmOrgwORGnVvsYgsGzl084q8jqNEAUxpigXvZCidqfoETA v1zQ== X-Gm-Message-State: AOAM530kH/MNSnvxEQpP/95yp7kLWym0XShIeWdTcWKncNNTeMFIEE9I T7L89UuQimoMdM8d2UxVez9vWJYLnyi/AA== X-Received: by 2002:a05:6830:1203:: with SMTP id r3mr582042otp.197.1625839269849; Fri, 09 Jul 2021 07:01:09 -0700 (PDT) Received: from mail-oo1-f44.google.com (mail-oo1-f44.google.com. [209.85.161.44]) by smtp.gmail.com with ESMTPSA id 48sm1118297otf.13.2021.07.09.07.01.09 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Jul 2021 07:01:09 -0700 (PDT) Received: by mail-oo1-f44.google.com with SMTP id l26-20020a4ac61a0000b029024c94215d77so2261983ooq.11 for ; Fri, 09 Jul 2021 07:01:09 -0700 (PDT) X-Received: by 2002:a25:6088:: with SMTP id u130mr49090811ybb.257.1625838856780; Fri, 09 Jul 2021 06:54:16 -0700 (PDT) MIME-Version: 1.0 References: <1624726268-14869-1-git-send-email-rajeevny@codeaurora.org> In-Reply-To: <1624726268-14869-1-git-send-email-rajeevny@codeaurora.org> From: Doug Anderson Date: Fri, 9 Jul 2021 06:54:05 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [v8 0/6] drm: Support basic DPCD backlight in panel-simple and add a new panel ATNA33XC20 To: Rajeev Nandan Cc: dri-devel , linux-arm-msm , freedreno , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , LKML , Thierry Reding , Sam Ravnborg , Rob Clark , Lyude Paul , Jani Nikula , Rob Herring , Laurent Pinchart , Andrzej Hajda , Daniel Thompson , "Kristian H. Kristensen" , Abhinav Kumar , Sean Paul , Kalyan Thota , Krishna Manikandan , Lee Jones , Jingoo Han , linux-fbdev@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Sat, Jun 26, 2021 at 9:52 AM Rajeev Nandan wrote: > > This series adds the support for the eDP panel that needs the backlight > controlling over the DP AUX channel using DPCD registers of the panel > as per the VESA's standard. > > This series also adds support for the Samsung eDP AMOLED panel that > needs DP AUX to control the backlight, and introduces new delays in the > @panel_desc.delay to support this panel. > > This patch series depends on the following two series: > - Doug's series [1], exposed the DP AUX channel to the panel-simple. > - Lyude's series [2], introduced new drm helper functions for DPCD > backlight. > > This series is the logical successor to the series [3]. > > Changes in v1: > - Created dpcd backlight helper with very basic functionality, added > backlight registration in the ti-sn65dsi86 bridge driver. > > Changes in v2: > - Created a new DisplayPort aux backlight driver and moved the code from > drm_dp_aux_backlight.c (v1) to the new driver. > > Changes in v3: > - Fixed module compilation (kernel test bot). > > Changes in v4: > - Added basic DPCD backlight support in panel-simple. > - Added support for a new Samsung panel ATNA33XC20 that needs DPCD > backlight controlling and has a requirement of delays between enable > GPIO and regulator. > > Changes in v5: > Addressed review suggestions from Douglas: > - Created a new API drm_panel_dp_aux_backlight() in drm_panel.c > - Moved DP AUX backlight functions from panel-simple.c to drm_panel.c > - panel-simple probe() calls drm_panel_dp_aux_backlight() to create > backlight when the backlight phandle is not specified in panel DT > and DP AUX channel is present. > - Added check for drm_edp_backlight_supported() before registering. > - Removed the @uses_dpcd_backlight flag from panel_desc as this > should be auto-detected. > - Updated comments/descriptions. > > Changes in v6: > - Rebased > - Updated wanrning messages, fixed word wrapping in comments. > - Fixed ordering of memory allocation > > Changes in v7: > - Updated the disable_to_power_off and power_to_enable panel delays > as discovered at (Douglas) > > Changes in v8: > - Now using backlight_is_blank() to get the backlight blank status (Sam Ravnborg) > - Added a new patch #4 to fix the warnings for eDP panel description (Sam Ravnborg) > > [1] https://lore.kernel.org/dri-devel/20210525000159.3384921-1-dianders@chromium.org/ > [2] https://lore.kernel.org/dri-devel/20210514181504.565252-1-lyude@redhat.com/ > [3] https://lore.kernel.org/dri-devel/1619416756-3533-1-git-send-email-rajeevny@codeaurora.org/ > > Rajeev Nandan (6): > drm/panel: add basic DP AUX backlight support > drm/panel-simple: Support DP AUX backlight > drm/panel-simple: Support for delays between GPIO & regulator > drm/panel-simple: Update validation warnings for eDP panel description > dt-bindings: display: simple: Add Samsung ATNA33XC20 > drm/panel-simple: Add Samsung ATNA33XC20 > > .../bindings/display/panel/panel-simple.yaml | 2 + > drivers/gpu/drm/drm_panel.c | 108 +++++++++++++++++++++ > drivers/gpu/drm/panel/panel-simple.c | 73 +++++++++++++- > include/drm/drm_panel.h | 15 ++- > 4 files changed, 190 insertions(+), 8 deletions(-) Pushed to drm-misc-next. 4bfe6c8f7c23 drm/panel-simple: Add Samsung ATNA33XC20 c20dec193584 dt-bindings: display: simple: Add Samsung ATNA33XC20 13aceea56fd5 drm/panel-simple: Update validation warnings for eDP panel description 18a1488bf1e1 drm/panel-simple: Support for delays between GPIO & regulator bfd451403d70 drm/panel-simple: Support DP AUX backlight 10f7b40e4f30 drm/panel: add basic DP AUX backlight support -Doug