Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Rolf Eike Beer <eike-kernel@sf-tec.de>
To:     James.Bottomley@hansenpartnership.com,
        Carlos Bilbao <bilbao@vt.edu>
Cc:     deller@gmx.de, linux-parisc@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: parisc: Update iosapic driver with proper printks
Date:   Fri, 09 Jul 2021 18:05:05 +0200
Message-ID: <7261873.EvYhyI6sBW@daneel.sf-tec.de>
In-Reply-To: <5760611.lOV4Wx5bFT@iron-maiden>
References: <5760611.lOV4Wx5bFT@iron-maiden>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="nextPart3608610.kQq0lBPeGt"; micalg="pgp-sha1"; protocol="application/pgp-signature"
Precedence: bulk

--nextPart3608610.kQq0lBPeGt
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"

Am Freitag, 9. Juli 2021, 15:38:44 CEST schrieb Carlos Bilbao:
> The code from the old I/O Sapic Driver is outdated when it comes to printks.
> Fix applying proper indentation and using dev_dbg() instead of printk on
> debugging blocks. Also add a KERN_<LEVEL> where it is missing.

Have you actually tried building this? I bet not:

> +#define DBG(x...) dev_dbg(x)

> +	DBG("io_sapic_info at %p\n", isi);
> +	DBG("\t\tisi_hpa:       %lx\n", isi->isi_hpa);
> +	DBG("\t\tisi_status:    %x\n", isi->isi_status);
> +	DBG("\t\tisi_version:   %x\n", isi->isi_version);
> +	DBG("\t\tisi_vector:    %p\n", isi->isi_vector);
>  }
>  #endif /* DEBUG_IOSAPIC */

You are not passing a struct device here, so this will not work.

Eike
--nextPart3608610.kQq0lBPeGt
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.
Content-Transfer-Encoding: 7Bit

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQSaYVDeqwKa3fTXNeNcpIk+abn8TgUCYOhzsQAKCRBcpIk+abn8
TpaCAJ9mOyggOWP67DN4nfSxWms8582CewCfb47IkLCOfV43CQ9Q4Y4qoMnAqhE=
=a80g
-----END PGP SIGNATURE-----

--nextPart3608610.kQq0lBPeGt--