Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Sunil Muthuswamy <sunilmut@microsoft.com>
To:     Wei Liu <wei.liu@kernel.org>
CC:     KY Srinivasan <kys@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        Stephen Hemminger <sthemmin@microsoft.com>,
        Wei Liu <liuwe@microsoft.com>,
        Dexuan Cui <decui@microsoft.com>,
        Michael Kelley <mikelley@microsoft.com>,
        "linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Rob Herring <robh@kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>
Subject: RE: [EXTERNAL] Re: [PATCH 1/1] PCI: hv: Support for create interrupt
 v3
Thread-Topic: [EXTERNAL] Re: [PATCH 1/1] PCI: hv: Support for create interrupt
 v3
Thread-Index: Add0TIVdcQX5pMV/TWWUfz5smDdQ7AAYBcoAAAzvoMA=
Date:   Fri, 9 Jul 2021 16:42:13 +0000
Message-ID: <MW4PR21MB200200F17E1D0E4AEEA87D0DC0189@MW4PR21MB2002.namprd21.prod.outlook.com>
References: <MW4PR21MB20025B945D77BBFDF61C6DA8C0199@MW4PR21MB2002.namprd21.prod.outlook.com>
 <20210709102434.c4hj4iehumf7qbj7@liuwe-devbox-debian-v2>
In-Reply-To: <20210709102434.c4hj4iehumf7qbj7@liuwe-devbox-debian-v2>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+G9mdU9YIDdcYMryNwsENnm7x6O73a3n4JqmiTz4T8ZiRCg+JCTxbNL0JQV+?=
 =?us-ascii?Q?LeJkie1tcNf7/cWmQY5DstcAlRQmJsC8YiZP4DxcfyVtuttnSGxWZQQ4GroR?=
 =?us-ascii?Q?FEecUHt9ShAdxgo0MOmOrUweQ8SFPdkocb7dx1E3nl3CiAq4rp0i/fXpt61C?=
 =?us-ascii?Q?WNF5y+BRLNFea9qXnN+OJ7z4BFoEXySTV0/fTXoT4CZOH8VHLD5durMXIRkB?=
 =?us-ascii?Q?PI0myeXxEc8zLI1QPtpA3SEol0i87cd8YdlUOIRMTYqQ9OItiiAK7o5prhz0?=
 =?us-ascii?Q?5Vb7dzP17iXFxxMSeJS9gMqebY0bVQRaouoGC9THTE3kZdTVWF+8oaY1s0gL?=
 =?us-ascii?Q?BRTgQHq7eSBD0T+u9VacPM30m7hwGf+XOvvI0dQFWiwWPsTWg7h8GJAM72SS?=
 =?us-ascii?Q?CuUYP79gwW1ndJF2km6f5qYsiY5mCFjal44c1XXVkuBh3UIqgW5fAdcNffHO?=
 =?us-ascii?Q?8c65YzlmSwqTwSA1ybGtP6zfbcVtokI7bWyfrtKVlaZc5/981ZOQ9lOebvSU?=
 =?us-ascii?Q?PJuersbyfOsWexnToLeSzUlrh9jSMvH11gvDk9XpEIHzOrzA9JZHViETLex+?=
 =?us-ascii?Q?UQl0in0/QAc9u0n2GOO3uvOcH60CB2wgg11XZ/2jydnQa1g0doyVBXSnEu9E?=
 =?us-ascii?Q?ZBTNK8T3qlM+UwBtnb9c7bTDylpnI8sMzc9igIxAyVADQVwoYa59IMHwYBQj?=
 =?us-ascii?Q?X/9Naf8FOY7L/c7+rTdaghsgC2njSmEsbXTjO8BwN3ktXWd1Fh3Q9mt4Dh8M?=
 =?us-ascii?Q?brAImkJNSaoDPgXjsCtZ1Jn2FYfKGknYSJdPx/TQ3eMUZIb7csQxHgbEKFHc?=
 =?us-ascii?Q?YFVoAu8kK1r9IdNQDFvMLF7ezBA75kX7c00lPoPk7YdRj6GFhfAJo+vUEI7J?=
 =?us-ascii?Q?BPfJ4OVmoK8U/rzDu8G9QYiQ+FoA9H0I7Q+v2q6SyYmmbofbSJxrUcuke7oD?=
 =?us-ascii?Q?dAgIOtr2V9c0W+TfZvMSDpR4A78/r5BAOtD/5g8HLLaORxHT6pRzMbk/WYXp?=
 =?us-ascii?Q?/o9FoX3dGRtQdv5/0uy3lVgg53t5K78AMuB1zsSG/+dr/4YaADPBmKNYZCVg?=
 =?us-ascii?Q?l4OL5gr/yGQx29FclO+recQN/oa0RU7swnRUrGMxCjoN2MS4BzGznCbHgOUn?=
 =?us-ascii?Q?aE0c+ED+delEJtBO08sLnh8K71xxEg5h9oTr1JiLVTwlmlm0k6WpzA1Ej+Ek?=
 =?us-ascii?Q?BYBKD9g1Qvo8Y1bc4JBJdY0hzWttqHt4tOvO98EEJqaE6n1Qq22H6Ul6PsIt?=
 =?us-ascii?Q?uixLtzHYksrJq3Bbe8w5Aqg8qZU6aMojZYyFYZR9xbPX9q/ltzeLCtQBHUnO?=
 =?us-ascii?Q?0LZuE4J0F3u0dAcYtyL3yxRWv+WkhwMR8pIHrSrfHhJpqIRKsdYwuSccqktq?=
 =?us-ascii?Q?NVra/WbwVdq+2AeurICDSGcIDNkp?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: microsoft.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW4PR21MB2002.namprd21.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c2a6a17e-4ab9-46b7-218b-08d942f8814b
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jul 2021 16:42:13.6649
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: golI9Z5X0mYpbMJOZ8dokA5Syu8qyZqwvTK3XSqL66goMhj/wh41rsqEenN+KHJnAUdARUPzt69P9Rk3rLDUb8IWngfs+fHievQRkcDOtHo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR21MB0510
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> > +/*
> > + * struct hv_msi_desc3 - 1.3 version of hv_msi_desc
> > + *	Everything is the same as in 'hv_msi_desc2' except that the size
> > + *	of the 'vector_count' field is larger to support bigger vector
> > + *	values. For ex: LPI vectors on ARM.
> > + */
> > +struct hv_msi_desc3 {
> > +	u32	vector;
> > +	u8	delivery_mode;
> > +	u8	reserved;
> > +	u16	vector_count;
> > +	u16	processor_count;
> > +	u16	processor_array[32];
> > +} __packed;
> > +
> >  /**
> >   * struct tran_int_desc
> >   * @reserved:		unused, padding
> > @@ -383,6 +402,12 @@ struct pci_create_interrupt2 {
> >  	struct hv_msi_desc2 int_desc;
> >  } __packed;
> >
> > +struct pci_create_interrupt3 {
> > +	struct pci_message message_type;
> > +	union win_slot_encoding wslot;
> > +	struct hv_msi_desc3 int_desc;
> > +} __packed;
> > +
> >  struct pci_delete_interrupt {
> >  	struct pci_message message_type;
> >  	union win_slot_encoding wslot;
> > @@ -1334,26 +1359,55 @@ static u32 hv_compose_msi_req_v1(
> >  	return sizeof(*int_pkt);
> >  }
> >
> > +static void hv_compose_msi_req_get_cpu(struct cpumask *affinity, int *=
cpu,
> > +				       u16 *count)
>=20
> Isn't count redundant here? I don't see how this can be used safely for
> passing back more than 1 cpu, since if cpu is pointing to an array, its
> size is not specified.
>=20
> Wei.

Yes, it is at the moment. But, the function can be extended in the future t=
o take
a size as well. But, it will always be 1 and I preferred keeping that infor=
mation
with the implementation. If you have preference, I can hard code that in th=
e
caller. It seems fine for me either ways.

- Sunil